From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 188F6C61DA4 for ; Thu, 9 Mar 2023 11:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T3OQk1AgV1vDUoKK7AQU1ltwUFelx9AgmyrlJVmHiuo=; b=mRQpvAnG6+RNqe Bqf5bpnrrw80s1JT+teNcmoa/MIYcy7bc6L7j91x0YY71oXmGgmWS2c10sm9E5hJI4ROw2q2rIxhd /TfITq0LB8q98qllFdBMvKMeciw3H/aDoSxeZg0huzRPuf1APcl0XLkdnqPy+FXoixe+tdrT/31Xr KE1nLCCFm9Sjav3ZwuOzToHvGwjZMNzX36P3I+DPFxapqIKkYgwrgVVb0mQZwZUXdCAZ7cjT62y/V KH61V0FYuqlWrc+r9XWS6qus28+QiIzEWCcBECMf2tYoEKZNePKeWWrRMCZgmJsbVnQc4XX23JEr1 yU1OnmOTk9wY7ZYBZVbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paEbB-009aEl-9A; Thu, 09 Mar 2023 11:38:17 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paEMv-009SW2-SV for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 11:23:35 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4641D10000E; Thu, 9 Mar 2023 11:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678361007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nFB/XzUgcCAZanhIP6AKbNu6CZh3ZVa2Xw1P9FE3XKU=; b=i74aRkvD0oj/7IcNRKWPBzJhbEnD9BxREtMgeu2+Ic1ouSWkVmpx89UD2aEE+Ch2cUWsUV yShn53mLBgk/zBu6/96vEQd51E/9hV4ukYDp3M99J8B+LUb1vtVxlyCnuW13tJoG+R39SG Vl9S7zfHu4yoGfCur9XqUEzWYv42Mm2/CM+N6bWu+J0Wi4e8M9JxC5lO6vI3ex2fYf4tCk YNieGatb2k1UY5KBFLvhwSd9JLfUExt27K8zwVG2IOeDFnWL622H9SQpR4OUO6XXSSwyho omft0YbNKbPbqZbVxFE3WBn7hqpU2YzDhXYOHKZ0GNL9FOhrOQYXgz/vTIgVxg== Date: Thu, 9 Mar 2023 12:23:24 +0100 From: Miquel Raynal To: Srinivas Kandagatla Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer Message-ID: <20230309122324.4b012a58@xps-13> In-Reply-To: <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_032334_159767_A12F62B2 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3Jpbml2YXMsCgpzcmluaXZhcy5rYW5kYWdhdGxhQGxpbmFyby5vcmcgd3JvdGUgb24gVGh1 LCA5IE1hciAyMDIzIDEwOjUzOjA3ICswMDAwOgoKPiBPbiAwOS8wMy8yMDIzIDEwOjMyLCBNaXF1 ZWwgUmF5bmFsIHdyb3RlOgo+ID4gSGkgU3Jpbml2YXMsCj4gPiAKPiA+IHNyaW5pdmFzLmthbmRh Z2F0bGFAbGluYXJvLm9yZyB3cm90ZSBvbiBUaHUsIDkgTWFyIDIwMjMgMTA6MTI6MjQgKzAwMDA6 Cj4gPiAgIAo+ID4+IE9uIDIyLzAyLzIwMjMgMTc6MjIsIFJhZmHFgiBNacWCZWNraSB3cm90ZTog IAo+ID4+PiBAQCAtMTc5MSwxMSArMTc5MiwxNSBAQCBzc2l6ZV90IG52bWVtX2RldmljZV9jZWxs X3JlYWQoc3RydWN0IG52bWVtX2RldmljZSAqbnZtZW0sCj4gPj4+ICAgIAlpZiAoIW52bWVtKQo+ ID4+PiAgICAJCXJldHVybiAtRUlOVkFMOyAgCj4gPj4+ICAgID4gKwkvKiBDZWxscyB3aXRoIHJl YWRfcG9zdF9wcm9jZXNzIGhvb2sgbWF5IHJlYWxsb2MgYnVmZmVyIHdlIGNhbid0IGFsbG93IGhl cmUgKi8gIAo+ID4+PiArCWlmIChpbmZvLT5yZWFkX3Bvc3RfcHJvY2VzcykKPiA+Pj4gKwkJcmV0 dXJuIC1FSU5WQUw7ICAKPiA+PiBUaGlzIHNob3VsZCBwcm9iYWJseSBnbyBpbiAxLzQgcGF0Y2gu IE90aGVyIHRoYW4gdGhhdCBzZXJpZXMgbG9va3MgZ29vZCB0byBtZS4gIAo+ID4gCj4gPiBGWUkg cGF0Y2ggMS80IGlzIGFsc28gY2FycmllZCBieSB0aGUgbnZtZW0tbGF5b3V0cyBzZXJpZXMsIHNv IGl0J3MKPiA+IHByb2JhYmx5IGJlc3QgdG8ga2VlcCB0aGVzZSAyIHBhdGNoZXMgc2VwYXJhdGVk IHRvIHNpbXBsaWZ5IHRoZSBtZXJnaW5nLiAgCj4gdGhhdCBpcyBpbnRlcm1lZGlhdGUgdGhpbmcs IGJ1dCBJZGVhbGx5IHRoaXMgY2hhbmdlIGJlbG9uZ3MgdG8gMS80IHBhdGNoLCBzbyBvbmNlIEkg YXBwbHkgdGhlc2UgcGF0Y2hlcyB0aGVuIHdlIGNhbiBhbHdheXMgcmViYXNlIGxheW91dCBzZXJp ZXMgb24gdG9wIG9mIG52bWVtLW5leHQKCldlbGwsIEkgc3RpbGwgZG9uJ3Qgc2VlIHRoZSBuZWVk IGZvciB0aGlzIHBhdGNoIGJlY2F1c2Ugd2UgaGF2ZSBubyB1c2UKZm9yIGl0ICphZnRlciogdGhl IGludHJvZHVjdGlvbiBvZiBsYXlvdXRzLiBZZXMgaW4gc29tZSBjYXNlcyBjaGFuZ2luZwp0aGUg c2l6ZSBvZiBhIGNlbGwgbWlnaHQgbWF5YmUgYmUgbmVlZGVkLCBidXQgcmlnaHQgbm93IHRoZSB1 c2UgY2FzZSBpcwp0byBwcm92aWRlIGEgTUFDIGFkZHJlc3MsIHdlIGtub3cgYmVmb3JlaGFuZCB0 aGUgc2l6ZSBvZiB0aGUgY2VsbCwgc28KdGhlcmUgaXMgbm8gbmVlZCwgY3VycmVudGx5LCBmb3Ig dGhpcyBoYWNrLgoKV2hhdGV2ZXIuIElmIHlvdSB3YW50IGl0LCBqdXN0IG1lcmdlIGl0LiBCdXQg KnBsZWFzZSosIEkgd291bGQgbGlrZQp0byBzZWUgdGhlc2UgbGF5b3V0cyBpbiwgc28gd2hhdCdz IHRoZSBwbGFuPwoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FB4C61DA4 for ; Thu, 9 Mar 2023 11:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbjCIL0E (ORCPT ); Thu, 9 Mar 2023 06:26:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231931AbjCILZm (ORCPT ); Thu, 9 Mar 2023 06:25:42 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDBDB5CC03; Thu, 9 Mar 2023 03:23:28 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4641D10000E; Thu, 9 Mar 2023 11:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678361007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nFB/XzUgcCAZanhIP6AKbNu6CZh3ZVa2Xw1P9FE3XKU=; b=i74aRkvD0oj/7IcNRKWPBzJhbEnD9BxREtMgeu2+Ic1ouSWkVmpx89UD2aEE+Ch2cUWsUV yShn53mLBgk/zBu6/96vEQd51E/9hV4ukYDp3M99J8B+LUb1vtVxlyCnuW13tJoG+R39SG Vl9S7zfHu4yoGfCur9XqUEzWYv42Mm2/CM+N6bWu+J0Wi4e8M9JxC5lO6vI3ex2fYf4tCk YNieGatb2k1UY5KBFLvhwSd9JLfUExt27K8zwVG2IOeDFnWL622H9SQpR4OUO6XXSSwyho omft0YbNKbPbqZbVxFE3WBn7hqpU2YzDhXYOHKZ0GNL9FOhrOQYXgz/vTIgVxg== Date: Thu, 9 Mar 2023 12:23:24 +0100 From: Miquel Raynal To: Srinivas Kandagatla Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer Message-ID: <20230309122324.4b012a58@xps-13> In-Reply-To: <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Srinivas, srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 +0000: > On 09/03/2023 10:32, Miquel Raynal wrote: > > Hi Srinivas, > >=20 > > srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 +0000: > > =20 > >> On 22/02/2023 17:22, Rafa=C5=82 Mi=C5=82ecki wrote: =20 > >>> @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct nvmem_d= evice *nvmem, > >>> if (!nvmem) > >>> return -EINVAL; =20 > >>> > + /* Cells with read_post_process hook may realloc buffer we can= 't allow here */ =20 > >>> + if (info->read_post_process) > >>> + return -EINVAL; =20 > >> This should probably go in 1/4 patch. Other than that series looks goo= d to me. =20 > >=20 > > FYI patch 1/4 is also carried by the nvmem-layouts series, so it's > > probably best to keep these 2 patches separated to simplify the merging= . =20 > that is intermediate thing, but Ideally this change belongs to 1/4 patch,= so once I apply these patches then we can always rebase layout series on t= op of nvmem-next Well, I still don't see the need for this patch because we have no use for it *after* the introduction of layouts. Yes in some cases changing the size of a cell might maybe be needed, but right now the use case is to provide a MAC address, we know beforehand the size of the cell, so there is no need, currently, for this hack. Whatever. If you want it, just merge it. But *please*, I would like to see these layouts in, so what's the plan? Thanks, Miqu=C3=A8l