From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52524C61DA4 for ; Thu, 9 Mar 2023 13:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DomyJg0BNVUc5MouQediFu4TF0dpY1bpnd0mSL3gB9o=; b=MDNx4b2ojf7hfN IXHgMkvcvYd9GbSaE5EsifudKbeSpzbkZmiEHp/mfztQLGvWDZrIp8ZFV7vvXbOTOPlSMkftBAioq N+i+tLHQYxdz+oUkyei+HngskFvtwzGeahGileq9LYqWlS4I3diIYpFa7qApEsJPgFXQGD0PGMIXO N5U+YtkpOdlJghvKns89mg6J3AEaX0eqqWT3wPKdZz6xNKWFbLa7hCZtIWo6Nt1Lyhml7pFYT7qGo FlKxOZsY8phWlmCQdamXGU5lqzfAqzZHTpEJIfdrqIaBt9tbznnEb7yBEQsn04Sc1EoBi/u2ic2aJ 4v9WzsjCrAlp5/2pyaVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paG2s-00A1WF-Em; Thu, 09 Mar 2023 13:10:58 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paG2m-00A1T9-Hu for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 13:10:55 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EC0AAFF803; Thu, 9 Mar 2023 13:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678367441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nAtQ/zm36r/xZZG8gCGP5DOMaREHcbOXCuBhiJyl+SQ=; b=jDAFHsci28br950/rzGOMVaYQ/eA3m7hA4/4KbJxApBCilyu2kVn6RXevK9MO/7Il3RfT8 +Uxx/4YfL4DL8C1OmDXhqJwWAtqOlQKI3eWqmN8gzPTJRjtAyOM4LpF1pYR26gmrSLVbT5 lWUgXpE06Qxob4VW5btgzmTaQ91qryMqfG2SJFOZ8LmkBwehb7qwaUXMRRmiK/nxdMmtTT zkZh8d5dfq/0n1EA36+gQUOTIJu7gyDccAkoqwLrRKJHeCVsdLjCfIcIzux0/ceVxIvHQi viANWa/IQ5TMqURjSegBZXL3gQsjKyizPHEiIX+XiGwA1oGMxa2jH0XhCUcmDw== Date: Thu, 9 Mar 2023 14:10:38 +0100 From: Miquel Raynal To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Srinivas Kandagatla , =?UTF-8?B?UmFm?= =?UTF-8?B?YcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer Message-ID: <20230309141038.4399af1f@xps-13> In-Reply-To: References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_051052_952558_6BBC1871 X-CRM114-Status: GOOD ( 34.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpyYWZhbEBtaWxlY2tpLnBsIHdyb3RlIG9uIFRodSwgMDkgTWFyIDIwMjMgMTI6NTI6 MzcgKzAxMDA6Cgo+IE9uIDIwMjMtMDMtMDkgMTI6NDQsIFNyaW5pdmFzIEthbmRhZ2F0bGEgd3Jv dGU6Cj4gPiBPbiAwOS8wMy8yMDIzIDExOjIzLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4g SGkgU3Jpbml2YXMsICAKPiA+PiA+PiBzcmluaXZhcy5rYW5kYWdhdGxhQGxpbmFyby5vcmcgd3Jv dGUgb24gVGh1LCA5IE1hciAyMDIzIDEwOjUzOjA3ID4+ICswMDAwOiAgCj4gPj4gPj4+IE9uIDA5 LzAzLzIwMjMgMTA6MzIsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAKPiA+Pj4+IEhpIFNyaW5pdmFz LCAgCj4gPj4+PiA+Pj4+IHNyaW5pdmFzLmthbmRhZ2F0bGFAbGluYXJvLm9yZyB3cm90ZSBvbiBU aHUsIDkgTWFyIDIwMjMgMTA6MTI6MjQgPj4+PiArMDAwMDogIAo+ID4+Pj4gPj4+Pj4gT24gMjIv MDIvMjAyMyAxNzoyMiwgUmFmYcWCIE1pxYJlY2tpIHdyb3RlOiAgCj4gPj4+Pj4+IEBAIC0xNzkx LDExICsxNzkyLDE1IEBAIHNzaXplX3QgbnZtZW1fZGV2aWNlX2NlbGxfcmVhZChzdHJ1Y3QgPj4+ Pj4+IG52bWVtX2RldmljZSAqbnZtZW0sCj4gPj4+Pj4+ICAgICAJaWYgKCFudm1lbSkKPiA+Pj4+ Pj4gICAgIAkJcmV0dXJuIC1FSU5WQUw7ICAKPiA+Pj4+Pj4gICAgID4gKwkvKiBDZWxscyB3aXRo IHJlYWRfcG9zdF9wcm9jZXNzIGhvb2sgbWF5IHJlYWxsb2MgYnVmZmVyIHdlID4+Pj4+PiBjYW4n dCBhbGxvdyBoZXJlICovICAKPiA+Pj4+Pj4gKwlpZiAoaW5mby0+cmVhZF9wb3N0X3Byb2Nlc3Mp Cj4gPj4+Pj4+ICsJCXJldHVybiAtRUlOVkFMOyAgCj4gPj4+Pj4gVGhpcyBzaG91bGQgcHJvYmFi bHkgZ28gaW4gMS80IHBhdGNoLiBPdGhlciB0aGFuIHRoYXQgc2VyaWVzIGxvb2tzID4+Pj4+IGdv b2QgdG8gbWUuICAKPiA+Pj4+ID4+Pj4gRllJIHBhdGNoIDEvNCBpcyBhbHNvIGNhcnJpZWQgYnkg dGhlIG52bWVtLWxheW91dHMgc2VyaWVzLCBzbyBpdCdzICAKPiA+Pj4+IHByb2JhYmx5IGJlc3Qg dG8ga2VlcCB0aGVzZSAyIHBhdGNoZXMgc2VwYXJhdGVkIHRvIHNpbXBsaWZ5IHRoZSA+Pj4+IG1l cmdpbmcuICAKPiA+Pj4gdGhhdCBpcyBpbnRlcm1lZGlhdGUgdGhpbmcsIGJ1dCBJZGVhbGx5IHRo aXMgY2hhbmdlIGJlbG9uZ3MgdG8gMS80ID4+PiBwYXRjaCwgc28gb25jZSBJIGFwcGx5IHRoZXNl IHBhdGNoZXMgdGhlbiB3ZSBjYW4gYWx3YXlzIHJlYmFzZSBsYXlvdXQgPj4+IHNlcmllcyBvbiB0 b3Agb2YgbnZtZW0tbmV4dCAgCj4gPj4gPj4gV2VsbCwgSSBzdGlsbCBkb24ndCBzZWUgdGhlIG5l ZWQgZm9yIHRoaXMgcGF0Y2ggYmVjYXVzZSB3ZSBoYXZlIG5vIHVzZSAgCj4gPj4gZm9yIGl0ICph ZnRlciogdGhlIGludHJvZHVjdGlvbiBvZiBsYXlvdXRzLiBZZXMgaW4gc29tZSBjYXNlcyBjaGFu Z2luZwo+ID4+IHRoZSBzaXplIG9mIGEgY2VsbCBtaWdodCBtYXliZSBiZSBuZWVkZWQsIGJ1dCBy aWdodCBub3cgdGhlIHVzZSBjYXNlID4+IGlzCj4gPj4gdG8gcHJvdmlkZSBhIE1BQyBhZGRyZXNz LCB3ZSBrbm93IGJlZm9yZWhhbmQgdGhlIHNpemUgb2YgdGhlIGNlbGwsIHNvCj4gPj4gdGhlcmUg aXMgbm8gbmVlZCwgY3VycmVudGx5LCBmb3IgdGhpcyBoYWNrLiAgCj4gPj4gPiBBbSBjb25mdXNl ZCwgc2hvdWxkIEkgaWdub3JlIHRoaXMgc2VyaWVzID8gIAoKSSB0aGluayB0aGlzIHNlcmllcyBt YWtlcyBzZW5zZSBhbmQgYWRkcmVzc2VzIGEgbmVlZC4gQnV0IHRoaXMgaXNzdWUKY2FuIGFsc28g YmUgc29sdmVkIHdpdGggdGhlIGxheW91dHMuIFJhZmHFgiBkb2VzIG5vdCB3YW50IChJIHN0aWxs CmRvbid0IGdldCB0aGUgcmVhc29uKSB0byB1c2UgdGhhdCBzb2x1dGlvbi4gV2hhdGV2ZXIuIEJ1 dCBpZiB5b3UgYXBwbHkKdGhpcyBzZXJpZXMsIGl0IHJlcXVpcmVzIHRvIG1vZGlmeSB0aGUgbGF5 b3V0cyBzZXJpZXMsIHRodXMgcG9zdHBvbmluZwppdCBldmVuIG1vcmUuIEkgd291bGQgcHJlZmVy IHRvIG1lcmdlIHRoYXQgYmlnIHNlcmllcyBmaXJzdCBhbmQgdGhlbgptZXJnZSBhbiB1cGRhdGUg b2YgdGhpcyBwYXRjaCAod2hpY2ggY2hhbmdlcyBpbiB0aGUgdHdvIGxheW91dCBkcml2ZXJzCnRo ZSBjZWxsIHNpemUgYXJndW1lbnQgdHlwZSkuCgo+IEknbSBjb25mdXNlZCBubyBsZXNzLgo+IAo+ IEkgdGhpbmsgd2UgaGF2ZSAzIGRpZmZlcmVudCBvcGluaW9ucyBhbmQgbm8gYWdyZWVtZW50IG9u IGhvdyB0byBwcm9jZWVkLgo+IAo+IAo+IFJhZmHFgiAobWUpOgo+IE5WTUVNIGNlbGxzIHNob3Vs ZCBiZSByZWdpc3RlcmVkIGFzIHRoZXkgYXJlIGluIHRoZSByYXcgZm9ybWF0LiBObyBzaXplCj4g YWRqdXN0bWVudHMgc2hvdWxkIGhhcHBlbiB3aGlsZSByZWdpc3RlcmluZyB0aGVtLiBJZiBOVk1F TSBjZWxsIHJlcXVpcmVzCj4gc29tZSByZWFkIHBvc3QtcHJvY2Vzc2luZyB0aGVuIGl0cyBzaXpl IHNob3VsZCBiZSBhZGp1c3RlZCAqd2hpbGUqCj4gcmVhZGluZy4KClRoaXMgaW1wbGVtZW50YXRp b24gb25seSB3b3JrcyBpZiB5b3UgcmVkdWNlIHRoZSBzaXplIG9mIHRoZSBjZWxsLgoKV2hpbGUg d3JpdGluZyB0aGlzLCBJIGFtIHJlYWxpemluZyB0aGF0IHdlIHdvdWxkIGFjdHVhbGx5IGV4cGVj dAphIGNoZWNrIG9uIHRoZSBudm1lbSBzaWRlIGlmIHRoZSBzaXplIHdhcyBlbmxhcmdlZCBiZWNh dXNlIHRoaXMgd291bGQKYmUgYSBidWcuCgo+IE1pY2hhZWw6Cj4gLnJlYWRfcG9zdF9wcm9jZXNz KCkgc2hvdWxkIGJlIHJlYWxsb2MgdGhlIGJ1ZmZlcgoKVGhpcyB3b3VsZCBiZSBtb3JlIHJvYnVz dC4gQnV0IGlmIHdlIHN0YXJ0IHdpdGggMSwgd2UgY2FuIGltcHJvdmUgaXQKbGF0ZXIsIEkgZG9u J3QgbWluZCBhcyBsb25nIGFzIGFuIGVycm9yIGlzIHJldHVybmVkIGluIGNhc2Ugb2YgbWlzdXNl LgoKPiBNaXF1ZWw6Cj4gV2hpbGUgcmVnaXN0ZXJpbmcgTlZNRU0gY2VsbCBpdHMgc2l6ZSBzaG91 bGQgYmUgYWxyZWFkeSBhZGp1c3RlZCB0bwo+IG1hdGNoIHdoYXQgLnJlYWRfcG9zdF9wcm9jZXNz KCkgaXMgYWJvdXQgdG8gcmV0dXJuLgoKU291bmRzIGxpa2UgdGhlIHNpbXBsZXN0IHNvbHV0aW9u IHRvIG1lIGFuZCBjb3ZlcnMgYWxsIHRoZSB1c2VzIHdlCmhhdmUgdG8gZGF5LCBidXQgaG9uZXN0 bHksIEkgd29uJ3QgZmlnaHQgZm9yIGl0LgoKPiBJJ20gcmVhbGx5IHNvcnJ5IGlmIEkgZ290IGFu eW9uZSdzIHZpZXcgd3JvbmcuCgpMR1RNLgoKPiA+IFdoYXRldmVyLiBJZiB5b3Ugd2FudCBpdCwg anVzdCBtZXJnZSBpdC4gQnV0ICpwbGVhc2UqLCBJIHdvdWxkIGxpa2UgIAo+Cj4gOi0pCj4KPiA+ IHRvIHNlZSB0aGVzZSBsYXlvdXRzIGluLCBzbyB3aGF0J3MgdGhlIHBsYW4/ICAKPgo+IEFtIG9u IGl0LCB5b3Ugc2VudCB2MyBqdXN0IDI0aHJzIGFnbyA6LSkKClllcywgc29ycnkgZm9yIGJlaW5n IHB1c2h5LiBJIGp1c3Qgd2FudGVkIHRvIGhpZ2hsaWdodCB0aGF0IHRoZSB0d28Kc2VyaWVzIGNv bmZsaWN0IHRvZ2V0aGVyLCBidXQgbXkgYW5zd2VyIHdhcyBjbHVtc3kuIFRha2UgdGhlIHRpbWUg eW91Cm5lZWQsIHRoYXQncyBob3cgaXQncyBzdXBwb3NlZCB0byB3b3JrIGFueXdheS4KClRoYW5r cywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A42C61DA4 for ; Thu, 9 Mar 2023 13:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbjCINKt (ORCPT ); Thu, 9 Mar 2023 08:10:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbjCINKs (ORCPT ); Thu, 9 Mar 2023 08:10:48 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54401D5153; Thu, 9 Mar 2023 05:10:43 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EC0AAFF803; Thu, 9 Mar 2023 13:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678367441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nAtQ/zm36r/xZZG8gCGP5DOMaREHcbOXCuBhiJyl+SQ=; b=jDAFHsci28br950/rzGOMVaYQ/eA3m7hA4/4KbJxApBCilyu2kVn6RXevK9MO/7Il3RfT8 +Uxx/4YfL4DL8C1OmDXhqJwWAtqOlQKI3eWqmN8gzPTJRjtAyOM4LpF1pYR26gmrSLVbT5 lWUgXpE06Qxob4VW5btgzmTaQ91qryMqfG2SJFOZ8LmkBwehb7qwaUXMRRmiK/nxdMmtTT zkZh8d5dfq/0n1EA36+gQUOTIJu7gyDccAkoqwLrRKJHeCVsdLjCfIcIzux0/ceVxIvHQi viANWa/IQ5TMqURjSegBZXL3gQsjKyizPHEiIX+XiGwA1oGMxa2jH0XhCUcmDw== Date: Thu, 9 Mar 2023 14:10:38 +0100 From: Miquel Raynal To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Srinivas Kandagatla , =?UTF-8?B?UmFm?= =?UTF-8?B?YcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer Message-ID: <20230309141038.4399af1f@xps-13> In-Reply-To: References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, rafal@milecki.pl wrote on Thu, 09 Mar 2023 12:52:37 +0100: > On 2023-03-09 12:44, Srinivas Kandagatla wrote: > > On 09/03/2023 11:23, Miquel Raynal wrote: =20 > >> Hi Srinivas, =20 > >> >> srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 >>= +0000: =20 > >> >>> On 09/03/2023 10:32, Miquel Raynal wrote: =20 > >>>> Hi Srinivas, =20 > >>>> >>>> srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:12:2= 4 >>>> +0000: =20 > >>>> >>>>> On 22/02/2023 17:22, Rafa=C5=82 Mi=C5=82ecki wrote: =20 > >>>>>> @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct >>>>= >> nvmem_device *nvmem, > >>>>>> if (!nvmem) > >>>>>> return -EINVAL; =20 > >>>>>> > + /* Cells with read_post_process hook may realloc buffer we= >>>>>> can't allow here */ =20 > >>>>>> + if (info->read_post_process) > >>>>>> + return -EINVAL; =20 > >>>>> This should probably go in 1/4 patch. Other than that series looks = >>>>> good to me. =20 > >>>> >>>> FYI patch 1/4 is also carried by the nvmem-layouts series, so i= t's =20 > >>>> probably best to keep these 2 patches separated to simplify the >>>>= merging. =20 > >>> that is intermediate thing, but Ideally this change belongs to 1/4 >>= > patch, so once I apply these patches then we can always rebase layout >>>= series on top of nvmem-next =20 > >> >> Well, I still don't see the need for this patch because we have no = use =20 > >> for it *after* the introduction of layouts. Yes in some cases changing > >> the size of a cell might maybe be needed, but right now the use case >= > is > >> to provide a MAC address, we know beforehand the size of the cell, so > >> there is no need, currently, for this hack. =20 > >> > Am confused, should I ignore this series ? =20 I think this series makes sense and addresses a need. But this issue can also be solved with the layouts. Rafa=C5=82 does not want (I still don't get the reason) to use that solution. Whatever. But if you apply this series, it requires to modify the layouts series, thus postponing it even more. I would prefer to merge that big series first and then merge an update of this patch (which changes in the two layout drivers the cell size argument type). > I'm confused no less. >=20 > I think we have 3 different opinions and no agreement on how to proceed. >=20 >=20 > Rafa=C5=82 (me): > NVMEM cells should be registered as they are in the raw format. No size > adjustments should happen while registering them. If NVMEM cell requires > some read post-processing then its size should be adjusted *while* > reading. This implementation only works if you reduce the size of the cell. While writing this, I am realizing that we would actually expect a check on the nvmem side if the size was enlarged because this would be a bug. > Michael: > .read_post_process() should be realloc the buffer This would be more robust. But if we start with 1, we can improve it later, I don't mind as long as an error is returned in case of misuse. > Miquel: > While registering NVMEM cell its size should be already adjusted to > match what .read_post_process() is about to return. Sounds like the simplest solution to me and covers all the uses we have to day, but honestly, I won't fight for it. > I'm really sorry if I got anyone's view wrong. LGTM. > > Whatever. If you want it, just merge it. But *please*, I would like =20 > > :-) > > > to see these layouts in, so what's the plan? =20 > > Am on it, you sent v3 just 24hrs ago :-) Yes, sorry for being pushy. I just wanted to highlight that the two series conflict together, but my answer was clumsy. Take the time you need, that's how it's supposed to work anyway. Thanks, Miqu=C3=A8l