All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [lunn:v6.2.0-net-next-phy-leds 20/28] drivers/net/phy/phy_device.c:3085:21: error: 'struct led_classdev' has no member named 'hw_control_configure'
Date: Thu, 9 Mar 2023 22:08:25 +0800	[thread overview]
Message-ID: <202303092143.Oi6anuSy-lkp@intel.com> (raw)

tree:   https://github.com/lunn/linux.git v6.2.0-net-next-phy-leds
head:   5e80c5c7b6177d29b99f274eeffbfd2faf6a8985
commit: 0080d5983f89364a7cc968f96fc449befedcbfb4 [20/28] net: phy: phy_device: Call into the PHY driver to set LED offload
config: arc-randconfig-r043-20230308 (https://download.01.org/0day-ci/archive/20230309/202303092143.Oi6anuSy-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/lunn/linux/commit/0080d5983f89364a7cc968f96fc449befedcbfb4
        git remote add lunn https://github.com/lunn/linux.git
        git fetch --no-tags lunn v6.2.0-net-next-phy-leds
        git checkout 0080d5983f89364a7cc968f96fc449befedcbfb4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/net/phy/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303092143.Oi6anuSy-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/phy/phy_device.c: In function 'of_phy_led':
>> drivers/net/phy/phy_device.c:3085:21: error: 'struct led_classdev' has no member named 'hw_control_configure'
    3085 |                 cdev->hw_control_configure = phy_led_hw_control_configure;
         |                     ^~


vim +3085 drivers/net/phy/phy_device.c

  3056	
  3057	static int of_phy_led(struct phy_device *phydev,
  3058			      struct device_node *led)
  3059	{
  3060		struct device *dev = &phydev->mdio.dev;
  3061		struct led_init_data init_data = {};
  3062		struct led_classdev *cdev;
  3063		struct phy_led *phyled;
  3064		int err;
  3065	
  3066		phyled = devm_kzalloc(dev, sizeof(*phyled), GFP_KERNEL);
  3067		if (!phyled)
  3068			return -ENOMEM;
  3069	
  3070		phyled->phydev = phydev;
  3071		cdev = &phyled->led_cdev;
  3072		INIT_LIST_HEAD(&phyled->led_list);
  3073	
  3074		err = of_property_read_u32(led, "reg", &phyled->index);
  3075		if (err)
  3076			return err;
  3077	
  3078		if (phydev->drv->led_brightness_set)
  3079			cdev->brightness_set_blocking = phy_led_set_brightness;
  3080		if (phydev->drv->led_blink_set)
  3081			cdev->blink_set = phy_led_blink_set;
  3082		if (phydev->drv->led_hw_is_supported &&
  3083		    phydev->drv->led_hw_control_set &&
  3084		    phydev->drv->led_hw_control_get)
> 3085			cdev->hw_control_configure = phy_led_hw_control_configure;
  3086		cdev->max_brightness = 1;
  3087		init_data.devicename = dev_name(&phydev->mdio.dev);
  3088		init_data.fwnode = of_fwnode_handle(led);
  3089	
  3090		err = devm_led_classdev_register_ext(dev, cdev, &init_data);
  3091		if (err)
  3092			return err;
  3093	
  3094		list_add(&phyled->led_list, &phydev->led_list);
  3095	
  3096		return 0;
  3097	}
  3098	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-03-09 14:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303092143.Oi6anuSy-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrew@lunn.ch \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.