From: Jakub Kicinski <kuba@kernel.org>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Rasesh Mody <rmody@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Michael Chan <mchan@broadcom.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH net-next] bnx2: remove deadcode in bnx2_init_cpus()
Date: Thu, 9 Mar 2023 23:41:04 -0800 [thread overview]
Message-ID: <20230309234104.79286da7@kernel.org> (raw)
In-Reply-To: <9b367837-4bf0-1802-e753-6eca37e105b9@gmail.com>
On Fri, 10 Mar 2023 10:33:46 +0300 Maxim Korotkov wrote:
> Path with error handling was deleted in 57579f7629a3 ("bnx2: Use
> request_firmware()"). This patch is needed to improving readability.
> Now checking the value of the return value is misleading when reading
> the code.
> Do I need to add this argument to the patch description?
Yes please.
> I also forgot to add mark Reviewed-by: Leon Romanovsky
> <leonro@nvidia.com> from the previous iteration
So this is not the first revision? Please add Leon's tag and an
appropriate vN. e.g. [PATCH net-next v2].
In general we don't encourage cleanup of this sort because the number
of int functions which always return 0 is rather large in the kernel,
but if you already got an ack from Leon we'll consider it, so please
adjust and repost.
prev parent reply other threads:[~2023-03-10 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 17:42 [PATCH net-next] bnx2: remove deadcode in bnx2_init_cpus() Maxim Korotkov
2023-03-10 6:57 ` Jakub Kicinski
2023-03-10 7:33 ` Maxim Korotkov
2023-03-10 7:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309234104.79286da7@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmody@marvell.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.