All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH vhost v2 00/12] virtio core prepares for AF_XDP
Date: Fri, 10 Mar 2023 04:05:57 -0500	[thread overview]
Message-ID: <20230310040546-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230308064443.50639-1-xuanzhuo@linux.alibaba.com>

On Wed, Mar 08, 2023 at 02:44:31PM +0800, Xuan Zhuo wrote:
> XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero
> copy feature of xsk (XDP socket) needs to be supported by the driver. The
> performance of zero copy is very good.
> 
> ENV: Qemu with vhost.
> 
>                    vhost cpu | Guest APP CPU |Guest Softirq CPU | PPS
> -----------------------------|---------------|------------------|------------
> xmit by sockperf:     90%    |   100%        |                  |  318967
> xmit by xsk:          100%   |   30%         |   33%            | 1192064
> recv by sockperf:     100%   |   68%         |   100%           |  692288
> recv by xsk:          100%   |   33%         |   43%            |  771670
> 
> Before achieving the function of Virtio-Net, we also have to let virtio core
> support these features:
> 
> 1. virtio core support premapped
> 2. virtio core support reset per-queue
> 3. introduce DMA APIs to virtio core
> 
> Please review.


Jason can I get some acks on this?

> Thanks.
> 
> v2:
>  1. based on sgs[0]->dma_address to judgment is premapped
>  2. based on extra.addr to judgment to do unmap for no-indirect desc
>  3. based on indir_desc to judgment to do unmap for indirect desc
>  4. rename virtqueue_get_dma_dev to virtqueue_dma_dev
> 
> v1:
>  1. expose dma device. NO introduce the api for dma and sync
>  2. split some commit for review.
> 
> Xuan Zhuo (12):
>   virtio_ring: split: separate dma codes
>   virtio_ring: packed: separate dma codes
>   virtio_ring: packed-indirect: separate dma codes
>   virtio_ring: split: support premapped
>   virtio_ring: packed: support premapped
>   virtio_ring: split-indirect: support premapped
>   virtio_ring: packed-indirect: support premapped
>   virtio_ring: update document for virtqueue_add_*
>   virtio_ring: introduce virtqueue_dma_dev()
>   virtio_ring: correct the expression of the description of
>     virtqueue_resize()
>   virtio_ring: separate the logic of reset/enable from virtqueue_resize
>   virtio_ring: introduce virtqueue_reset()
> 
>  drivers/virtio/virtio.c      |   6 +
>  drivers/virtio/virtio_ring.c | 354 +++++++++++++++++++++++++----------
>  include/linux/virtio.h       |   4 +
>  3 files changed, 260 insertions(+), 104 deletions(-)
> 
> --
> 2.32.0.3.g01195cf9f

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2023-03-10  9:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08  6:44 [PATCH vhost v2 00/12] virtio core prepares for AF_XDP Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 01/12] virtio_ring: split: separate dma codes Xuan Zhuo
2023-03-14  7:05   ` Jason Wang
2023-03-14  9:11     ` Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 02/12] virtio_ring: packed: " Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 03/12] virtio_ring: packed-indirect: " Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 04/12] virtio_ring: split: support premapped Xuan Zhuo
2023-03-14  7:32   ` Jason Wang
2023-03-14  7:34     ` Jason Wang
2023-03-08  6:44 ` [PATCH vhost v2 05/12] virtio_ring: packed: " Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 06/12] virtio_ring: split-indirect: " Xuan Zhuo
2023-03-14  7:57   ` Jason Wang
2023-03-14  9:13     ` Xuan Zhuo
2023-03-15  4:47       ` Jason Wang
2023-03-15  6:01         ` Xuan Zhuo
2023-03-16  2:49           ` Jason Wang
2023-03-16  2:53             ` Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 07/12] virtio_ring: packed-indirect: " Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 08/12] virtio_ring: update document for virtqueue_add_* Xuan Zhuo
2023-03-14  7:58   ` Jason Wang
2023-03-14  9:18     ` Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 09/12] virtio_ring: introduce virtqueue_dma_dev() Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 10/12] virtio_ring: correct the expression of the description of virtqueue_resize() Xuan Zhuo
2023-03-08  6:44 ` [PATCH vhost v2 11/12] virtio_ring: separate the logic of reset/enable from virtqueue_resize Xuan Zhuo
2023-03-15  2:56   ` Jason Wang
2023-03-08  6:44 ` [PATCH vhost v2 12/12] virtio_ring: introduce virtqueue_reset() Xuan Zhuo
2023-03-15  3:00   ` Jason Wang
2023-03-10  9:05 ` Michael S. Tsirkin [this message]
2023-03-10  9:33   ` [PATCH vhost v2 00/12] virtio core prepares for AF_XDP Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310040546-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.