Re: [cocci] HELP: multiple inserts at one position

[Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>]

On Thu, 9 Mar 2023 09:47:17 +0100 (CET)
Julia Lawall <julia.lawall@inria.fr> wrote:

> On Thu, 9 Mar 2023, Julia Lawall wrote:
> > On Thu, 9 Mar 2023, Bernhard Reutner-Fischer wrote:
[]
> Another issue is that your semantic patch could be more efficient.  You
> have the declaration
> 
> type mpz_t;
> 
> I think you meant:
> 
> typedef mpz_t;
> 
> Then the only goal of the pattern
> 
> mpz_t i;
> ...
> 
> seems to be to ensure the type of i.  This can be done in the metavariable
> declaration:
> 
> local idexpression mpz_t i
> 
> and then in the second rule, it would be:
> 
> local idexpression mpz_t mpz_0_find.i;
> 
> In this way, you will not be matching from the top of the function, but
> rather only from the relevant call to the return.

mhm. But if there is no return statement whatsoever in that scope?

Consider:
int myround (double dbl)
{
  int ret = 0;
  // mpfr_t outer; mpfr_init (outer);
  if (global_var)
    {
      unsigned long ul;
      mpfr_t i;
      mpfr_init (i);
      mpfr_frac (i, dbl, MPFR_RNDZ);
      if (mpfr_cmp_si (i, 0) != 0)
        {
	  ret = 42;
	  moan ("round");
	}
      /* mpfr_clear (i); missing here */
    }
  // mpfr_clear (outer) insertion works, there is a return stmt.
  // probably breaks in a void function like in the scope above..
  // There is no 'i' to clear _here_, of course!
  return ret;
}
EOF

If i'd understand a local idexpression 'i' to have a scope, i would have
hoped to somehow get at the position of i at end of scope?
But i think i need to match either a return or end-of-block, so i can 
insert the mpfr_clear properly in either case. Somehow.

Ideas?
many thanks,