From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FC65847E for ; Fri, 10 Mar 2023 13:53:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBA1AC433D2; Fri, 10 Mar 2023 13:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678456403; bh=efsVJJO2rQXwFiX784SBqHx8wtk/GX6rikqdYMN8mVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PSuS45ofySZ2CL1Fx46F+qn8TmoxzlhvDQ0b0zXih/zz/NhpeAXuslb3oR0WuJU4T bo2s1SvH6odOUnK4GDZAeL9FxGQtRI2zrgLgcDzHGHX+Z7IXfZ3OXGly7kd2FoSO/s 6MRf6+0p+bcUtqBz3eWAnMGg0oE22iUkeerC2518= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hangyu Hua , Florian Westphal , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 4.14 168/193] netfilter: ctnetlink: fix possible refcount leak in ctnetlink_create_conntrack() Date: Fri, 10 Mar 2023 14:39:10 +0100 Message-Id: <20230310133716.728064535@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133710.926811681@linuxfoundation.org> References: <20230310133710.926811681@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Hangyu Hua [ Upstream commit ac4893980bbe79ce383daf9a0885666a30fe4c83 ] nf_ct_put() needs to be called to put the refcount got by nf_conntrack_find_get() to avoid refcount leak when nf_conntrack_hash_check_insert() fails. Fixes: 7d367e06688d ("netfilter: ctnetlink: fix soft lockup when netlink adds new entries (v2)") Signed-off-by: Hangyu Hua Acked-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_netlink.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index b084659bd34bc..733e61fc50433 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -1906,12 +1906,15 @@ ctnetlink_create_conntrack(struct net *net, err = nf_conntrack_hash_check_insert(ct); if (err < 0) - goto err2; + goto err3; rcu_read_unlock(); return ct; +err3: + if (ct->master) + nf_ct_put(ct->master); err2: rcu_read_unlock(); err1: -- 2.39.2