From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF5D847E for ; Fri, 10 Mar 2023 13:54:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE2DDC433EF; Fri, 10 Mar 2023 13:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678456473; bh=QnUHI5LBCcAy/kdv7Y3sD6nd8AzqimP2Of9ufRjUfak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QFEpCgp8XTzfDPE7J6a4DTnOa8Bi5xtUgkR68sUje2mNjPvBCW/C7WRrMZS0PMpy/ xl5u+CmoIYXz8GtmCey0hYxqeAG88CJBHQWKY8Gq+lenBj+yQC8oSsTpRM6rGiK0OF Xl6op8apDSu4saQUJX74/ZnpC31sU0ULYPAarfMs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miaoqian Lin , Ingo Molnar , Josh Poimboeuf , Peter Zijlstra , Sasha Levin Subject: [PATCH 6.2 007/211] objtool: Fix memory leak in create_static_call_sections() Date: Fri, 10 Mar 2023 14:36:27 +0100 Message-Id: <20230310133718.944315713@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133718.689332661@linuxfoundation.org> References: <20230310133718.689332661@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Miaoqian Lin [ Upstream commit 3da73f102309fe29150e5c35acd20dd82063ff67 ] strdup() allocates memory for key_name. We need to release the memory in the following error paths. Add free() to avoid memory leak. Fixes: 1e7e47883830 ("x86/static_call: Add inline static call implementation for x86-64") Signed-off-by: Miaoqian Lin Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/20221205080642.558583-1-linmq006@gmail.com Cc: Josh Poimboeuf Cc: Peter Zijlstra Signed-off-by: Sasha Levin --- tools/objtool/check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index b1a5f658673f0..ea1e7cdeb1b34 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -688,6 +688,7 @@ static int create_static_call_sections(struct objtool_file *file) if (strncmp(key_name, STATIC_CALL_TRAMP_PREFIX_STR, STATIC_CALL_TRAMP_PREFIX_LEN)) { WARN("static_call: trampoline name malformed: %s", key_name); + free(key_name); return -1; } tmp = key_name + STATIC_CALL_TRAMP_PREFIX_LEN - STATIC_CALL_KEY_PREFIX_LEN; @@ -697,6 +698,7 @@ static int create_static_call_sections(struct objtool_file *file) if (!key_sym) { if (!opts.module) { WARN("static_call: can't find static_call_key symbol: %s", tmp); + free(key_name); return -1; } -- 2.39.2