From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22E5A8489 for ; Fri, 10 Mar 2023 14:18:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D26CC4339B; Fri, 10 Mar 2023 14:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678457895; bh=bZ07+7nW2xHIhtdNpmwNyCbmgpnBuBcZdlIR9//8Lgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ATEB2KI7ZfmWX7Px5fyRC68M8NgKgfmpPIE0tOLfhZUAML51ixGGhU61pKvl0NzCR zZ/M3gBoqKwWRZCfagVWhGgTwmhtJ4O6wfISVtCF6zVrnpXGySnACiOZxtbdH65XOB +YqE2C6fz70RDnAGEmmbiHVX8BZNAO8f16PlixOU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Paolo Abeni , Pietro Borrello , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 053/252] rds: rds_rm_zerocopy_callback() correct order for list_add_tail() Date: Fri, 10 Mar 2023 14:37:03 +0100 Message-Id: <20230310133720.413459641@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133718.803482157@linuxfoundation.org> References: <20230310133718.803482157@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Pietro Borrello [ Upstream commit 68762148d1b011d47bc2ceed7321739b5aea1e63 ] rds_rm_zerocopy_callback() uses list_add_tail() with swapped arguments. This links the list head with the new entry, losing the references to the remaining part of the list. Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification") Suggested-by: Paolo Abeni Signed-off-by: Pietro Borrello Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/rds/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/message.c b/net/rds/message.c index 309b54cc62ae3..29f67ad483ea6 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -118,7 +118,7 @@ static void rds_rm_zerocopy_callback(struct rds_sock *rs, ck = &info->zcookies; memset(ck, 0, sizeof(*ck)); WARN_ON(!rds_zcookie_add(info, cookie)); - list_add_tail(&q->zcookie_head, &info->rs_zcookie_next); + list_add_tail(&info->rs_zcookie_next, &q->zcookie_head); spin_unlock_irqrestore(&q->lock, flags); /* caller invokes rds_wake_sk_sleep() */ -- 2.39.2