From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021498481 for ; Fri, 10 Mar 2023 14:03:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 648FEC433D2; Fri, 10 Mar 2023 14:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678457030; bh=QIksLOTKxJRO+YhmoAGEvE/OjudrTc2cq7yyNzLfAiU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c/52nfS5eUcvpRLF/Tgcd32Yel3MKl7EtwnAHH+8OG7cYL53x+/nuQm1nzuVOZDqC CdIPSzijsl9u2SkeQmbR7s5+W9w171F2Y35Y8t4C23eYUeHKtLqXb2PKed4CsicZju ev+1JRmVAL7SkR9knMcmguHPZNMi/M85kKxGTJ04= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.2 179/211] drivers: base: dd: fix memory leak with using debugfs_lookup() Date: Fri, 10 Mar 2023 14:39:19 +0100 Message-Id: <20230310133724.266669525@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133718.689332661@linuxfoundation.org> References: <20230310133718.689332661@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman [ Upstream commit 36c893d3a759ae7c91ee7d4871ebfc7504f08c40 ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: "Rafael J. Wysocki" Link: https://lore.kernel.org/r/20230202141621.2296458-2-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index e9b2f9c25efe4..959fe018d0dd7 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -372,7 +372,7 @@ late_initcall(deferred_probe_initcall); static void __exit deferred_probe_exit(void) { - debugfs_remove_recursive(debugfs_lookup("devices_deferred", NULL)); + debugfs_lookup_and_remove("devices_deferred", NULL); } __exitcall(deferred_probe_exit); -- 2.39.2