All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sumitra Sharma <sumitraartsy@gmail.com>
To: error27@gmail.com
Cc: GR-Linux-NIC-Dev@marvell.com, coiby.xu@gmail.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, manishc@marvell.com,
	netdev@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging: qlge: Remove parenthesis around single condition
Date: Sat, 11 Mar 2023 06:43:18 -0800	[thread overview]
Message-ID: <20230311144318.GC14247@ubuntu> (raw)
In-Reply-To: <e4caf380-bac5-4df3-bb98-529f5703a410@kili.mountain>

Hi Dan,

Your suggestion for correcting the indentation to
"[tab][tab][space][space][space][space](i ==." conflicts with the 
statement "Outside of comments, documentation and except in Kconfig, 
spaces are never used for indentation" written in 
https://elixir.bootlin.com/linux/latest/source/Documentation/process/coding-style.rst

However, If you still recommend to correct the indentation in the manner
"[tab][tab][space][space][space][space](i ==." Should I create a
patch for the same? 

Regards,

Sumitra


  reply	other threads:[~2023-03-11 14:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 14:04 [PATCH] Staging: qlge: Remove parenthesis around single condition Sumitra Sharma
2023-03-11 14:09 ` Dan Carpenter
2023-03-11 14:43   ` Sumitra Sharma [this message]
2023-03-11 14:49     ` Julia Lawall
2023-03-11 14:59     ` Dan Carpenter
2023-03-11 16:42       ` Sumitra Sharma
2023-03-11 17:36       ` Sumitra Sharma
2023-03-11 20:35     ` Fabio M. De Francesco
2023-03-12  7:17       ` Sumitra Sharma
2023-03-12 10:39         ` Fabio M. De Francesco
2023-03-12 17:15           ` Sumitra Sharma
2023-03-12 17:18             ` Julia Lawall
2023-03-12 18:26             ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230311144318.GC14247@ubuntu \
    --to=sumitraartsy@gmail.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=coiby.xu@gmail.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.