From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A19C6FA99 for ; Sun, 12 Mar 2023 09:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbjCLJmY (ORCPT ); Sun, 12 Mar 2023 05:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjCLJmX (ORCPT ); Sun, 12 Mar 2023 05:42:23 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7B074FAA2; Sun, 12 Mar 2023 01:42:18 -0800 (PST) Received: from pendragon.ideasonboard.com (85-76-49-20-nat.elisa-mobile.fi [85.76.49.20]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E5D30814; Sun, 12 Mar 2023 10:42:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1678614135; bh=2ZEVl5rsK5H4zvdfeUpUGY8WalO/tOcjHbf6ZixUYTY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uW96zgPhEyFUlg4cwx9U8aHK5ydpIh7K+GzgaU9BL/vhdw/+zL9BwsVRIklgwy83n znnzlWCsVkBmtHm+lRiw3bEhYFZhWAax0IaEGUVALEnD+uuJxSGkkm7T2ZqG7LsoeF i/JJlR0QZobdvA1oeaCuik3cfnIoI/l0HyEqwgro= Date: Sun, 12 Mar 2023 11:42:16 +0200 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno , Tony Lindgren , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/9] regulator: max20086: Mark OF related data as maybe unused Message-ID: <20230312094216.GC707@pendragon.ideasonboard.com> References: <20230310214553.275450-1-krzysztof.kozlowski@linaro.org> <20230310214553.275450-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230310214553.275450-2-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Krzysztof, Thank you for the patch. On Fri, Mar 10, 2023 at 10:45:46PM +0100, Krzysztof Kozlowski wrote: > The driver can be compile tested with !CONFIG_OF making certain data > unused: > > drivers/regulator/max20086-regulator.c:289:34: error: ‘max20086_dt_ids’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/regulator/max20086-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max20086-regulator.c > index b8bf76c170fe..c98a72f43935 100644 > --- a/drivers/regulator/max20086-regulator.c > +++ b/drivers/regulator/max20086-regulator.c > @@ -286,7 +286,7 @@ static const struct i2c_device_id max20086_i2c_id[] = { > > MODULE_DEVICE_TABLE(i2c, max20086_i2c_id); > > -static const struct of_device_id max20086_dt_ids[] = { > +static const struct of_device_id max20086_dt_ids[] __maybe_unused = { The following change would also work, as the of_match_table field of struct device_driver isn't conditioned by CONFIG_OF: diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max20086-regulator.c index b8bf76c170fe..ad92f84b4abb 100644 --- a/drivers/regulator/max20086-regulator.c +++ b/drivers/regulator/max20086-regulator.c @@ -320,7 +320,7 @@ MODULE_DEVICE_TABLE(of, max20086_dt_ids); static struct i2c_driver max20086_regulator_driver = { .driver = { .name = "max20086", - .of_match_table = of_match_ptr(max20086_dt_ids), + .of_match_table = max20086_dt_ids, }, .probe_new = max20086_i2c_probe, .id_table = max20086_i2c_id, Your patch should reduce the module size without any real drawback as far as I can see, so that's probably best. I'm fine with either approach, so Reviewed-by: Laurent Pinchart > { > .compatible = "maxim,max20086", > .data = &(const struct max20086_chip_info) { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7F13C6FA99 for ; Sun, 12 Mar 2023 09:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1upanLKNrPRu3ZeCmQuRo4EjP9vi5uvsGswIO9Jx1Tk=; b=qvHuUPfZRwqERw gmxB1YMf38DaN0CAaLm3vWQjNuyzczCaAB1PFLUBeIZE16PZzjDOQZvzZi3J4mY2cpj5uQDToj7jZ ysHGHQk94CCpqp/gn7uhgkC1WNA4q9RM0hywoBbNAXF87Ul0I/NmYCYyKBGYCErhAOWBJgSngIGRc 75/onUg3tHEn+2wIk/gQYbs5TQXxMUoW2MaBUZVw+bWC6L3Fj+P4TMzyp6uuK7n75NT9hsFz+HsAX eI/YNcjn2sw3s5/2iAFSVl2YVbWCFhEpZwqPzJxgUMCcnzjVU2rhEDMcjVW3oVVf7M7JYOi+BOtWS NdxLe8oMb3WXto2amMmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbIDg-0022d4-9G; Sun, 12 Mar 2023 09:42:24 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbIDc-0022cM-Nz; Sun, 12 Mar 2023 09:42:22 +0000 Received: from pendragon.ideasonboard.com (85-76-49-20-nat.elisa-mobile.fi [85.76.49.20]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E5D30814; Sun, 12 Mar 2023 10:42:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1678614135; bh=2ZEVl5rsK5H4zvdfeUpUGY8WalO/tOcjHbf6ZixUYTY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uW96zgPhEyFUlg4cwx9U8aHK5ydpIh7K+GzgaU9BL/vhdw/+zL9BwsVRIklgwy83n znnzlWCsVkBmtHm+lRiw3bEhYFZhWAax0IaEGUVALEnD+uuJxSGkkm7T2ZqG7LsoeF i/JJlR0QZobdvA1oeaCuik3cfnIoI/l0HyEqwgro= Date: Sun, 12 Mar 2023 11:42:16 +0200 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno , Tony Lindgren , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/9] regulator: max20086: Mark OF related data as maybe unused Message-ID: <20230312094216.GC707@pendragon.ideasonboard.com> References: <20230310214553.275450-1-krzysztof.kozlowski@linaro.org> <20230310214553.275450-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230310214553.275450-2-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230312_014220_967828_21C28D77 X-CRM114-Status: GOOD ( 19.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmksIE1hciAxMCwg MjAyMyBhdCAxMDo0NTo0NlBNICswMTAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+IFRo ZSBkcml2ZXIgY2FuIGJlIGNvbXBpbGUgdGVzdGVkIHdpdGggIUNPTkZJR19PRiBtYWtpbmcgY2Vy dGFpbiBkYXRhCj4gdW51c2VkOgo+IAo+ICAgZHJpdmVycy9yZWd1bGF0b3IvbWF4MjAwODYtcmVn dWxhdG9yLmM6Mjg5OjM0OiBlcnJvcjog4oCYbWF4MjAwODZfZHRfaWRz4oCZIGRlZmluZWQgYnV0 IG5vdCB1c2VkIFstV2Vycm9yPXVudXNlZC1jb25zdC12YXJpYWJsZT1dCj4gCj4gU2lnbmVkLW9m Zi1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3Jn Pgo+IC0tLQo+ICBkcml2ZXJzL3JlZ3VsYXRvci9tYXgyMDA4Ni1yZWd1bGF0b3IuYyB8IDIgKy0K PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvcmVndWxhdG9yL21heDIwMDg2LXJlZ3VsYXRvci5jIGIvZHJpdmVy cy9yZWd1bGF0b3IvbWF4MjAwODYtcmVndWxhdG9yLmMKPiBpbmRleCBiOGJmNzZjMTcwZmUuLmM5 OGE3MmY0MzkzNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3JlZ3VsYXRvci9tYXgyMDA4Ni1yZWd1 bGF0b3IuYwo+ICsrKyBiL2RyaXZlcnMvcmVndWxhdG9yL21heDIwMDg2LXJlZ3VsYXRvci5jCj4g QEAgLTI4Niw3ICsyODYsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQgbWF4 MjAwODZfaTJjX2lkW10gPSB7Cj4gIAo+ICBNT0RVTEVfREVWSUNFX1RBQkxFKGkyYywgbWF4MjAw ODZfaTJjX2lkKTsKPiAgCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIG1heDIw MDg2X2R0X2lkc1tdID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtYXgy MDA4Nl9kdF9pZHNbXSBfX21heWJlX3VudXNlZCA9IHsKClRoZSBmb2xsb3dpbmcgY2hhbmdlIHdv dWxkIGFsc28gd29yaywgYXMgdGhlIG9mX21hdGNoX3RhYmxlIGZpZWxkIG9mCnN0cnVjdCBkZXZp Y2VfZHJpdmVyIGlzbid0IGNvbmRpdGlvbmVkIGJ5IENPTkZJR19PRjoKCmRpZmYgLS1naXQgYS9k cml2ZXJzL3JlZ3VsYXRvci9tYXgyMDA4Ni1yZWd1bGF0b3IuYyBiL2RyaXZlcnMvcmVndWxhdG9y L21heDIwMDg2LXJlZ3VsYXRvci5jCmluZGV4IGI4YmY3NmMxNzBmZS4uYWQ5MmY4NGI0YWJiIDEw MDY0NAotLS0gYS9kcml2ZXJzL3JlZ3VsYXRvci9tYXgyMDA4Ni1yZWd1bGF0b3IuYworKysgYi9k cml2ZXJzL3JlZ3VsYXRvci9tYXgyMDA4Ni1yZWd1bGF0b3IuYwpAQCAtMzIwLDcgKzMyMCw3IEBA IE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIG1heDIwMDg2X2R0X2lkcyk7CiBzdGF0aWMgc3RydWN0 IGkyY19kcml2ZXIgbWF4MjAwODZfcmVndWxhdG9yX2RyaXZlciA9IHsKIAkuZHJpdmVyID0gewog CQkubmFtZSA9ICJtYXgyMDA4NiIsCi0JCS5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX3B0ciht YXgyMDA4Nl9kdF9pZHMpLAorCQkub2ZfbWF0Y2hfdGFibGUgPSBtYXgyMDA4Nl9kdF9pZHMsCiAJ fSwKIAkucHJvYmVfbmV3ID0gbWF4MjAwODZfaTJjX3Byb2JlLAogCS5pZF90YWJsZSA9IG1heDIw MDg2X2kyY19pZCwKCllvdXIgcGF0Y2ggc2hvdWxkIHJlZHVjZSB0aGUgbW9kdWxlIHNpemUgd2l0 aG91dCBhbnkgcmVhbCBkcmF3YmFjayBhcwpmYXIgYXMgSSBjYW4gc2VlLCBzbyB0aGF0J3MgcHJv YmFibHkgYmVzdC4gSSdtIGZpbmUgd2l0aCBlaXRoZXIKYXBwcm9hY2gsIHNvCgpSZXZpZXdlZC1i eTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoK PiAgCXsKPiAgCQkuY29tcGF0aWJsZSA9ICJtYXhpbSxtYXgyMDA4NiIsCj4gIAkJLmRhdGEgPSAm KGNvbnN0IHN0cnVjdCBtYXgyMDA4Nl9jaGlwX2luZm8pIHsKCi0tIApSZWdhcmRzLAoKTGF1cmVu dCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=