All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next 1/1] package/python-hwdata: new package
Date: Sun, 12 Mar 2023 10:23:42 +0100	[thread overview]
Message-ID: <20230312102342.2f2393b0@windsurf> (raw)
In-Reply-To: <20230311184148.183739-1-ju.o@free.fr>

Hello Julien,

Thanks for this work!

On Sat, 11 Mar 2023 19:41:48 +0100
Julien Olivain <ju.o@free.fr> wrote:

> +PYTHON_HWDATA_VERSION = 2.3.7
> +PYTHON_HWDATA_SOURCE = hwdata-$(PYTHON_HWDATA_VERSION).tar.gz
> +PYTHON_HWDATA_SITE = https://files.pythonhosted.org/packages/15/26/f5bc1b42129fbcbd1c99c29714af1685fc89e2cf37680a9930d4fcac1808
> +PYTHON_HWDATA_SETUP_TYPE = distutils
> +PYTHON_HWDATA_LICENSE = GPL-2.0+
> +PYTHON_HWDATA_LICENSE_FILES = LICENSE

This doesn't work because there is no LICENSE file in the PyPi tarball
(and also the hash file does not have the hash of that file):

>>> python-hwdata 2.3.7 Collecting legal info
ERROR: No hash found for LICENSE
cp: cannot stat '/home/thomas/projets/buildroot/output/build/python-hwdata-2.3.7/LICENSE': No such file or directory
make: *** [package/python-hwdata/python-hwdata.mk:16: python-hwdata-legal-info] Error 1

One thing you could do to address this is:

PYTHON_HWDATA_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/xsuchy/python-hwdata/python-hwdata-2.3.7-1/LICENSE

and then add a post-extract hook that copies $(PYTHON_HWDATA_DLDIR) to
$(@D), and then use LICENSE as the license file.

This will of course require an update in the hash file.

Do you think you could look into this? The rest of the patch looks
good, of course.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-03-12  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 18:41 [Buildroot] [PATCH next 1/1] package/python-hwdata: new package Julien Olivain
2023-03-12  9:23 ` Thomas Petazzoni via buildroot [this message]
2023-03-12  9:43   ` Julien Olivain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230312102342.2f2393b0@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.