From: Johan Hovold <johan+linaro@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Yassine Oudjana <y.oudjana@protonmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
stable@vger.kernel.org
Subject: [PATCH 1/2] interconnect: qcom: rpm: fix msm8996 interconnect registration
Date: Mon, 13 Mar 2023 09:49:52 +0100 [thread overview]
Message-ID: <20230313084953.24088-2-johan+linaro@kernel.org> (raw)
In-Reply-To: <20230313084953.24088-1-johan+linaro@kernel.org>
A recent commit broke interconnect provider registration for the msm8996
platform by accidentally removing a conditional when adding the missing
clock disable in the power-domain lookup error path.
Fixes: b6edcc7570b2 ("interconnect: qcom: rpm: fix probe PM domain error handling")
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/641d04a3-9236-fe76-a20f-11466a01460e@wanadoo.fr
Cc: stable@vger.kernel.org # 5.17
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/interconnect/qcom/icc-rpm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
index 4d0997b210f7..3b055cd893ea 100644
--- a/drivers/interconnect/qcom/icc-rpm.c
+++ b/drivers/interconnect/qcom/icc-rpm.c
@@ -498,7 +498,8 @@ int qnoc_probe(struct platform_device *pdev)
if (desc->has_bus_pd) {
ret = dev_pm_domain_attach(dev, true);
- goto err_disable_clks;
+ if (ret)
+ goto err_disable_clks;
}
provider = &qp->provider;
--
2.39.2
next prev parent reply other threads:[~2023-03-13 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 8:49 [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration Johan Hovold
2023-03-13 8:49 ` Johan Hovold [this message]
2023-03-13 8:57 ` [PATCH 1/2] " Konrad Dybcio
2023-03-13 9:11 ` Johan Hovold
2023-03-13 8:49 ` [PATCH 2/2] interconnect: qcom: rpm: drop bogus pm domain attach Johan Hovold
2023-03-13 9:10 ` Konrad Dybcio
2023-03-13 19:58 ` Georgi Djakov
2023-03-14 7:46 ` Johan Hovold
2023-03-13 19:57 ` [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration Georgi Djakov
2023-03-14 7:45 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313084953.24088-2-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.