From: Jakub Kicinski <kuba@kernel.org>
To: Hao Lan <lanhao@huawei.com>
Cc: Simon Horman <simon.horman@corigine.com>, <andrew@lunn.ch>,
<davem@davemloft.net>, <alexander.duyck@gmail.com>,
<yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <shenjian15@huawei.com>,
<netdev@vger.kernel.org>, <wangjie125@huawei.com>
Subject: Re: [PATCH v3 net-next] net: hns3: support wake on lan configuration and query
Date: Mon, 13 Mar 2023 12:16:44 -0700 [thread overview]
Message-ID: <20230313121644.5f3bf4c7@kernel.org> (raw)
In-Reply-To: <3e2be728-cb68-36cf-0dd4-a62ba5601cea@huawei.com>
On Mon, 13 Mar 2023 16:05:55 +0800 Hao Lan wrote:
> Thanks for your suggestion. Generally I follow the reverse xmas tree style
> for readability. But for this case, whether it looks a bit bloated ?
It only appears so because the driver has too many indirection layers.
Add a helper to go from netdev to the local struct.
Reminder: please don't top post and trim your replies.
prev parent reply other threads:[~2023-03-13 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 8:14 [PATCH v3 net-next] net: hns3: support wake on lan configuration and query Hao Lan
2023-03-11 12:15 ` Simon Horman
2023-03-13 8:05 ` Hao Lan
2023-03-13 19:16 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313121644.5f3bf4c7@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lanhao@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=simon.horman@corigine.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.