From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Zheng Wang <zyytlz.wz@163.com>,
ericvh@gmail.com, lucho@ionkov.net, asmadeus@codewreck.org,
linux_oss@crudebyte.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hackerzheng666@gmail.com,
1395428693sheep@gmail.com, alex000young@gmail.com
Subject: Re: [PATCH net v2] 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition
Date: Mon, 13 Mar 2023 14:30:54 -0700 [thread overview]
Message-ID: <20230313143054.538565ac@kernel.org> (raw)
In-Reply-To: <ZA8rDCw+mJmyETEx@localhost.localdomain>
On Mon, 13 Mar 2023 14:54:20 +0100 Michal Swiatkowski wrote:
> > @@ -274,12 +274,17 @@ static const struct xenbus_device_id xen_9pfs_front_ids[] = {
> > static void xen_9pfs_front_free(struct xen_9pfs_front_priv *priv)
> > {
> > int i, j;
> > + struct xen_9pfs_dataring *ring = NULL;
> Move it before int i, j to have RCT.
>
> >
> > write_lock(&xen_9pfs_lock);
> > list_del(&priv->list);
> > write_unlock(&xen_9pfs_lock);
> >
> > for (i = 0; i < priv->num_rings; i++) {
> > + /*cancel work*/
> It isn't needed I think, the function cancel_work_sync() tells everything
> here.
Note that 9p is more storage than networking, so this patch is likely
to go via a different tree than us.
next prev parent reply other threads:[~2023-03-13 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 9:00 [PATCH net v2] 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition Zheng Wang
2023-03-13 13:54 ` Michal Swiatkowski
2023-03-13 14:01 ` Zheng Hacker
2023-03-13 14:07 ` Michal Swiatkowski
2023-03-13 14:10 ` Zheng Hacker
2023-03-13 21:30 ` Jakub Kicinski [this message]
2023-03-13 22:07 ` asmadeus
2023-03-14 1:14 ` Zheng Hacker
2023-03-14 1:07 ` Zheng Hacker
-- strict thread matches above, loose matches on Subject: below --
2023-03-13 16:54 Zheng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313143054.538565ac@kernel.org \
--to=kuba@kernel.org \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=hackerzheng666@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.