All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [skeggsb-nouveau:01.03-gsp-ada 58/68] drivers/gpu/drm/nouveau/nvkm/engine/fifo/r525.c:287:1: warning: no previous prototype for 'r525_fifo_runl_ctor'
Date: Mon, 13 Mar 2023 19:37:34 +0800	[thread overview]
Message-ID: <202303131935.cdIBstcd-lkp@intel.com> (raw)

tree:   https://gitlab.freedesktop.org/skeggsb/nouveau 01.03-gsp-ada
head:   89da5e5109a92f4be025e40b80d1f1a6c1d6d8c7
commit: 09e551038a5b001eb367789a28e56c5bca36af72 [58/68] fifo
config: arm-randconfig-r046-20230313 (https://download.01.org/0day-ci/archive/20230313/202303131935.cdIBstcd-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add skeggsb-nouveau https://gitlab.freedesktop.org/skeggsb/nouveau
        git fetch --no-tags skeggsb-nouveau 01.03-gsp-ada
        git checkout 09e551038a5b001eb367789a28e56c5bca36af72
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303131935.cdIBstcd-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/nouveau/nvkm/engine/fifo/r525.c:287:1: warning: no previous prototype for 'r525_fifo_runl_ctor' [-Wmissing-prototypes]
     287 | r525_fifo_runl_ctor(struct nvkm_fifo *fifo)
         | ^~~~~~~~~~~~~~~~~~~


vim +/r525_fifo_runl_ctor +287 drivers/gpu/drm/nouveau/nvkm/engine/fifo/r525.c

   284	
   285	
   286	int
 > 287	r525_fifo_runl_ctor(struct nvkm_fifo *fifo)
   288	{
   289		struct nvkm_subdev *subdev = &fifo->engine.subdev;
   290		struct nvkm_gsp *gsp = subdev->device->gsp;
   291		struct nvkm_runl *runl;
   292		int ret;
   293		NV2080_CTRL_FIFO_GET_DEVICE_INFO_TABLE_PARAMS *ctrl;
   294	
   295		//XXX: chid<->userd + per-RL chid
   296		if ((ret = nvkm_chid_new(&nvkm_chan_event, subdev, 2048, 0, 2048, &fifo->cgid)) ||
   297		    (ret = nvkm_chid_new(&nvkm_chan_event, subdev, 2048, 0, 2048, &fifo->chid)))
   298			return ret;
   299	
   300		ctrl = nvkm_gsp_rm_ctrl_get(gsp, gsp->client, gsp->subdevice,
   301					    NV2080_CTRL_CMD_FIFO_GET_DEVICE_INFO_TABLE, sizeof(*ctrl));
   302		if (WARN_ON(IS_ERR(ctrl)))
   303			return PTR_ERR(ctrl);
   304	
   305		ctrl = nvkm_gsp_rm_ctrl_push(gsp, ctrl, sizeof(*ctrl));
   306		if (WARN_ON(IS_ERR(ctrl)))
   307			return PTR_ERR(ctrl);
   308	
   309		for (int i = 0; i < ctrl->numEntries; i++) {
   310			const u32 addr = ctrl->entries[i].engineData[ENGINE_INFO_TYPE_RUNLIST_PRI_BASE];
   311			const u32 engn = ctrl->entries[i].engineData[ENGINE_INFO_TYPE_RM_ENGINE_TYPE];
   312			const u32 id = ctrl->entries[i].engineData[ENGINE_INFO_TYPE_RUNLIST];
   313			enum nvkm_subdev_type type;
   314			int inst, nv2080;
   315	
   316			runl = nvkm_runl_get(fifo, id, addr);
   317			if (!runl) {
   318				runl = nvkm_runl_new(fifo, id, addr, 0 /*XXX: chid<->userd + per-RL chid*/);
   319				if (WARN_ON(IS_ERR(runl)))
   320					continue;
   321			}
   322	
   323			inst = r525_fifo_engn_type(engn, &type);
   324			if (inst < 0) {
   325				nvkm_warn(subdev, "RM_ENGINE_TYPE 0x%x\n", engn);
   326				continue;
   327			}
   328	
   329			nv2080 = r525_fifo_2080_type(type, inst);
   330			if (nv2080 < 0)
   331				continue;
   332	
   333			if (type == NVKM_ENGINE_CE)
   334				nvkm_runl_add(runl, nv2080, fifo->func->engn_ce, type, inst);
   335			else
   336				nvkm_runl_add(runl, nv2080, fifo->func->engn, type, inst);
   337		}
   338	
   339		nvkm_gsp_rm_ctrl_done(gsp, ctrl);
   340		return 0;
   341	}
   342	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

             reply	other threads:[~2023-03-13 11:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 11:37 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-13 11:37 [skeggsb-nouveau:01.03-gsp-ada 58/68] drivers/gpu/drm/nouveau/nvkm/engine/fifo/r525.c:287:1: warning: no previous prototype for 'r525_fifo_runl_ctor' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303131935.cdIBstcd-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bskeggs@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.