From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA4DBC6FD1F for ; Tue, 14 Mar 2023 07:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbjCNH5s (ORCPT ); Tue, 14 Mar 2023 03:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjCNH5r (ORCPT ); Tue, 14 Mar 2023 03:57:47 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A089211D9; Tue, 14 Mar 2023 00:57:45 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4461B1C000A; Tue, 14 Mar 2023 07:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678780664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rV/48DFH0VRtT8styWUtBxfjMGT8+CfYXF8J4C5hkDc=; b=RG3+iLr/iC05m99Svg5Uu2IkjXiuvdGWcpm6yDSeZEWm+E5c0c3WUExdpe20VHpuyw7oRp sR1TnJ7M9s9WS9jFpzOPPVfWvKEHVUaZefl982MrSxEHgN/noBm3HP/EKnAzwXK13/YiD9 htDf5t1pzBEvhdUHYJJWYl+7x/8c2A6+ouv9VE2jFcdR8IrigfdrlZA5DuLECwtItfy6P9 LqJC9W/6/pl9gV4fUjwbS9UV4zalfIHL3C4uMBN2hRcsBoj7+M4Ijl37sIkodESZtuHfHH xQZ4joqYKs6UefCIYMfSwyBVPTrLf5TvciPH8/oHYpCcqtkroJROuF++5bmMww== Date: Tue, 14 Mar 2023 08:57:41 +0100 From: Herve Codina To: Lukas Bulwahn Cc: Li Yang , Christophe Leroy , Mark Brown , Qiang Zhao , linuxppc-dev , Linux ARM , Linux Kernel Mailing List , kernel-janitors Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC Message-ID: <20230314085741.6f968e68@bootlin.com> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Hi Lukas, On Tue, 14 Mar 2023 08:21:50 +0100 Lukas Bulwahn wrote: > Dear Herve, >=20 > In your patch below, you added the config CPM_QMC which depends on the > non-existing config SOC_FSL: >=20 > https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.c= om >=20 > Up to my knowledge, the config SOC_FSL never existed in the mainline > tree. Is this dependency really required or can the expression simply > be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL? >=20 > Note: This patch has now shown up in linux-next with commit > 3178d58e0b97. Currently, it would not be possible to compile test this > driver, as the dependency on SOC_FSL is never met. >=20 >=20 > Best regards, >=20 > Lukas My bad :( The dependency must be FSL_SOC instead of SOC_FSL. I mean: diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig index f90cfdf0c763..7268c2fbcbc1 100644 --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -47,7 +47,7 @@ config CPM_TSA config CPM_QMC tristate "CPM QMC support" depends on OF && HAS_IOMEM - depends on CPM1 || (SOC_FSL && COMPILE_TEST) + depends on CPM1 || (FSL_SOC && COMPILE_TEST) depends on CPM_TSA help Freescale CPM QUICC Multichannel Controller --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6707C6FD1F for ; Tue, 14 Mar 2023 07:58:47 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PbQrk1xlWz3cMr for ; Tue, 14 Mar 2023 18:58:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=RG3+iLr/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.197; helo=relay5-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=RG3+iLr/; dkim-atps=neutral Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PbQqh1Dd0z3bym for ; Tue, 14 Mar 2023 18:57:48 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4461B1C000A; Tue, 14 Mar 2023 07:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678780664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rV/48DFH0VRtT8styWUtBxfjMGT8+CfYXF8J4C5hkDc=; b=RG3+iLr/iC05m99Svg5Uu2IkjXiuvdGWcpm6yDSeZEWm+E5c0c3WUExdpe20VHpuyw7oRp sR1TnJ7M9s9WS9jFpzOPPVfWvKEHVUaZefl982MrSxEHgN/noBm3HP/EKnAzwXK13/YiD9 htDf5t1pzBEvhdUHYJJWYl+7x/8c2A6+ouv9VE2jFcdR8IrigfdrlZA5DuLECwtItfy6P9 LqJC9W/6/pl9gV4fUjwbS9UV4zalfIHL3C4uMBN2hRcsBoj7+M4Ijl37sIkodESZtuHfHH xQZ4joqYKs6UefCIYMfSwyBVPTrLf5TvciPH8/oHYpCcqtkroJROuF++5bmMww== Date: Tue, 14 Mar 2023 08:57:41 +0100 From: Herve Codina To: Lukas Bulwahn Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC Message-ID: <20230314085741.6f968e68@bootlin.com> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors , Linux Kernel Mailing List , Li Yang , Mark Brown , linuxppc-dev , Linux ARM , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Lukas, On Tue, 14 Mar 2023 08:21:50 +0100 Lukas Bulwahn wrote: > Dear Herve, >=20 > In your patch below, you added the config CPM_QMC which depends on the > non-existing config SOC_FSL: >=20 > https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.c= om >=20 > Up to my knowledge, the config SOC_FSL never existed in the mainline > tree. Is this dependency really required or can the expression simply > be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL? >=20 > Note: This patch has now shown up in linux-next with commit > 3178d58e0b97. Currently, it would not be possible to compile test this > driver, as the dependency on SOC_FSL is never met. >=20 >=20 > Best regards, >=20 > Lukas My bad :( The dependency must be FSL_SOC instead of SOC_FSL. I mean: diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig index f90cfdf0c763..7268c2fbcbc1 100644 --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -47,7 +47,7 @@ config CPM_TSA config CPM_QMC tristate "CPM QMC support" depends on OF && HAS_IOMEM - depends on CPM1 || (SOC_FSL && COMPILE_TEST) + depends on CPM1 || (FSL_SOC && COMPILE_TEST) depends on CPM_TSA help Freescale CPM QUICC Multichannel Controller --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FC38C6FD1C for ; Tue, 14 Mar 2023 07:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dZtxu6mnRwVushYziMn28ZdN2t3a8ht4RabsMNXxTkQ=; b=kZf+9lVZGDHevP XXAA4tow5ZX5pcpgWApMvGpC44/DD7SsN0bBipp+AQQN0RSTYX47XNGKMBJM+Nyl02VXQogl+wWD1 vqsfOv124lePaktUeS0SSScaq80GaUdgBbEyA00XohGCHQRNPUNiBR1xkHfVZtoq4vNPSGNDhmeJ1 9b1FQt8pWYOo4yUWApxiqbZZy5j5zVULrMudbLh9ewSghXSeK91Na+KDXV1XFGDICCZQMZaS0zV+f RtSTyD1wr6vB4zjbqC7TXpCyjwoSio+izc3FGLZkcLNX0wHO3mHZCzBdMpiZQkcIYFHgj8eVAO3dZ BpT461chagir/c3qIuKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbzXq-009Q0B-BS; Tue, 14 Mar 2023 07:58:06 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbzXb-009PwF-EV for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 07:57:53 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4461B1C000A; Tue, 14 Mar 2023 07:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678780664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rV/48DFH0VRtT8styWUtBxfjMGT8+CfYXF8J4C5hkDc=; b=RG3+iLr/iC05m99Svg5Uu2IkjXiuvdGWcpm6yDSeZEWm+E5c0c3WUExdpe20VHpuyw7oRp sR1TnJ7M9s9WS9jFpzOPPVfWvKEHVUaZefl982MrSxEHgN/noBm3HP/EKnAzwXK13/YiD9 htDf5t1pzBEvhdUHYJJWYl+7x/8c2A6+ouv9VE2jFcdR8IrigfdrlZA5DuLECwtItfy6P9 LqJC9W/6/pl9gV4fUjwbS9UV4zalfIHL3C4uMBN2hRcsBoj7+M4Ijl37sIkodESZtuHfHH xQZ4joqYKs6UefCIYMfSwyBVPTrLf5TvciPH8/oHYpCcqtkroJROuF++5bmMww== Date: Tue, 14 Mar 2023 08:57:41 +0100 From: Herve Codina To: Lukas Bulwahn Cc: Li Yang , Christophe Leroy , Mark Brown , Qiang Zhao , linuxppc-dev , Linux ARM , Linux Kernel Mailing List , kernel-janitors Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC Message-ID: <20230314085741.6f968e68@bootlin.com> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_005751_674934_5883A57D X-CRM114-Status: GOOD ( 14.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTHVrYXMsCgpPbiBUdWUsIDE0IE1hciAyMDIzIDA4OjIxOjUwICswMTAwCkx1a2FzIEJ1bHdh aG4gPGx1a2FzLmJ1bHdhaG5AZ21haWwuY29tPiB3cm90ZToKCj4gRGVhciBIZXJ2ZSwKPiAKPiBJ biB5b3VyIHBhdGNoIGJlbG93LCB5b3UgYWRkZWQgdGhlIGNvbmZpZyBDUE1fUU1DIHdoaWNoIGRl cGVuZHMgb24gdGhlCj4gbm9uLWV4aXN0aW5nIGNvbmZpZyBTT0NfRlNMOgo+IAo+IGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL3IvMjAyMzAyMTcxNDU2NDUuMTc2ODY1OS03LWhlcnZlLmNvZGluYUBi b290bGluLmNvbQo+IAo+IFVwIHRvIG15IGtub3dsZWRnZSwgdGhlIGNvbmZpZyBTT0NfRlNMIG5l dmVyIGV4aXN0ZWQgaW4gdGhlIG1haW5saW5lCj4gdHJlZS4gSXMgdGhpcyBkZXBlbmRlbmN5IHJl YWxseSByZXF1aXJlZCBvciBjYW4gdGhlIGV4cHJlc3Npb24gc2ltcGx5Cj4gYmUgcmVkdWNlZCB0 byBDT01QSUxFX1RFU1QgYW5kIHdlIGRyb3AgdGhlIGRlcGVuZGVuY3kgdG8gU09DX0ZTTD8KPiAK PiBOb3RlOiBUaGlzIHBhdGNoIGhhcyBub3cgc2hvd24gdXAgaW4gbGludXgtbmV4dCB3aXRoIGNv bW1pdAo+IDMxNzhkNThlMGI5Ny4gQ3VycmVudGx5LCBpdCB3b3VsZCBub3QgYmUgcG9zc2libGUg dG8gY29tcGlsZSB0ZXN0IHRoaXMKPiBkcml2ZXIsIGFzIHRoZSBkZXBlbmRlbmN5IG9uIFNPQ19G U0wgaXMgbmV2ZXIgbWV0Lgo+IAo+IAo+IEJlc3QgcmVnYXJkcywKPiAKPiBMdWthcwoKTXkgYmFk IDooCgpUaGUgZGVwZW5kZW5jeSBtdXN0IGJlIEZTTF9TT0MgaW5zdGVhZCBvZiBTT0NfRlNMLgpJ IG1lYW46CmRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9mc2wvcWUvS2NvbmZpZyBiL2RyaXZlcnMv c29jL2ZzbC9xZS9LY29uZmlnCmluZGV4IGY5MGNmZGYwYzc2My4uNzI2OGMyZmJjYmMxIDEwMDY0 NAotLS0gYS9kcml2ZXJzL3NvYy9mc2wvcWUvS2NvbmZpZworKysgYi9kcml2ZXJzL3NvYy9mc2wv cWUvS2NvbmZpZwpAQCAtNDcsNyArNDcsNyBAQCBjb25maWcgQ1BNX1RTQQogY29uZmlnIENQTV9R TUMKICAgICAgICB0cmlzdGF0ZSAiQ1BNIFFNQyBzdXBwb3J0IgogICAgICAgIGRlcGVuZHMgb24g T0YgJiYgSEFTX0lPTUVNCi0gICAgICAgZGVwZW5kcyBvbiBDUE0xIHx8IChTT0NfRlNMICYmIENP TVBJTEVfVEVTVCkKKyAgICAgICBkZXBlbmRzIG9uIENQTTEgfHwgKEZTTF9TT0MgJiYgQ09NUElM RV9URVNUKQogICAgICAgIGRlcGVuZHMgb24gQ1BNX1RTQQogICAgICAgIGhlbHAKICAgICAgICAg IEZyZWVzY2FsZSBDUE0gUVVJQ0MgTXVsdGljaGFubmVsIENvbnRyb2xsZXIKCgoKLS0gCkhlcnbD qSBDb2RpbmEsIEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpo dHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==