From: Petr Vorel <pvorel@suse.cz>
To: Ping Fang <pifang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] setfsuid02_16: Fix uid -1 too large for testing 16-bit version
Date: Tue, 14 Mar 2023 11:38:26 +0100 [thread overview]
Message-ID: <20230314103826.GB40740@pevik> (raw)
In-Reply-To: <CANKfEn6YtZRnFJYAePRg3e7W2yESMuVd=Lh4r4b9TpgUtGdYBQ@mail.gmail.com>
Hi Ping,
> > > __kernel_old_uid_t is not defined as 16bit on s390, ppc64le
> > I suppose limitation on s390 is because __kernel_old_uid_t is guarded only
> > for
> > kernel, right?
> Yes, userspace header will use definition in
> /usr/include/asm-generic/posix_types.h
> unsigned int break the size check.
Thanks for additional info.
> > arch/s390/include/uapi/asm/posix_types.h
> > #ifdef __KERNEL__
> > typedef unsigned short __kernel_old_uid_t;
> > typedef unsigned short __kernel_old_gid_t;
> > #define __kernel_old_uid_t __kernel_old_uid_t
> > #endif
> > > Then -1 will be translated into UINT_MAX fails the size check.
> > > s390, ppc64le use definition in /usr/include/asm-generic/posix_types.h
> > BTW do you test LTP syscalls on s930 and ppc (32bit)?
> I don't have these machines at hand.
Ah, I see it's broken on 64bit (not many people have 32bit for s390 or ppc).
Merged, thank you!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-03-14 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 8:54 [LTP] [PATCH v1] setfsuid02_16: Fix uid -1 too large for testing 16-bit version Ping Fang
2023-03-13 9:00 ` Li Wang
2023-03-13 22:24 ` Petr Vorel
2023-03-14 1:43 ` Ping Fang
2023-03-14 10:38 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314103826.GB40740@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pifang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.