From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3195EC05027 for ; Tue, 14 Mar 2023 17:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678814156; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=o8fks+7TvLb0ghTgpzg23S60N4uWEsPOOG3eZEeoWpE=; b=hVqNrEEYqKxYMMErnZesSPqQan3sBbK88gScwGQLH1B3oipYcVaDyUNYla+hHMsMWIzEu1 8rOstlngeIIGtFfVIJcJQeDgLc5/Flnk5/E9TkhTmP2Mq7EqpAfaGIlSHiQFAS+/fMc0UW jhvdPqyu2/7Z2CSEVaRGcftFMX4RD94= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-338-PLMhzdzGMMevTau4hS9WxA-1; Tue, 14 Mar 2023 13:15:54 -0400 X-MC-Unique: PLMhzdzGMMevTau4hS9WxA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1F58889047; Tue, 14 Mar 2023 17:15:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1135492B00; Tue, 14 Mar 2023 17:15:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 97D6A19465A2; Tue, 14 Mar 2023 17:15:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BC01019465A0 for ; Tue, 14 Mar 2023 17:15:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 57B1B1121318; Tue, 14 Mar 2023 17:15:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5024A1121315 for ; Tue, 14 Mar 2023 17:15:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3534985A5A3 for ; Tue, 14 Mar 2023 17:15:44 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-MoTsxoe2PVqrdWnNxpV0Gw-1; Tue, 14 Mar 2023 13:15:41 -0400 X-MC-Unique: MoTsxoe2PVqrdWnNxpV0Gw-1 Received: by verein.lst.de (Postfix, from userid 2407) id D95EE68B05; Tue, 14 Mar 2023 18:15:38 +0100 (CET) Date: Tue, 14 Mar 2023 18:15:38 +0100 From: Christoph Hellwig To: Mike Christie Message-ID: <20230314171538.GG6780@lst.de> References: <20230224174502.321490-1-michael.christie@oracle.com> <20230224174502.321490-8-michael.christie@oracle.com> MIME-Version: 1.0 In-Reply-To: <20230224174502.321490-8-michael.christie@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Subject: Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, chaitanyak@nvidia.com, bvanassche@acm.org, linux-scsi@vger.kernel.org, snitzer@kernel.org, linux-nvme@lists.infradead.org, james.bottomley@hansenpartnership.com, dm-devel@redhat.com, target-devel@vger.kernel.org, martin.petersen@oracle.com, kbusch@kernel.org, hch@lst.de Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Feb 24, 2023 at 11:44:51AM -0600, Mike Christie wrote: > + __u8 resv10[14]; > + union { > + struct { > + __u8 rsvd24[40]; > + struct nvme_registered_ctrl_ext regctl_eds[0]; > + }; > + struct nvme_registered_ctrl regctl_ds[0]; > + }; ... actually - I think both these zero sized arrays should be the modern [] notation. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC4AC7618A for ; Tue, 14 Mar 2023 17:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbjCNRPo (ORCPT ); Tue, 14 Mar 2023 13:15:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjCNRPn (ORCPT ); Tue, 14 Mar 2023 13:15:43 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE1A8BDE5; Tue, 14 Mar 2023 10:15:41 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id D95EE68B05; Tue, 14 Mar 2023 18:15:38 +0100 (CET) Date: Tue, 14 Mar 2023 18:15:38 +0100 From: Christoph Hellwig To: Mike Christie Cc: bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com, linux-block@vger.kernel.org, dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk, linux-nvme@lists.infradead.org, chaitanyak@nvidia.com, kbusch@kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH v4 07/18] nvme: Fix reservation status related structs Message-ID: <20230314171538.GG6780@lst.de> References: <20230224174502.321490-1-michael.christie@oracle.com> <20230224174502.321490-8-michael.christie@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230224174502.321490-8-michael.christie@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Feb 24, 2023 at 11:44:51AM -0600, Mike Christie wrote: > + __u8 resv10[14]; > + union { > + struct { > + __u8 rsvd24[40]; > + struct nvme_registered_ctrl_ext regctl_eds[0]; > + }; > + struct nvme_registered_ctrl regctl_ds[0]; > + }; ... actually - I think both these zero sized arrays should be the modern [] notation.