From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: "Mogilappagari, Sudheer" <sudheer.mogilappagari@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [PATCH net-next] ethtool: add netlink support for rss set
Date: Tue, 14 Mar 2023 21:23:34 -0700 [thread overview]
Message-ID: <20230314212334.188ad6e0@kernel.org> (raw)
In-Reply-To: <1710d769-4f11-22d7-938d-eda0133a2d62@gmail.com>
On Tue, 14 Mar 2023 13:34:51 +0000 Edward Cree wrote:
> > Add a pointer to struct
> > netdevice to hold an "ethtool_settings" struct. In the ethtool settings
> > struct add a list head. Put an object for each created RSS context on
> > that list.
> Would an IDR not be appropriate here, rather than a list?
Yup, I was too lazy how much memory IDR eats when unused, and list is
easier to explain, but let's just go for an xarray if you're doing it.
> AFAICT every driver that supports contexts either treats the context
> ID as an opaque handle or as an index into a fixed-size array, so as
> long as the driver reports its max context ID to the core somehow,
> the specific ID values chosen are arbitrary and the driver doesn't
> need to do the choosing, it can just take what comes out of the IDR.
Sounds great.
prev parent reply other threads:[~2023-03-15 4:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 22:05 [PATCH net-next] ethtool: add netlink support for rss set Sudheer Mogilappagari
2023-03-10 7:21 ` Jakub Kicinski
2023-03-13 22:34 ` Mogilappagari, Sudheer
2023-03-13 22:53 ` Jakub Kicinski
2023-03-14 13:34 ` Edward Cree
2023-03-14 23:51 ` Mogilappagari, Sudheer
2023-03-15 4:24 ` Jakub Kicinski
2023-03-15 7:37 ` Michal Kubecek
2023-03-15 15:37 ` Mogilappagari, Sudheer
2023-03-15 4:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314212334.188ad6e0@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.