From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16F7CC61DA4 for ; Wed, 15 Mar 2023 12:10:25 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 1A162149F for ; Wed, 15 Mar 2023 12:10:24 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 10894986413 for ; Wed, 15 Mar 2023 12:10:24 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 0587C9863FC; Wed, 15 Mar 2023 12:10:24 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id E86E0986402 for ; Wed, 15 Mar 2023 12:10:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: kY0qgAUZN0mynbjVDKguaw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678882216; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=is9D8VteCEMaMmGa4QCOngrvVVD0S6RorAW18QMTc7E=; b=3LnwjV+RyPD65Tg9fywcFPT91Fi5rpiy3mEsFWxtmlQ4M5XXWbFM9vbMxV4lE5i4FD CkCTXRXGliFBxmeB0lZUJPkRnR5fQDkBJTlmJBwWlY8JkyS6vWO/pgXDQytBUIPNOtCp 8ztLq+kUDsAGHU+uX24uTxGKN+T5THKiWxtPwxtWoEmsjHIAga4CEWh8OYF5KI8TlNhi ZxuvNv//GNEJ/EVqbVX+Ys4TZXZgjRxHF39/RInl6yl1ZnZaZyfRZ7xMIACCNfmKdUPh AoQ6d2f4JhClwpFeXIDeIzwXrpRg2B0088PH15BzMFNUKmL2nND2TwKsiJrMaR3P9YzQ w+UA== X-Gm-Message-State: AO0yUKW9iwwOfWUcPzAAhAKW2TUO6VFW63hghDxoe3UPTLihfFJ2VTZG fyZijtGmgufElMtvzftjd/A3vvtTuLLFsSlm9js70JmprmdiNEghz3XJ2nl8ezqpae70fyeZsQN MfJOWpJbVwigkD+VEvqFz1ojIpb4oH65OJw== X-Received: by 2002:a05:600c:4e8f:b0:3ed:32cd:be64 with SMTP id f15-20020a05600c4e8f00b003ed32cdbe64mr2190736wmq.29.1678882216318; Wed, 15 Mar 2023 05:10:16 -0700 (PDT) X-Google-Smtp-Source: AK7set/V7o9FJ5o2qAtEqvDgO12S0YZyowCf4PbjIf5H+RcYr1huxo4b+Vmu2fc9hXPFvzdvp4HMZA== X-Received: by 2002:a05:600c:4e8f:b0:3ed:32cd:be64 with SMTP id f15-20020a05600c4e8f00b003ed32cdbe64mr2190718wmq.29.1678882216062; Wed, 15 Mar 2023 05:10:16 -0700 (PDT) Date: Wed, 15 Mar 2023 08:10:11 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Heng Qi , virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, Jason Wang , Yuri Benditovich , Cornelia Huck , Xuan Zhuo Message-ID: <20230315075954-mutt-send-email-mst@kernel.org> References: <20230306154817.14115-1-hengqi@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote: > If not, for now it may be better to skip vxlan and nvegre as they inherently > have unique outer header UDP src port based on the inner header. So what's left, GRE? GRE is actually different, in that it's not IP at all. So if we are talking about GRE, hash is indeed not calculated at all at the moment, right? And I would say a natural first step for GRE is actually adding a hash type that will support this protocol. How about doing that? It seems like this should be a small step and completely uncontroversial. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46906C61DA4 for ; Wed, 15 Mar 2023 12:10:20 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 7B91042907 for ; Wed, 15 Mar 2023 12:10:19 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 5D3B0986414 for ; Wed, 15 Mar 2023 12:10:19 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 44715986402; Wed, 15 Mar 2023 12:10:19 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 32513986406 for ; Wed, 15 Mar 2023 12:10:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: UNW9y_p2N6-Sp6oHSXzDMA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678882216; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=is9D8VteCEMaMmGa4QCOngrvVVD0S6RorAW18QMTc7E=; b=35vViZ75+9opQ8SCmDIoB9QLIXvWJ7fGq5BgehoqtJnNPRGkdg2V0vL7z+f68SrLyF n7p2r1L++NVH3o8utMowO5KHwBhjgQn+15XYmm7KtIKldvS/8doE9j2fJ4kn48XkA5kA 2s+1eMJGsAHGHFueFS9o137wkSNUweDdqQxjYEuiuTySdo4T/6eZpsJSn0UvDG+feefk NwvJPC4lihDFEmNjVLmpRAK/xE2l0yD0rpCOfkJIwF7K3FT47iIsGcveEh6QVLFRKUGz rsM9Dc2+ukXvvb2iuNTGV+nrXL6KSFzsXsQxd7sFcDbD8EyUZ0Np/j6Hr59ou7XzdpF/ +djw== X-Gm-Message-State: AO0yUKX3Va2eBP40v6UDT3I47LZxGm56vduL7qfrBOZW8E5b/Hb4vkIh IK8p2pzluymHVeH90r4BIbExsV/V2rpRyVtKgyRTu9glFfitQ4zxdHWcpTLU+D8WCVRXMt4adyF FpfXSP0qAvrf57X/5eUrzlxfv0l9+ X-Received: by 2002:a05:600c:4e8f:b0:3ed:32cd:be64 with SMTP id f15-20020a05600c4e8f00b003ed32cdbe64mr2190737wmq.29.1678882216318; Wed, 15 Mar 2023 05:10:16 -0700 (PDT) X-Google-Smtp-Source: AK7set/V7o9FJ5o2qAtEqvDgO12S0YZyowCf4PbjIf5H+RcYr1huxo4b+Vmu2fc9hXPFvzdvp4HMZA== X-Received: by 2002:a05:600c:4e8f:b0:3ed:32cd:be64 with SMTP id f15-20020a05600c4e8f00b003ed32cdbe64mr2190718wmq.29.1678882216062; Wed, 15 Mar 2023 05:10:16 -0700 (PDT) Date: Wed, 15 Mar 2023 08:10:11 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Heng Qi , virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, Jason Wang , Yuri Benditovich , Cornelia Huck , Xuan Zhuo Message-ID: <20230315075954-mutt-send-email-mst@kernel.org> References: <20230306154817.14115-1-hengqi@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote: > If not, for now it may be better to skip vxlan and nvegre as they inherently > have unique outer header UDP src port based on the inner header. So what's left, GRE? GRE is actually different, in that it's not IP at all. So if we are talking about GRE, hash is indeed not calculated at all at the moment, right? And I would say a natural first step for GRE is actually adding a hash type that will support this protocol. How about doing that? It seems like this should be a small step and completely uncontroversial. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org