From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net 1/3] iavf: fix inverted Rx hash condition leading to disabled hash
Date: Wed, 15 Mar 2023 10:49:49 +0200 [thread overview]
Message-ID: <20230315084949.GO36557@unreal> (raw)
In-Reply-To: <20230314174423.1048526-2-anthony.l.nguyen@intel.com>
On Tue, Mar 14, 2023 at 10:44:21AM -0700, Tony Nguyen wrote:
> From: Alexander Lobakin <aleksander.lobakin@intel.com>
>
> Condition, which checks whether the netdev has hashing enabled is
> inverted. Basically, the tagged commit effectively disabled passing flow
> hash from descriptor to skb, unless user *disables* it via Ethtool.
> Commit a876c3ba59a6 ("i40e/i40evf: properly report Rx packet hash")
> fixed this problem, but only for i40e.
> Invert the condition now in iavf and unblock passing hash to skbs again.
>
> Fixes: 857942fd1aa1 ("i40e: Fix Rx hash reported to the stack by our driver")
> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-03-15 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 17:44 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2023-03-14 (iavf) Tony Nguyen
2023-03-14 17:44 ` [PATCH net 1/3] iavf: fix inverted Rx hash condition leading to disabled hash Tony Nguyen
2023-03-15 8:49 ` Leon Romanovsky [this message]
2023-03-14 17:44 ` [PATCH net 2/3] iavf: fix non-tunneled IPv6 UDP packet type and hashing Tony Nguyen
2023-03-15 8:50 ` Leon Romanovsky
2023-03-14 17:44 ` [PATCH net 3/3] iavf: do not track VLAN 0 filters Tony Nguyen
2023-03-15 8:48 ` Leon Romanovsky
2023-03-16 13:15 ` Ahmed Zaki
2023-03-16 20:59 ` Jakub Kicinski
2023-03-16 21:11 ` Ahmed Zaki
2023-03-19 7:20 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315084949.GO36557@unreal \
--to=leon@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.