From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: andersson@kernel.org, lpieralisi@kernel.org, kw@linux.com,
krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_srichara@quicinc.com
Subject: Re: [PATCH v4 05/18] PCI: qcom: Use lower case for hex
Date: Wed, 15 Mar 2023 19:01:23 +0530 [thread overview]
Message-ID: <20230315133106.GA98059@thinkpad> (raw)
In-Reply-To: <6425fcb2-2ce9-0986-ed28-64717dee240a@linaro.org>
On Wed, Mar 15, 2023 at 11:34:13AM +0100, Konrad Dybcio wrote:
>
>
> On 15.03.2023 07:42, Manivannan Sadhasivam wrote:
> > To maintain uniformity, let's use lower case for representing hexadecimal
> > numbers.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> To be fair, preprocessor defines are the only place where uppercase
> hex is widely used
>
I perfer lower hex all over the driver and in this case, I also want to match
what is being done for pcie-qcom-ep so that it helps me in maintaining both
drivers.
Thanks,
Mani
> Konrad
> > drivers/pci/controller/dwc/pcie-qcom.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> > index 926a531fda3a..4179ac973147 100644
> > --- a/drivers/pci/controller/dwc/pcie-qcom.c
> > +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> > @@ -39,17 +39,17 @@
> > #define PARF_PCS_DEEMPH 0x34
> > #define PARF_PCS_SWING 0x38
> > #define PARF_PHY_CTRL 0x40
> > -#define PARF_PHY_REFCLK 0x4C
> > +#define PARF_PHY_REFCLK 0x4c
> > #define PARF_CONFIG_BITS 0x50
> > #define PARF_DBI_BASE_ADDR 0x168
> > -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16C /* Register offset specific to IP ver 2.3.3 */
> > +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16c /* Register offset specific to IP ver 2.3.3 */
> > #define PARF_MHI_CLOCK_RESET_CTRL 0x174
> > #define PARF_AXI_MSTR_WR_ADDR_HALT 0x178
> > -#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1A8
> > -#define PARF_Q2A_FLUSH 0x1AC
> > -#define PARF_LTSSM 0x1B0
> > +#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1a8
> > +#define PARF_Q2A_FLUSH 0x1ac
> > +#define PARF_LTSSM 0x1b0
> > #define PARF_SID_OFFSET 0x234
> > -#define PARF_BDF_TRANSLATE_CFG 0x24C
> > +#define PARF_BDF_TRANSLATE_CFG 0x24c
> > #define PARF_SLV_ADDR_SPACE_SIZE 0x358
> > #define PARF_DEVICE_TYPE 0x1000
> > #define PARF_BDF_TO_SID_TABLE_N 0x2000
> > @@ -60,7 +60,7 @@
> > /* DBI registers */
> > #define AXI_MSTR_RESP_COMP_CTRL0 0x818
> > #define AXI_MSTR_RESP_COMP_CTRL1 0x81c
> > -#define MISC_CONTROL_1_REG 0x8BC
> > +#define MISC_CONTROL_1_REG 0x8bc
> >
> > /* PARF_SYS_CTRL register fields */
> > #define MAC_PHY_POWERDOWN_IN_P2_D_MUX_EN BIT(29)
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-03-15 13:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 6:42 [PATCH v4 00/18] Qcom PCIe cleanups and improvements Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 01/18] PCI: qcom: Remove PCIE20_ prefix from register definitions Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 02/18] PCI: qcom: Sort and group registers and bitfield definitions Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 03/18] PCI: qcom: Use bitfield definitions for register fields Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 04/18] PCI: qcom: Add missing macros " Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 05/18] PCI: qcom: Use lower case for hex Manivannan Sadhasivam
2023-03-15 10:34 ` Konrad Dybcio
2023-03-15 13:31 ` Manivannan Sadhasivam [this message]
2023-03-15 6:42 ` [PATCH v4 06/18] PCI: qcom: Use bulk reset APIs for handling resets for IP rev 2.1.0 Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 07/18] PCI: qcom: Use bulk clock APIs for handling clocks for IP rev 1.0.0 Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 08/18] PCI: qcom: Use bulk clock APIs for handling clocks for IP rev 2.3.2 Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 09/18] PCI: qcom: Use bulk clock APIs for handling clocks for IP rev 2.3.3 Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 10/18] PCI: qcom: Use bulk reset APIs for handling resets " Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 11/18] PCI: qcom: Use bulk reset APIs for handling resets for IP rev 2.4.0 Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 12/18] PCI: qcom: Use macros for defining total no. of clocks & supplies Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 13/18] PCI: qcom: Rename qcom_pcie_config_sid_sm8250() to reflect IP version Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 14/18] dt-bindings: PCI: qcom: Add "mhi" register region to supported SoCs Manivannan Sadhasivam
2023-03-16 7:58 ` Krzysztof Kozlowski
2023-03-15 6:42 ` [PATCH v4 15/18] arm64: dts: qcom: sdm845: Add "mhi" region to the PCIe nodes Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 16/18] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 17/18] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-03-15 6:42 ` [PATCH v4 18/18] PCI: qcom: Expose link transition counts via debugfs Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315133106.GA98059@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_srichara@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.