From: Lee Jones <lee@kernel.org>
To: Deepak R Varma <drv@mailo.com>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_c_skakit@quicinc.com, bjorn.andersson@linaro.org,
dianders@chromium.org, marijn.suijten@somainline.org,
luca@z3ntu.xyz, Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH RESEND] leds: qcom-lpg: Release node reference before returning
Date: Wed, 15 Mar 2023 17:11:22 +0000 [thread overview]
Message-ID: <20230315171122.GF9667@google.com> (raw)
In-Reply-To: <ZAI/6w7k7k0ep1x/@ubun2204.myguest.virtualbox.org>
On Sat, 04 Mar 2023, Deepak R Varma wrote:
> The iterator for_each_available_child_of_node() increments the refcount
> of the child node it is processing. Release such a reference when the
> loop needs to breaks due to en error during its execution.
> Issue identified using for_each_child.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> Please note:
> - The proposed change is compile tested only. I do not have the
> necessary hardware to perform additional testing. Please suggest if there
> is an alternate means available to further test this change.
> - Included authors/experts for this driver for guidance as suggested by
> Lee Jones <lee@kernel.org> and resending the patch.
>
>
> drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
parent reply other threads:[~2023-03-15 17:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <ZAI/6w7k7k0ep1x/@ubun2204.myguest.virtualbox.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315171122.GF9667@google.com \
--to=lee@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=drv@mailo.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=marijn.suijten@somainline.org \
--cc=pavel@ucw.cz \
--cc=quic_c_skakit@quicinc.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.