From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8247CC6FD1F for ; Thu, 16 Mar 2023 16:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9AI0m3qlsOq/Xu4/6VyGKtfDVT7cpSy4UQ+dX5+loiI=; b=oW0bMDbihKBxPZ AVwmyRXm6RXqhrYinCIRlFAOX5kAal98oCj98zVKhvz4mq1fRVw9aLUZZPtZH/dM0PoVA27sJ/EJp W+Gxml8ldb9UeU/NWutHC7ueYICsL+GASCzZBNAkVVGKhoMyokg+SHcIBiBsb7xcddcl23LnKHlEM HOdZyr3GKjRIAZ3k+PBsdfYlkvcuqjSfT0i7x6DWkhd9fQIu6UWWOWE487xGLfeKP2HszEQXSNxAJ /lQp6EYp1xTPGrwnPAfHoMDf67g4xtjjK8E6EbORHZaMrYD6kN6j7HrYXUR4ixIo35n+BNWmhHCGd xn2vJtCWpZ2lyxCtcJVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcq0r-00GvcP-2x; Thu, 16 Mar 2023 15:59:33 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcq0p-00Gvbe-1U; Thu, 16 Mar 2023 15:59:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B2276B8227D; Thu, 16 Mar 2023 15:59:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B26DC433D2; Thu, 16 Mar 2023 15:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678982368; bh=SpHYw01fBJ3nF32f43qZ4/WwYFpX/uEb9i78oEQ5lhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JK4u7ZXcNm441dbdlBWNuU32ZNYXtttVh9SP57UhYaGIl40cM5JjCm59RueEys1q4 IXEHTccNyOLc+YRPbXpo9WEqAdfjXq3Us16IGJQiA4Nb4GTaHepIJqwITWdi79H5SN mjhutjfZKSEe0eHsCZIhJ+fXawv9SgIs7HAsPQsy70J2dKs4G+jN4E08u2yZe7NnA7 XQA96hhwlG7QgIf0DRujcFYOB1lu/7oV05o0V+FShOSaKX1E2RTc+63YpcYIWKWrP1 dE0gkbrMc45ezqWSrOFgcRFe30+gcINyfko2mapMHnbC2WLHLiYHtMkUxY6gIWC/GG y210wGriM9Yqg== Date: Thu, 16 Mar 2023 15:59:23 +0000 From: Lee Jones To: Krzysztof Kozlowski Subject: Re: [PATCH 2/2] mfd: atc260x-i2c: drop of_match_ptr for ID table Message-ID: <20230316155923.GP9667@google.com> References: <20230311111629.251830-1-krzysztof.kozlowski@linaro.org> <20230311111629.251830-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230311111629.251830-2-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_085931_641913_3EE074BE X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, Cristian Ciocaltea , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAxMSBNYXIgMjAyMywgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKCj4gVGhlIGRy aXZlciBjYW4gbWF0Y2ggb25seSB2aWEgdGhlIERUIHRhYmxlIHNvIHRoZSB0YWJsZSBzaG91bGQg YmUgYWx3YXlzCj4gdXNlZCBhbmQgdGhlIG9mX21hdGNoX3B0ciBkb2VzIG5vdCBoYXZlIGFueSBz ZW5zZSAodGhpcyBhbHNvIGFsbG93cyBBQ1BJCj4gbWF0Y2hpbmcgdmlhIFBSUDAwMDEsIGV2ZW4g dGhvdWdoIGl0IG1pZ2h0IG5vdCBiZSByZWxldmFudCBoZXJlKS4KPgo+ICAgZHJpdmVycy9tZmQv YXRjMjYweC1pMmMuYzo0NDozNDogZXJyb3I6IOKAmGF0YzI2MHhfaTJjX29mX21hdGNo4oCZIGRl ZmluZWQgYnV0IG5vdCB1c2VkIFstV2Vycm9yPXVudXNlZC1jb25zdC12YXJpYWJsZT1dCj4KPiBT aWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxp bmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL2F0YzI2MHgtaTJjLmMgfCAyICstCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKQXBwbGllZCwgdGhh bmtzCgotLQpMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59201C6FD1F for ; Thu, 16 Mar 2023 15:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231406AbjCPP7z (ORCPT ); Thu, 16 Mar 2023 11:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231844AbjCPP7r (ORCPT ); Thu, 16 Mar 2023 11:59:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201736C6A4 for ; Thu, 16 Mar 2023 08:59:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C17DAB8227C for ; Thu, 16 Mar 2023 15:59:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B26DC433D2; Thu, 16 Mar 2023 15:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678982368; bh=SpHYw01fBJ3nF32f43qZ4/WwYFpX/uEb9i78oEQ5lhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JK4u7ZXcNm441dbdlBWNuU32ZNYXtttVh9SP57UhYaGIl40cM5JjCm59RueEys1q4 IXEHTccNyOLc+YRPbXpo9WEqAdfjXq3Us16IGJQiA4Nb4GTaHepIJqwITWdi79H5SN mjhutjfZKSEe0eHsCZIhJ+fXawv9SgIs7HAsPQsy70J2dKs4G+jN4E08u2yZe7NnA7 XQA96hhwlG7QgIf0DRujcFYOB1lu/7oV05o0V+FShOSaKX1E2RTc+63YpcYIWKWrP1 dE0gkbrMc45ezqWSrOFgcRFe30+gcINyfko2mapMHnbC2WLHLiYHtMkUxY6gIWC/GG y210wGriM9Yqg== Date: Thu, 16 Mar 2023 15:59:23 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Manivannan Sadhasivam , Cristian Ciocaltea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] mfd: atc260x-i2c: drop of_match_ptr for ID table Message-ID: <20230316155923.GP9667@google.com> References: <20230311111629.251830-1-krzysztof.kozlowski@linaro.org> <20230311111629.251830-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230311111629.251830-2-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Mar 2023, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/mfd/atc260x-i2c.c:44:34: error: ‘atc260x_i2c_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/atc260x-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]