From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FB7C7618A for ; Fri, 17 Mar 2023 07:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbjCQHyO (ORCPT ); Fri, 17 Mar 2023 03:54:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230396AbjCQHyM (ORCPT ); Fri, 17 Mar 2023 03:54:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B1E7C6414; Fri, 17 Mar 2023 00:53:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B03EB8247B; Fri, 17 Mar 2023 07:53:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD5E9C433EF; Fri, 17 Mar 2023 07:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679039613; bh=FHqeoUzoVZtRqyxQJUT/4e1BNJn6xtdz6lPXXgD9+QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vj1ByAAC/ZRd2EHSGZHX0kRv5PTnfDa6eJPKaJ3uRVm4e9ye0AdQngEC1EoNQXbZM hI6/uUPPS3nLTIgu2WNwAyYWplTI1WuagQxQ5I+ERvldOyt6/rK37eHIkbOFLPCSjV yroVnV+uMQJHJSqhEZOx2LquTRtov+j86ySViL0a3PawzrXRMcpkIftj20ZPvn5fxj 2QL6eAz/lClygp5T9Hjs9yZ72iMi7aQBsSH8Q2p1qUAmIJn9NjFglQ/DX2b+lCGReh pr8ObugbtbXKMP/+RUPiBTIWZNX43Snzm0j0Y0JjS4lx2x59oBn2RKz/a0gSxxKk8s bKsCzQLPNrXhA== Date: Fri, 17 Mar 2023 07:53:27 +0000 From: Lee Jones To: ChiaEn Wu Cc: corbet@lwn.net, pavel@ucw.cz, matthias.bgg@gmail.com, andriy.shevchenko@linux.intel.com, jacek.anaszewski@gmail.com, angelogioacchino.delregno@collabora.com, linux-doc@vger.kernel.org, peterwu.pub@gmail.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, szunichen@gmail.com, Alice Chen Subject: Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support Message-ID: <20230317075327.GA9667@google.com> References: <1df93a583c3f508a7158b83b95857e9bce235e1b.1678430444.git.chiaen_wu@richtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1df93a583c3f508a7158b83b95857e9bce235e1b.1678430444.git.chiaen_wu@richtek.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, 10 Mar 2023, ChiaEn Wu wrote: > From: ChiYuan Huang > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > Add support for the MediaTek MT6370 Current Sink Type LED Indicator > driver. It can control four channels current-sink RGB LEDs with 3 modes: > constant current, PWM, and breath mode. > > Acked-by: Jacek Anaszewski > Co-developed-by: Alice Chen > Signed-off-by: Alice Chen > Signed-off-by: ChiYuan Huang > Signed-off-by: ChiaEn Wu > --- > v18: > - Rename 'MT6370_VENID_MASK' to more human readable > 'MT6370_VENDOR_ID_MASK' > - Define the const number vid. > - Unwrap each line by 100 chars limit. > - Remove the redudant space in 'mt6370_gen_breath_pattern()' comment for > patterh data allocation. > - Define a sub function 'mt6370_assign_multicolor_info()' to tidy up > 'mt6370_init_led_properties()' for multicolor case. > - Define a sub function 'mt6370_multicolor_led_register' to tidy up > 'mt6370_led_register()' for multicolor case. > - Refine 'fwnode_handle_put' in probe function with 'goto'. > --- > drivers/leds/rgb/Kconfig | 13 + > drivers/leds/rgb/Makefile | 1 + > drivers/leds/rgb/leds-mt6370-rgb.c | 1010 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 1024 insertions(+) > create mode 100644 drivers/leds/rgb/leds-mt6370-rgb.c Applied, thanks -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42EE1C6FD1D for ; Fri, 17 Mar 2023 07:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hN0xz8BECw1wR5S2OlBvSh/98P0A3p9V5yIJ5fCt9n4=; b=21hRAckyxPEguI wNFf3HCEvYDHwwNqK7HKQdaHZzaWf/H4xzkopmnX3V9q6rkbn4ySoF2Le6NKG93idwbJGND3le0jA qmMCsQGMZY17oB2heUU5UtGcldbTuyRlLGm2jz+Obx/aGhVhvDwZ065DCUxiCCNLu1K3eY9+JR2l7 sGbGIGUoNm7bDIG51LoBeVfugw31MrMySr64fWg/C56lDwYa6r3RarhVVWQsnNyfQgjwkmQ5pJ/gr B0PTck8/AxPDN4LCk8w8E4we4vWChi/X2z28NRzAebdxALgqKmjXbMpXXC3k9CukEqpes7T+4ch1J 4RTQTMXLLZcrHchYxq/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd4u9-001M8l-2p; Fri, 17 Mar 2023 07:53:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd4u7-001M7e-14; Fri, 17 Mar 2023 07:53:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46CCC621CF; Fri, 17 Mar 2023 07:53:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD5E9C433EF; Fri, 17 Mar 2023 07:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679039613; bh=FHqeoUzoVZtRqyxQJUT/4e1BNJn6xtdz6lPXXgD9+QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vj1ByAAC/ZRd2EHSGZHX0kRv5PTnfDa6eJPKaJ3uRVm4e9ye0AdQngEC1EoNQXbZM hI6/uUPPS3nLTIgu2WNwAyYWplTI1WuagQxQ5I+ERvldOyt6/rK37eHIkbOFLPCSjV yroVnV+uMQJHJSqhEZOx2LquTRtov+j86ySViL0a3PawzrXRMcpkIftj20ZPvn5fxj 2QL6eAz/lClygp5T9Hjs9yZ72iMi7aQBsSH8Q2p1qUAmIJn9NjFglQ/DX2b+lCGReh pr8ObugbtbXKMP/+RUPiBTIWZNX43Snzm0j0Y0JjS4lx2x59oBn2RKz/a0gSxxKk8s bKsCzQLPNrXhA== Date: Fri, 17 Mar 2023 07:53:27 +0000 From: Lee Jones To: ChiaEn Wu Cc: corbet@lwn.net, pavel@ucw.cz, matthias.bgg@gmail.com, andriy.shevchenko@linux.intel.com, jacek.anaszewski@gmail.com, angelogioacchino.delregno@collabora.com, linux-doc@vger.kernel.org, peterwu.pub@gmail.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, szunichen@gmail.com, Alice Chen Subject: Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support Message-ID: <20230317075327.GA9667@google.com> References: <1df93a583c3f508a7158b83b95857e9bce235e1b.1678430444.git.chiaen_wu@richtek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1df93a583c3f508a7158b83b95857e9bce235e1b.1678430444.git.chiaen_wu@richtek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_005335_411135_2EC1D5B1 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMCBNYXIgMjAyMywgQ2hpYUVuIFd1IHdyb3RlOgoKPiBGcm9tOiBDaGlZdWFuIEh1 YW5nIDxjeV9odWFuZ0ByaWNodGVrLmNvbT4KPgo+IFRoZSBNZWRpYVRlayBNVDYzNzAgaXMgYSBo aWdobHktaW50ZWdyYXRlZCBzbWFydCBwb3dlciBtYW5hZ2VtZW50IElDLAo+IHdoaWNoIGluY2x1 ZGVzIGEgc2luZ2xlIGNlbGwgTGktSW9uL0xpLVBvbHltZXIgc3dpdGNoaW5nIGJhdHRlcnkKPiBj aGFyZ2VyLCBhIFVTQiBUeXBlLUMgJiBQb3dlciBEZWxpdmVyeSAoUEQpIGNvbnRyb2xsZXIsIGR1 YWwKPiBGbGFzaCBMRUQgY3VycmVudCBzb3VyY2VzLCBhIFJHQiBMRUQgZHJpdmVyLCBhIGJhY2ts aWdodCBXTEVEIGRyaXZlciwKPiBhIGRpc3BsYXkgYmlhcyBkcml2ZXIgYW5kIGEgZ2VuZXJhbCBM RE8gZm9yIHBvcnRhYmxlIGRldmljZXMuCj4KPiBBZGQgc3VwcG9ydCBmb3IgdGhlIE1lZGlhVGVr IE1UNjM3MCBDdXJyZW50IFNpbmsgVHlwZSBMRUQgSW5kaWNhdG9yCj4gZHJpdmVyLiBJdCBjYW4g Y29udHJvbCBmb3VyIGNoYW5uZWxzIGN1cnJlbnQtc2luayBSR0IgTEVEcyB3aXRoIDMgbW9kZXM6 Cj4gY29uc3RhbnQgY3VycmVudCwgUFdNLCBhbmQgYnJlYXRoIG1vZGUuCj4KPiBBY2tlZC1ieTog SmFjZWsgQW5hc3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+Cj4gQ28tZGV2ZWxv cGVkLWJ5OiBBbGljZSBDaGVuIDxhbGljZV9jaGVuQHJpY2h0ZWsuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IEFsaWNlIENoZW4gPGFsaWNlX2NoZW5AcmljaHRlay5jb20+Cj4gU2lnbmVkLW9mZi1ieTog Q2hpWXVhbiBIdWFuZyA8Y3lfaHVhbmdAcmljaHRlay5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQ2hp YUVuIFd1IDxjaGlhZW5fd3VAcmljaHRlay5jb20+Cj4gLS0tCj4gdjE4Ogo+IC0gUmVuYW1lICdN VDYzNzBfVkVOSURfTUFTSycgdG8gbW9yZSBodW1hbiByZWFkYWJsZQo+ICAgJ01UNjM3MF9WRU5E T1JfSURfTUFTSycKPiAtIERlZmluZSB0aGUgY29uc3QgbnVtYmVyIHZpZC4KPiAtIFVud3JhcCBl YWNoIGxpbmUgYnkgMTAwIGNoYXJzIGxpbWl0Lgo+IC0gUmVtb3ZlIHRoZSByZWR1ZGFudCBzcGFj ZSBpbiAnbXQ2MzcwX2dlbl9icmVhdGhfcGF0dGVybigpJyBjb21tZW50IGZvcgo+ICAgcGF0dGVy aCBkYXRhIGFsbG9jYXRpb24uCj4gLSBEZWZpbmUgYSBzdWIgZnVuY3Rpb24gJ210NjM3MF9hc3Np Z25fbXVsdGljb2xvcl9pbmZvKCknIHRvIHRpZHkgdXAKPiAgICdtdDYzNzBfaW5pdF9sZWRfcHJv cGVydGllcygpJyBmb3IgbXVsdGljb2xvciBjYXNlLgo+IC0gRGVmaW5lIGEgc3ViIGZ1bmN0aW9u ICdtdDYzNzBfbXVsdGljb2xvcl9sZWRfcmVnaXN0ZXInIHRvIHRpZHkgdXAKPiAgICdtdDYzNzBf bGVkX3JlZ2lzdGVyKCknIGZvciBtdWx0aWNvbG9yIGNhc2UuCj4gLSBSZWZpbmUgJ2Z3bm9kZV9o YW5kbGVfcHV0JyBpbiBwcm9iZSBmdW5jdGlvbiB3aXRoICdnb3RvJy4KPiAtLS0KPiAgZHJpdmVy cy9sZWRzL3JnYi9LY29uZmlnICAgICAgICAgICB8ICAgMTMgKwo+ICBkcml2ZXJzL2xlZHMvcmdi L01ha2VmaWxlICAgICAgICAgIHwgICAgMSArCj4gIGRyaXZlcnMvbGVkcy9yZ2IvbGVkcy1tdDYz NzAtcmdiLmMgfCAxMDEwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAz IGZpbGVzIGNoYW5nZWQsIDEwMjQgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQg ZHJpdmVycy9sZWRzL3JnYi9sZWRzLW10NjM3MC1yZ2IuYwoKQXBwbGllZCwgdGhhbmtzCgotLQpM ZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK