From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EAB7C6FD1D for ; Fri, 17 Mar 2023 21:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbjCQVBL (ORCPT ); Fri, 17 Mar 2023 17:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229798AbjCQVBJ (ORCPT ); Fri, 17 Mar 2023 17:01:09 -0400 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C581AF74C; Fri, 17 Mar 2023 14:01:03 -0700 (PDT) Received: by mail-il1-f174.google.com with SMTP id i19so3390445ila.10; Fri, 17 Mar 2023 14:01:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679086863; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o9EiAA4lskfU5fZwDEEjXMLNpA6IiIed6Ih+9/z1fuw=; b=pYGK199wffHhYmNOY1w5cj8FvokhOIrEL7oCDPDdseRtFcpl0S9rFpcvV6QcnVRurL 0IKBevJHqWtvVEpc7HU6U494/dsONTa7AzKWYU3/SeGCrXuYR08qc/+raYVEwdojFhdv V7kCqI3bI5eBwIOQjtwNHhNtlt890ar4gK9PVUdy+HI9mHcoco9EHdmBKxVROkJHFO+B +2S42fNf+WnL+A3y/ESMx6URIYXDXoHGD9UKxW3OWuRJvxgOxilNauFCL7/RbmuRtlHG MPSOOGCFRji96erE3RlD0qi/QomWOn1scJ73ZJ+BvlD1vaeUwVruEy1/UacKm2vuchcU h61Q== X-Gm-Message-State: AO0yUKWr2xB13SZzoxpisf+mW3WezSA/yhONZDHZUvSvj0Bua0WM0Zof 49Xm1/yfYqYllMU72zf/Qg== X-Google-Smtp-Source: AK7set+Toby4I08PfKs5Vv4ur/RProzX9zB/qL38RB1Lpcl0LMr7CHYESvkyeKXSl8neA8xDhSDJCg== X-Received: by 2002:a92:c9d2:0:b0:317:9818:ea49 with SMTP id k18-20020a92c9d2000000b003179818ea49mr35659ilq.2.1679086863038; Fri, 17 Mar 2023 14:01:03 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id s20-20020a056e0210d400b003170014ee5bsm881484ilj.21.2023.03.17.14.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:00:57 -0700 (PDT) Received: (nullmailer pid 2794739 invoked by uid 1000); Fri, 17 Mar 2023 21:00:54 -0000 Date: Fri, 17 Mar 2023 16:00:54 -0500 From: Rob Herring To: Chia-Wei Wang Cc: vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, gregkh@linuxfoundation.org, jirislaby@kernel.org, pmenzel@molgen.mpg.de, ilpo.jarvinen@linux.intel.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v2 3/5] dmaengine: aspeed: Add AST2600 UART DMA driver Message-ID: <20230317210054.GA2790192-robh@kernel.org> References: <20230314021817.30446-1-chiawei_wang@aspeedtech.com> <20230314021817.30446-4-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314021817.30446-4-chiawei_wang@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Tue, Mar 14, 2023 at 10:18:15AM +0800, Chia-Wei Wang wrote: > Aspeed AST2600 UART DMA (UDMA) includes 14 channels for the > DMA transmission and recevie of each UART devices. > > Signed-off-by: Chia-Wei Wang > --- > drivers/dma/Kconfig | 9 + > drivers/dma/Makefile | 1 + > drivers/dma/ast2600-udma.c | 528 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 538 insertions(+) > create mode 100644 drivers/dma/ast2600-udma.c > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index fb7073fc034f..c35f87dbafd9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -748,6 +748,15 @@ config XILINX_ZYNQMP_DPDMA > driver provides the dmaengine required by the DisplayPort subsystem > display driver. > > +config ASPEED_AST2600_UDMA > + bool "Aspeed AST2600 UDMA support" > + depends on ARCH_ASPEED || COMPILE_TEST > + help > + Enable support for Aspeed AST2600 UART DMA. Select this option if you > + have a AST2600 SoC integrated system. The driver provides the UART DMA > + support with the dmaengine subsystem, which can be leveraged by generic > + 8250 serial drivers. > + > # driver files > source "drivers/dma/bestcomm/Kconfig" > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile > index a4fd1ce29510..6cbacebcdcab 100644 > --- a/drivers/dma/Makefile > +++ b/drivers/dma/Makefile > @@ -81,6 +81,7 @@ obj-$(CONFIG_XGENE_DMA) += xgene-dma.o > obj-$(CONFIG_ST_FDMA) += st_fdma.o > obj-$(CONFIG_FSL_DPAA2_QDMA) += fsl-dpaa2-qdma/ > obj-$(CONFIG_INTEL_LDMA) += lgm/ > +obj-$(CONFIG_ASPEED_AST2600_UDMA) += ast2600-udma.o > > obj-y += mediatek/ > obj-y += qcom/ > diff --git a/drivers/dma/ast2600-udma.c b/drivers/dma/ast2600-udma.c > new file mode 100644 > index 000000000000..ff678724f9d9 > --- /dev/null > +++ b/drivers/dma/ast2600-udma.c > @@ -0,0 +1,528 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) ASPEED Technology Inc. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include You probably don't need these as you should use platform APIs instead. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Fri, 17 Mar 2023 16:00:54 -0500 Subject: [PATCH v2 3/5] dmaengine: aspeed: Add AST2600 UART DMA driver In-Reply-To: <20230314021817.30446-4-chiawei_wang@aspeedtech.com> References: <20230314021817.30446-1-chiawei_wang@aspeedtech.com> <20230314021817.30446-4-chiawei_wang@aspeedtech.com> Message-ID: <20230317210054.GA2790192-robh@kernel.org> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Mar 14, 2023 at 10:18:15AM +0800, Chia-Wei Wang wrote: > Aspeed AST2600 UART DMA (UDMA) includes 14 channels for the > DMA transmission and recevie of each UART devices. > > Signed-off-by: Chia-Wei Wang > --- > drivers/dma/Kconfig | 9 + > drivers/dma/Makefile | 1 + > drivers/dma/ast2600-udma.c | 528 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 538 insertions(+) > create mode 100644 drivers/dma/ast2600-udma.c > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index fb7073fc034f..c35f87dbafd9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -748,6 +748,15 @@ config XILINX_ZYNQMP_DPDMA > driver provides the dmaengine required by the DisplayPort subsystem > display driver. > > +config ASPEED_AST2600_UDMA > + bool "Aspeed AST2600 UDMA support" > + depends on ARCH_ASPEED || COMPILE_TEST > + help > + Enable support for Aspeed AST2600 UART DMA. Select this option if you > + have a AST2600 SoC integrated system. The driver provides the UART DMA > + support with the dmaengine subsystem, which can be leveraged by generic > + 8250 serial drivers. > + > # driver files > source "drivers/dma/bestcomm/Kconfig" > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile > index a4fd1ce29510..6cbacebcdcab 100644 > --- a/drivers/dma/Makefile > +++ b/drivers/dma/Makefile > @@ -81,6 +81,7 @@ obj-$(CONFIG_XGENE_DMA) += xgene-dma.o > obj-$(CONFIG_ST_FDMA) += st_fdma.o > obj-$(CONFIG_FSL_DPAA2_QDMA) += fsl-dpaa2-qdma/ > obj-$(CONFIG_INTEL_LDMA) += lgm/ > +obj-$(CONFIG_ASPEED_AST2600_UDMA) += ast2600-udma.o > > obj-y += mediatek/ > obj-y += qcom/ > diff --git a/drivers/dma/ast2600-udma.c b/drivers/dma/ast2600-udma.c > new file mode 100644 > index 000000000000..ff678724f9d9 > --- /dev/null > +++ b/drivers/dma/ast2600-udma.c > @@ -0,0 +1,528 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) ASPEED Technology Inc. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include You probably don't need these as you should use platform APIs instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E049C76195 for ; Fri, 17 Mar 2023 21:01:42 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Pdc4h6prlz3f4n for ; Sat, 18 Mar 2023 08:01:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.166.170; helo=mail-il1-f170.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Pdc413sY2z2yV5; Sat, 18 Mar 2023 08:01:05 +1100 (AEDT) Received: by mail-il1-f170.google.com with SMTP id l15so1853885ilv.4; Fri, 17 Mar 2023 14:01:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679086863; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o9EiAA4lskfU5fZwDEEjXMLNpA6IiIed6Ih+9/z1fuw=; b=cspWpuegp30BG+nrLAVKvqXp/+ETLMeDLHyoJjgvtnVrW4xaRGlZSFv4iU6M3WRhSP CW+PjZKxIg75B4mEH2f5vxAuvF5Pc7D58cex3lXtE9TwZ5HlZaFLuYFg3B4uxP3O0guZ isew3NqcPAZpd4Kq0jqhvqkMPDWEVBn5yvhd5423grc6wzvxdE2zJyYbnkGJt58LqMCb L5n1J0yw3/YkmMJy99HI8y4n2X+ZhXo633uGmWOBRb8W59FDelyGI+GsYbI/l7K8S9bG PrqkWeGF2IVyHofZ/lgfAd0E3x4HcjgSb+o5MXJ2U/mslOhz9nA8vMRL0exSAJLDPCW7 XYjg== X-Gm-Message-State: AO0yUKUVAzd7Rcsr5mNSTHIMaREkSEx+9QQXn7A9rSEFpsk3u+vvW5wn qVW2duWpZ+4i1IdfnrkEvw== X-Google-Smtp-Source: AK7set+Toby4I08PfKs5Vv4ur/RProzX9zB/qL38RB1Lpcl0LMr7CHYESvkyeKXSl8neA8xDhSDJCg== X-Received: by 2002:a92:c9d2:0:b0:317:9818:ea49 with SMTP id k18-20020a92c9d2000000b003179818ea49mr35659ilq.2.1679086863038; Fri, 17 Mar 2023 14:01:03 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id s20-20020a056e0210d400b003170014ee5bsm881484ilj.21.2023.03.17.14.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:00:57 -0700 (PDT) Received: (nullmailer pid 2794739 invoked by uid 1000); Fri, 17 Mar 2023 21:00:54 -0000 Date: Fri, 17 Mar 2023 16:00:54 -0500 From: Rob Herring To: Chia-Wei Wang Subject: Re: [PATCH v2 3/5] dmaengine: aspeed: Add AST2600 UART DMA driver Message-ID: <20230317210054.GA2790192-robh@kernel.org> References: <20230314021817.30446-1-chiawei_wang@aspeedtech.com> <20230314021817.30446-4-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314021817.30446-4-chiawei_wang@aspeedtech.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmenzel@molgen.mpg.de, linux-serial@vger.kernel.org, linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, dmaengine@vger.kernel.org, ilpo.jarvinen@linux.intel.com, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, Mar 14, 2023 at 10:18:15AM +0800, Chia-Wei Wang wrote: > Aspeed AST2600 UART DMA (UDMA) includes 14 channels for the > DMA transmission and recevie of each UART devices. > > Signed-off-by: Chia-Wei Wang > --- > drivers/dma/Kconfig | 9 + > drivers/dma/Makefile | 1 + > drivers/dma/ast2600-udma.c | 528 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 538 insertions(+) > create mode 100644 drivers/dma/ast2600-udma.c > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index fb7073fc034f..c35f87dbafd9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -748,6 +748,15 @@ config XILINX_ZYNQMP_DPDMA > driver provides the dmaengine required by the DisplayPort subsystem > display driver. > > +config ASPEED_AST2600_UDMA > + bool "Aspeed AST2600 UDMA support" > + depends on ARCH_ASPEED || COMPILE_TEST > + help > + Enable support for Aspeed AST2600 UART DMA. Select this option if you > + have a AST2600 SoC integrated system. The driver provides the UART DMA > + support with the dmaengine subsystem, which can be leveraged by generic > + 8250 serial drivers. > + > # driver files > source "drivers/dma/bestcomm/Kconfig" > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile > index a4fd1ce29510..6cbacebcdcab 100644 > --- a/drivers/dma/Makefile > +++ b/drivers/dma/Makefile > @@ -81,6 +81,7 @@ obj-$(CONFIG_XGENE_DMA) += xgene-dma.o > obj-$(CONFIG_ST_FDMA) += st_fdma.o > obj-$(CONFIG_FSL_DPAA2_QDMA) += fsl-dpaa2-qdma/ > obj-$(CONFIG_INTEL_LDMA) += lgm/ > +obj-$(CONFIG_ASPEED_AST2600_UDMA) += ast2600-udma.o > > obj-y += mediatek/ > obj-y += qcom/ > diff --git a/drivers/dma/ast2600-udma.c b/drivers/dma/ast2600-udma.c > new file mode 100644 > index 000000000000..ff678724f9d9 > --- /dev/null > +++ b/drivers/dma/ast2600-udma.c > @@ -0,0 +1,528 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) ASPEED Technology Inc. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include You probably don't need these as you should use platform APIs instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A80A9C6FD1D for ; Fri, 17 Mar 2023 21:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LnBh6c69Ua3bO9qS+sbTfTrCnYTyAFkfGe635GXb7Mo=; b=utQOb3ZgPED1mH sybnECPosJVACj5eIQ9N+RqpKKgUaJRY47SZ1GMwgVt3nM07xnnr2YQ/F+8OE8o/oGT3APXGqE5sZ jZcAVngIwEy0ZCc6fMy//Pa5+ZqtAuFIoQECinItT//PIWUipUEty8GuizwpQOkdeIOq5JsKl0U0b QH/PQYGso0illhiAucmptOF6iKRIXvMsbTKMk0vbKWahR93JvkHdz4FXpM+RAdyVGH1upRt6V6Bj8 3ys6OKln42s5OGR9oQVRUltDcg3+WtG3Dvz4rGZ6avUrvDVYKi4kruGtK76NaPpPuo0L9az7mVPIX hzs6XICMK/sv1nFtZGng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdHCJ-003O4l-0A; Fri, 17 Mar 2023 21:01:11 +0000 Received: from mail-il1-f171.google.com ([209.85.166.171]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdHCG-003O2n-1j for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 21:01:09 +0000 Received: by mail-il1-f171.google.com with SMTP id r4so3407136ila.2 for ; Fri, 17 Mar 2023 14:01:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679086863; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o9EiAA4lskfU5fZwDEEjXMLNpA6IiIed6Ih+9/z1fuw=; b=V37j5Dvm/9jbzBfWhT75NnbCTi/+Ri6wfhZzXZ880RkOfKok6qGyGvgmJDZwrxTLd8 90vXqNEk/yR1/oaYD8ahyV0y2xfyMkGMILI1qX8KxeUGMIJX5ApP7ys/lE/DPoJwrXsr 47ZB9UhHmm0GF+Dw6c9vVqM77VVHnEJgsOd5NN3Xh7xqy7XcpF2kgiSzgCHSWTFLb1XU 0Zqnadob80QtM3p/pic8RZHNUumtTtqjSc6s8agMcOW4ER/BqLWoNCe3yS7Cb+jBR+xh IhcDaLpBVK/CnFvDmvLFdOK3XKagkowzt18PudE+LdVTKfv3QG1xlZGfYF+67Z8viH5t bFmg== X-Gm-Message-State: AO0yUKWVXtBXn8cFwqEedhme1T2vlwntLVP9ckVfhREDfZx33nWpyDXP v33Sibqn5XckcGhiQiLnHQ== X-Google-Smtp-Source: AK7set+Toby4I08PfKs5Vv4ur/RProzX9zB/qL38RB1Lpcl0LMr7CHYESvkyeKXSl8neA8xDhSDJCg== X-Received: by 2002:a92:c9d2:0:b0:317:9818:ea49 with SMTP id k18-20020a92c9d2000000b003179818ea49mr35659ilq.2.1679086863038; Fri, 17 Mar 2023 14:01:03 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id s20-20020a056e0210d400b003170014ee5bsm881484ilj.21.2023.03.17.14.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:00:57 -0700 (PDT) Received: (nullmailer pid 2794739 invoked by uid 1000); Fri, 17 Mar 2023 21:00:54 -0000 Date: Fri, 17 Mar 2023 16:00:54 -0500 From: Rob Herring To: Chia-Wei Wang Cc: vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, gregkh@linuxfoundation.org, jirislaby@kernel.org, pmenzel@molgen.mpg.de, ilpo.jarvinen@linux.intel.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v2 3/5] dmaengine: aspeed: Add AST2600 UART DMA driver Message-ID: <20230317210054.GA2790192-robh@kernel.org> References: <20230314021817.30446-1-chiawei_wang@aspeedtech.com> <20230314021817.30446-4-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314021817.30446-4-chiawei_wang@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_140108_574110_2EFC9639 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 10:18:15AM +0800, Chia-Wei Wang wrote: > Aspeed AST2600 UART DMA (UDMA) includes 14 channels for the > DMA transmission and recevie of each UART devices. > > Signed-off-by: Chia-Wei Wang > --- > drivers/dma/Kconfig | 9 + > drivers/dma/Makefile | 1 + > drivers/dma/ast2600-udma.c | 528 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 538 insertions(+) > create mode 100644 drivers/dma/ast2600-udma.c > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index fb7073fc034f..c35f87dbafd9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -748,6 +748,15 @@ config XILINX_ZYNQMP_DPDMA > driver provides the dmaengine required by the DisplayPort subsystem > display driver. > > +config ASPEED_AST2600_UDMA > + bool "Aspeed AST2600 UDMA support" > + depends on ARCH_ASPEED || COMPILE_TEST > + help > + Enable support for Aspeed AST2600 UART DMA. Select this option if you > + have a AST2600 SoC integrated system. The driver provides the UART DMA > + support with the dmaengine subsystem, which can be leveraged by generic > + 8250 serial drivers. > + > # driver files > source "drivers/dma/bestcomm/Kconfig" > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile > index a4fd1ce29510..6cbacebcdcab 100644 > --- a/drivers/dma/Makefile > +++ b/drivers/dma/Makefile > @@ -81,6 +81,7 @@ obj-$(CONFIG_XGENE_DMA) += xgene-dma.o > obj-$(CONFIG_ST_FDMA) += st_fdma.o > obj-$(CONFIG_FSL_DPAA2_QDMA) += fsl-dpaa2-qdma/ > obj-$(CONFIG_INTEL_LDMA) += lgm/ > +obj-$(CONFIG_ASPEED_AST2600_UDMA) += ast2600-udma.o > > obj-y += mediatek/ > obj-y += qcom/ > diff --git a/drivers/dma/ast2600-udma.c b/drivers/dma/ast2600-udma.c > new file mode 100644 > index 000000000000..ff678724f9d9 > --- /dev/null > +++ b/drivers/dma/ast2600-udma.c > @@ -0,0 +1,528 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) ASPEED Technology Inc. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include You probably don't need these as you should use platform APIs instead. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel