From: Jakub Kicinski <kuba@kernel.org>
To: Liang He <windhl@126.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] ethernet: sun: add check for the mdesc_grab()
Date: Fri, 17 Mar 2023 22:29:44 -0700 [thread overview]
Message-ID: <20230317222944.64f66377@kernel.org> (raw)
In-Reply-To: <20230315060021.1741151-1-windhl@126.com>
On Wed, 15 Mar 2023 14:00:21 +0800 Liang He wrote:
> hp = mdesc_grab();
>
> + if (!hp)
> + return -ENODEV;
no empty line between the function call and error check, please
next prev parent reply other threads:[~2023-03-18 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 6:00 [PATCH] ethernet: sun: add check for the mdesc_grab() Liang He
2023-03-15 9:15 ` Piotr Raczynski
2023-03-17 7:50 ` patchwork-bot+netdevbpf
2023-03-18 5:29 ` Jakub Kicinski [this message]
2023-03-19 11:30 ` Liang He
2023-03-19 18:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317222944.64f66377@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.