From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Josef Bacik <josef@toxicpanda.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
David Sterba <dsterba@suse.com>
Subject: Re: [PATCH] block: Support splitting REQ_OP_ZONE_APPEND bios
Date: Sat, 18 Mar 2023 07:25:10 +0100 [thread overview]
Message-ID: <20230318062510.GA24880@lst.de> (raw)
In-Reply-To: <20230317195036.1743712-1-bvanassche@acm.org>
On Fri, Mar 17, 2023 at 12:50:35PM -0700, Bart Van Assche wrote:
> Make it easier for filesystems to submit zone append bios that exceed
> the block device limits by adding support for REQ_OP_ZONE_APPEND in
> bio_split(). See also commit 0512a75b98f8 ("block: Introduce
> REQ_OP_ZONE_APPEND").
You can't do that. ZONE_APPEND reports the written sector in bi_sector,
so it can't be split.
> This patch is a bug fix for commit d5e4377d5051 because that commit
> introduces a call to bio_split() for zone append bios without adding
> support for splitting REQ_OP_ZONE_APPEND bios in bio_split().
That commit never splits ZONE_APPEND bios, and it pre-splits bios
about to become ZONE_APPEND bios specifically using bio_split_rw
instead of bio_split.
prev parent reply other threads:[~2023-03-18 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 19:50 [PATCH] block: Support splitting REQ_OP_ZONE_APPEND bios Bart Van Assche
2023-03-17 22:39 ` Damien Le Moal
2023-03-18 0:09 ` Bart Van Assche
2023-03-18 2:21 ` Damien Le Moal
2023-03-20 17:17 ` Bart Van Assche
2023-03-18 6:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318062510.GA24880@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.