From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: John Keeping <john@metanate.com>, Takashi Iwai <tiwai@suse.com>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Fix recursive locking on XRUN
Date: Sat, 18 Mar 2023 19:59:28 +0900 [thread overview]
Message-ID: <20230318105928.GA87969@workstation> (raw)
In-Reply-To: <20230318002005.GA84781@workstation>
On Sat, Mar 18, 2023 at 09:20:05AM +0900, Takashi Sakamoto wrote:
> 1. Failure at tasklet for URB completion
>
> It is softIRQ context. The stream lock is not acquired. It doesn't
> matter to call current XRUN API.
>
> 2. Failure at PCM operation called by ALSA PCM application
>
> It is process context. The stream lock is acquired before calling driver
> code. When detecting any type of failure, driver code stores the state.
> Then .pointer callback should return SNDRV_PCM_IOCTL_HWSYNC refering to
> the state.
Oops. I did copy-and-paste mistake here... It should be
SNDRV_PCM_POS_XRUN instead of SNDRV_PCM_IOCTL_HWSYNC...
Regards
Takashi Sakamoto
next prev parent reply other threads:[~2023-03-18 11:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 19:51 [PATCH] ALSA: usb-audio: Fix recursive locking on XRUN John Keeping
2023-03-17 19:51 ` John Keeping
2023-03-18 0:20 ` Takashi Sakamoto
2023-03-18 10:59 ` Takashi Sakamoto [this message]
2023-03-19 3:28 ` Takashi Sakamoto
2023-03-19 7:57 ` Takashi Iwai
2023-03-19 9:15 ` Takashi Iwai
2023-03-20 12:04 ` John Keeping
2023-03-20 12:04 ` John Keeping
2023-03-20 14:28 ` Takashi Iwai
2023-03-20 14:28 ` Takashi Iwai
2023-03-18 2:29 ` kernel test robot
2023-03-18 5:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318105928.GA87969@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=john@metanate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.