Re: [RFC v2 3/3] file, epoll: Implement do_replace() and eventpoll_replace()

[kernel test robot <lkp@intel.com>]

Hi aloktiagi,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on kees/for-next/seccomp]
[also build test ERROR on kees/for-next/pstore kees/for-next/kspp linus/master v6.3-rc2 next-20230317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/aloktiagi/file-allow-callers-to-free-the-old-file-descriptor-after-dup2/20230318-140457
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/seccomp
patch link:    https://lore.kernel.org/r/20230318060248.848099-3-aloktiagi%40gmail.com
patch subject: [RFC v2 3/3] file, epoll: Implement do_replace() and eventpoll_replace()
config: nios2-defconfig (https://download.01.org/0day-ci/archive/20230318/202303181529.ck2N6fZd-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1d2d8d35be8559070716cd4dcb1e6c5da2c67cfd
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review aloktiagi/file-allow-callers-to-free-the-old-file-descriptor-after-dup2/20230318-140457
        git checkout 1d2d8d35be8559070716cd4dcb1e6c5da2c67cfd
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303181529.ck2N6fZd-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/file.c: In function 'do_replace':
>> fs/file.c:1176:31: error: 'struct file' has no member named 'f_ep'; did you mean 'f_op'?
    1176 |         if (fdfile && fdfile->f_ep) {
         |                               ^~~~
         |                               f_op
>> fs/file.c:1177:17: error: implicit declaration of function 'eventpoll_replace'; did you mean 'eventpoll_release'? [-Werror=implicit-function-declaration]
    1177 |                 eventpoll_replace(fdfile, file);
         |                 ^~~~~~~~~~~~~~~~~
         |                 eventpoll_release
   cc1: some warnings being treated as errors


vim +1176 fs/file.c

  1159	
  1160	static void do_replace(struct files_struct *files,
  1161	        struct file *file, unsigned fd, struct file *fdfile)
  1162	{
  1163		unsigned n = 0;
  1164		struct replace_filefd ffd = {
  1165			.files = files,
  1166			.fd = fd,
  1167			.fdfile = fdfile,
  1168			.file = file
  1169		};
  1170	
  1171		/*
  1172		 * Check if the file referenced by the fd number is linked to the epoll
  1173		 * interface. If yes, replace the reference with the received file in
  1174		 * the epoll interface.
  1175		 */
> 1176		if (fdfile && fdfile->f_ep) {
> 1177			eventpoll_replace(fdfile, file);
  1178		}
  1179		/*
  1180		 * Install the received file in the file descriptor table for all fd
  1181		 * numbers referencing the same file as the one we are trying to
  1182		 * replace. Do not install it for the fd number received since that is
  1183		 * handled in do_dup2()
  1184		 */
  1185		iterate_fd_locked(files, n, do_replace_fd_array, &ffd);
  1186	}
  1187	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests