All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [lunn:v6.2.0-net-next-phy-leds 20/28] drivers/net/phy/phy_device.c:3084:21: error: 'struct led_classdev' has no member named 'hw_control_configure'
Date: Sat, 18 Mar 2023 15:39:26 +0800	[thread overview]
Message-ID: <202303181550.Gc0shbAp-lkp@intel.com> (raw)

tree:   https://github.com/lunn/linux.git v6.2.0-net-next-phy-leds
head:   8a9b1a5ad5dd0e48585009020088a2ee5bdd6688
commit: bbade5cbf97bd9260cd0c9cf17699127c2b815af [20/28] net: phy: phy_device: Call into the PHY driver to set LED offload
config: ia64-randconfig-r001-20230312 (https://download.01.org/0day-ci/archive/20230318/202303181550.Gc0shbAp-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/lunn/linux/commit/bbade5cbf97bd9260cd0c9cf17699127c2b815af
        git remote add lunn https://github.com/lunn/linux.git
        git fetch --no-tags lunn v6.2.0-net-next-phy-leds
        git checkout bbade5cbf97bd9260cd0c9cf17699127c2b815af
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/phy/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303181550.Gc0shbAp-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/phy/phy_device.c: In function 'of_phy_led':
>> drivers/net/phy/phy_device.c:3084:21: error: 'struct led_classdev' has no member named 'hw_control_configure'
    3084 |                 cdev->hw_control_configure = phy_led_hw_control_configure;
         |                     ^~


vim +3084 drivers/net/phy/phy_device.c

  3056	
  3057	static int of_phy_led(struct phy_device *phydev,
  3058			      struct device_node *led)
  3059	{
  3060		struct device *dev = &phydev->mdio.dev;
  3061		struct led_init_data init_data = {};
  3062		struct led_classdev *cdev;
  3063		struct phy_led *phyled;
  3064		int err;
  3065	
  3066		phyled = devm_kzalloc(dev, sizeof(*phyled), GFP_KERNEL);
  3067		if (!phyled)
  3068			return -ENOMEM;
  3069	
  3070		cdev = &phyled->led_cdev;
  3071		phyled->phydev = phydev;
  3072	
  3073		err = of_property_read_u32(led, "reg", &phyled->index);
  3074		if (err)
  3075			return err;
  3076	
  3077		if (phydev->drv->led_brightness_set)
  3078			cdev->brightness_set_blocking = phy_led_set_brightness;
  3079		if (phydev->drv->led_blink_set)
  3080			cdev->blink_set = phy_led_blink_set;
  3081		if (phydev->drv->led_hw_is_supported &&
  3082		    phydev->drv->led_hw_control_set &&
  3083		    phydev->drv->led_hw_control_get)
> 3084			cdev->hw_control_configure = phy_led_hw_control_configure;
  3085		cdev->max_brightness = 1;
  3086		init_data.devicename = dev_name(&phydev->mdio.dev);
  3087		init_data.fwnode = of_fwnode_handle(led);
  3088	
  3089		err = devm_led_classdev_register_ext(dev, cdev, &init_data);
  3090		if (err)
  3091			return err;
  3092	
  3093		list_add(&phyled->list, &phydev->leds);
  3094	
  3095		return 0;
  3096	}
  3097	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-03-18  7:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303181550.Gc0shbAp-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrew@lunn.ch \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.