From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Pascal de Bruijn <p.debruijn@unilogic.nl>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] package/linux-tools/S10hyperv: fix shellcheck warnings
Date: Sat, 18 Mar 2023 23:05:19 +0100 [thread overview]
Message-ID: <20230318230519.4ba6d422@windsurf> (raw)
In-Reply-To: <20230317202724.79207-2-ju.o@free.fr>
On Fri, 17 Mar 2023 21:27:23 +0100
Julien Olivain <ju.o@free.fr> wrote:
> When running "make check-package" on a system with shellcheck 0.9.0,
> the command fails with output:
>
> make check-package
> package/linux-tools/S10hyperv:0: run 'shellcheck' and fix the warnings
> ...
> 2 warnings generated
>
> This commit fixes the warnings reported by the command:
>
> shellcheck package/linux-tools/S10hyperv
>
> This commit also fixes the four-space indent by a single tab on the
> changed lines. Since this fixes the indentation warnings of
> check-package, the Indent exclusion in .checkpackageignore is also
> removed.
>
> Fixes:
>
> In package/linux-tools/S10hyperv line 27:
> return $ret
> ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
>
> In package/linux-tools/S10hyperv line 48:
> return $ret
> ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> .checkpackageignore | 2 +-
> package/linux-tools/S10hyperv | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-03-18 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 20:27 [Buildroot] [PATCH 1/3] package/kodi/br-kodi: fix shellcheck warnings Julien Olivain
2023-03-17 20:27 ` [Buildroot] [PATCH 2/3] package/linux-tools/S10hyperv: " Julien Olivain
2023-03-18 22:05 ` Thomas Petazzoni via buildroot [this message]
2023-03-17 20:27 ` [Buildroot] [PATCH 3/3] utils/config: " Julien Olivain
2023-03-18 22:03 ` [Buildroot] [PATCH 1/3] package/kodi/br-kodi: " Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318230519.4ba6d422@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=ju.o@free.fr \
--cc=marcus.folkesson@gmail.com \
--cc=p.debruijn@unilogic.nl \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.