From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Louis Peens <louis.peens@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net 1/1] nfp: correct number of MSI vectors requests returned
Date: Sun, 19 Mar 2023 11:48:15 -0700 [thread overview]
Message-ID: <20230319114815.5bcba7bf@kernel.org> (raw)
In-Reply-To: <20230319111944.GA36557@unreal>
On Sun, 19 Mar 2023 13:19:44 +0200 Leon Romanovsky wrote:
> On Thu, Mar 16, 2023 at 02:27:10PM -0700, Jakub Kicinski wrote:
> > On Thu, 16 Mar 2023 13:09:43 +0200 Leon Romanovsky wrote:
> > > Please don't break lines. You have upto 80 chars per-line.
> >
> > 72 I think, git adds an indentation. Not that I personally care
> > about "not using full lines".
>
> I care about typography.
Typography of commit messages? Let's make sure the code is right.
We may have some fundamental disagreements about line length
and identifier name length, looking at mlx5 code :(
next prev parent reply other threads:[~2023-03-19 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:17 [PATCH net 1/1] nfp: correct number of MSI vectors requests returned Louis Peens
2023-03-16 11:09 ` Leon Romanovsky
2023-03-16 21:27 ` Jakub Kicinski
2023-03-19 11:19 ` Leon Romanovsky
2023-03-19 18:48 ` Jakub Kicinski [this message]
2023-03-20 7:01 ` Leon Romanovsky
2023-03-16 21:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319114815.5bcba7bf@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.