From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47690C7618A for ; Mon, 20 Mar 2023 08:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YuDBJPYV9gMDJXJwAyACAoM0fmpizlANML8QDYizLS8=; b=jWFBb0U2xjDCwu avddsODJ2hCVcI/krsahi1IDTrPzzbM59pX0wMrBJe8eLGz+mvdUP/JlV+8TAKAlXGShJOwIZRrxA ukSrRs2UdQTgBzMvNwEkpE90Z0UcbOxaFU/MhykZw3QXhIvYtA6Zkz6cFAytze2+78Fqmls+e4r0E sIeytE0NjDRFdobAeJSUUytVr/ctezCqAdMY3rTxXe5Rw9rlrBWFydp/dZ9MOcXDB+0lSMdwZQuOG /fZN4gZzAk0S9Pb3eV0WxBR+q4e4d6tzCP6vKd73bKMR7eSXPfxunFnODi5hL8RIz1j2C19iCBCbc siN1heYz+Xao8uvIuVfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peAhi-008MPS-0h; Mon, 20 Mar 2023 08:17:18 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peAhd-008MOU-2h for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 08:17:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E014DCE105B; Mon, 20 Mar 2023 08:17:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA08C433D2; Mon, 20 Mar 2023 08:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300225; bh=iZAKpv9vKw6j8ES7LbS+7gcVnQibaYrm2GKpFO8qiCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mp4Li1+mqjOh2qGIThWxOMMCBh2CVurF0VOnG573Cpb4Y6uCl7hLqgprMs+PFIAYR uXBu4DVOlr/5w8mfpvflZdDSlulC7E3D4KqQIY4dAhRyXBMc7KiVJ3lern27/TKzjq +AGoeRvbxFIruWCOJDM82SjqAScBi71byVCU9ZQ9EFsOGNCeWhohP4Kh6CT9mgmEpv EGPyTwlzxcOM7hf5xGyZzkbVBiqOaLtnCRBfY1DoZ+BwNgKdrbrczRKN4XbxBEkekL JZvGHTPRm8YU7pOL59mUElW+PcHoHrD40uRDyJjwZJjr7Ruf+5XwC2KdnEl8sQJUSf 0iZq6TBCV+AEw== Date: Mon, 20 Mar 2023 08:17:00 +0000 From: Lee Jones To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hyun Kwon , David Airlie , Daniel Vetter , Michal Simek , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/37] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Message-ID: <20230320081700.GH9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-3-lee@kernel.org> <20230319142432.GM10144@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230319142432.GM10144@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_011714_759559_7062141A X-CRM114-Status: GOOD ( 25.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAxOSBNYXIgMjAyMywgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKCj4gSGkgTGVlLAo+ Cj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4KPiBPbiBGcmksIE1hciAxNywgMjAyMyBhdCAw ODoxNjo0M0FNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBGaXhlcyB0aGUgZm9sbG93aW5n IFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiA+Cj4gPiAgZHJpdmVycy9ncHUvZHJtL3hs bngvenlucW1wX2Rpc3AuYzoxNTE6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1i ZXIgJ2JsZW5kJyBub3QgZGVzY3JpYmVkIGluICd6eW5xbXBfZGlzcCcKPiA+ICBkcml2ZXJzL2dw dS9kcm0veGxueC96eW5xbXBfZGlzcC5jOjE1MTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVy IG9yIG1lbWJlciAnYXZidWYnIG5vdCBkZXNjcmliZWQgaW4gJ3p5bnFtcF9kaXNwJwo+ID4gIGRy aXZlcnMvZ3B1L2RybS94bG54L3p5bnFtcF9kaXNwLmM6MTUxOiB3YXJuaW5nOiBGdW5jdGlvbiBw YXJhbWV0ZXIgb3IgbWVtYmVyICdhdWRpbycgbm90IGRlc2NyaWJlZCBpbiAnenlucW1wX2Rpc3An Cj4gPgo+ID4gQ2M6IEh5dW4gS3dvbiA8aHl1bi5rd29uQHhpbGlueC5jb20+Cj4gPiBDYzogTGF1 cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4gQ2M6 IERhdmlkIEFpcmxpZSA8YWlybGllZEBnbWFpbC5jb20+Cj4gPiBDYzogRGFuaWVsIFZldHRlciA8 ZGFuaWVsQGZmd2xsLmNoPgo+ID4gQ2M6IE1pY2hhbCBTaW1layA8bWljaGFsLnNpbWVrQHhpbGlu eC5jb20+Cj4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ID4gU2lnbmVkLW9mZi1ieTogTGVl IEpvbmVzIDxsZWVAa2VybmVsLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS94bG54 L3p5bnFtcF9kaXNwLmMgfCA2ICsrKy0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS94bG54L3p5bnFtcF9kaXNwLmMgYi9kcml2ZXJzL2dwdS9kcm0veGxueC96eW5xbXBfZGlzcC5j Cj4gPiBpbmRleCAzYjg3ZWViZGRjOTc5Li42MzM1OGY0ODk4NjI1IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3hsbngvenlucW1wX2Rpc3AuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3hsbngvenlucW1wX2Rpc3AuYwo+ID4gQEAgLTEyOCw5ICsxMjgsOSBAQCBzdHJ1Y3Qgenlu cW1wX2Rpc3BfbGF5ZXIgewo+ID4gICAqIHN0cnVjdCB6eW5xbXBfZGlzcCAtIERpc3BsYXkgY29u dHJvbGxlcgo+ID4gICAqIEBkZXY6IERldmljZSBzdHJ1Y3R1cmUKPiA+ICAgKiBAZHBzdWI6IERp c3BsYXkgc3Vic3lzdGVtCj4gPiAtICogQGJsZW5kLmJhc2U6IFJlZ2lzdGVyIEkvTyBiYXNlIGFk ZHJlc3MgZm9yIHRoZSBibGVuZGVyCj4gPiAtICogQGF2YnVmLmJhc2U6IFJlZ2lzdGVyIEkvTyBi YXNlIGFkZHJlc3MgZm9yIHRoZSBhdWRpby92aWRlbyBidWZmZXIgbWFuYWdlcgo+ID4gLSAqIEBh dWRpby5iYXNlOiBSZWdpc3RlcnMgSS9PIGJhc2UgYWRkcmVzcyBmb3IgdGhlIGF1ZGlvIG1peGVy Cj4gPiArICogQGJsZW5kOiAuYmFzZTogUmVnaXN0ZXIgSS9PIGJhc2UgYWRkcmVzcyBmb3IgdGhl IGJsZW5kZXIKPiA+ICsgKiBAYXZidWY6IC5iYXNlOiBSZWdpc3RlciBJL08gYmFzZSBhZGRyZXNz IGZvciB0aGUgYXVkaW8vdmlkZW8gYnVmZmVyIG1hbmFnZXIKPiA+ICsgKiBAYXVkaW86IC5iYXNl OiBSZWdpc3RlcnMgSS9PIGJhc2UgYWRkcmVzcyBmb3IgdGhlIGF1ZGlvIG1peGVyCj4KPiBUaGlz IGlzIGEgaGFjaywgaXQgd29uJ3Qgd29yayBwcm9wZXJseSBpZiB0aGUgbmVzdGVkIHN0cnVjdHVy ZXMgZ2V0Cj4gZXh0ZW5kZWQgd2l0aCBtb3JlIGZpZWxkcy4KClRoZSBvcmlnaW5hbCBkb2MgaXMg YSBoYWNrLCBmb3IgaXQgaXMgbm90IHJlY29nbmlzZWQga2VybmVsZG9jIGZvcm1hdC4gIDopCgo+ IElzIHRoZXJlIGEgY29ycmVjdCBrZXJuZWxkb2Mgc3ludGF4IGZvciB0aGlzIGNvZGUgY29uc3Ry dWN0ID8KCk5vdCB0aGF0IEknbSBhd2FyZSBvZi4KClVubGVzcyBpdCdzIGJlZW4gYWRkZWQgc2lu Y2UgbXkgbGFzdCByb3VuZCBvZiB0aGlzIHN0dWZmLgoKPiA+ICAgKiBAbGF5ZXJzOiBMYXllcnMg KHBsYW5lcykKPiA+ICAgKi8KPiA+ICBzdHJ1Y3QgenlucW1wX2Rpc3Agewo+Cj4gLS0KPiBSZWdh cmRzLAo+Cj4gTGF1cmVudCBQaW5jaGFydAoKLS0KTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA795C6FD1D for ; Mon, 20 Mar 2023 08:17:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2331410E23D; Mon, 20 Mar 2023 08:17:11 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 695EF10E23D for ; Mon, 20 Mar 2023 08:17:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E014DCE105B; Mon, 20 Mar 2023 08:17:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA08C433D2; Mon, 20 Mar 2023 08:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300225; bh=iZAKpv9vKw6j8ES7LbS+7gcVnQibaYrm2GKpFO8qiCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mp4Li1+mqjOh2qGIThWxOMMCBh2CVurF0VOnG573Cpb4Y6uCl7hLqgprMs+PFIAYR uXBu4DVOlr/5w8mfpvflZdDSlulC7E3D4KqQIY4dAhRyXBMc7KiVJ3lern27/TKzjq +AGoeRvbxFIruWCOJDM82SjqAScBi71byVCU9ZQ9EFsOGNCeWhohP4Kh6CT9mgmEpv EGPyTwlzxcOM7hf5xGyZzkbVBiqOaLtnCRBfY1DoZ+BwNgKdrbrczRKN4XbxBEkekL JZvGHTPRm8YU7pOL59mUElW+PcHoHrD40uRDyJjwZJjr7Ruf+5XwC2KdnEl8sQJUSf 0iZq6TBCV+AEw== Date: Mon, 20 Mar 2023 08:17:00 +0000 From: Lee Jones To: Laurent Pinchart Subject: Re: [PATCH 02/37] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Message-ID: <20230320081700.GH9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-3-lee@kernel.org> <20230319142432.GM10144@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230319142432.GM10144@pendragon.ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hyun Kwon , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Simek , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 19 Mar 2023, Laurent Pinchart wrote: > Hi Lee, > > Thank you for the patch. > > On Fri, Mar 17, 2023 at 08:16:43AM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp' > > > > Cc: Hyun Kwon > > Cc: Laurent Pinchart > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Michal Simek > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > index 3b87eebddc979..63358f4898625 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > @@ -128,9 +128,9 @@ struct zynqmp_disp_layer { > > * struct zynqmp_disp - Display controller > > * @dev: Device structure > > * @dpsub: Display subsystem > > - * @blend.base: Register I/O base address for the blender > > - * @avbuf.base: Register I/O base address for the audio/video buffer manager > > - * @audio.base: Registers I/O base address for the audio mixer > > + * @blend: .base: Register I/O base address for the blender > > + * @avbuf: .base: Register I/O base address for the audio/video buffer manager > > + * @audio: .base: Registers I/O base address for the audio mixer > > This is a hack, it won't work properly if the nested structures get > extended with more fields. The original doc is a hack, for it is not recognised kerneldoc format. :) > Is there a correct kerneldoc syntax for this code construct ? Not that I'm aware of. Unless it's been added since my last round of this stuff. > > * @layers: Layers (planes) > > */ > > struct zynqmp_disp { > > -- > Regards, > > Laurent Pinchart -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E64C7618A for ; Mon, 20 Mar 2023 08:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbjCTIR1 (ORCPT ); Mon, 20 Mar 2023 04:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbjCTIRX (ORCPT ); Mon, 20 Mar 2023 04:17:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CD7F3C22 for ; Mon, 20 Mar 2023 01:17:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE8F361263 for ; Mon, 20 Mar 2023 08:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA08C433D2; Mon, 20 Mar 2023 08:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300225; bh=iZAKpv9vKw6j8ES7LbS+7gcVnQibaYrm2GKpFO8qiCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mp4Li1+mqjOh2qGIThWxOMMCBh2CVurF0VOnG573Cpb4Y6uCl7hLqgprMs+PFIAYR uXBu4DVOlr/5w8mfpvflZdDSlulC7E3D4KqQIY4dAhRyXBMc7KiVJ3lern27/TKzjq +AGoeRvbxFIruWCOJDM82SjqAScBi71byVCU9ZQ9EFsOGNCeWhohP4Kh6CT9mgmEpv EGPyTwlzxcOM7hf5xGyZzkbVBiqOaLtnCRBfY1DoZ+BwNgKdrbrczRKN4XbxBEkekL JZvGHTPRm8YU7pOL59mUElW+PcHoHrD40uRDyJjwZJjr7Ruf+5XwC2KdnEl8sQJUSf 0iZq6TBCV+AEw== Date: Mon, 20 Mar 2023 08:17:00 +0000 From: Lee Jones To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hyun Kwon , David Airlie , Daniel Vetter , Michal Simek , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/37] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Message-ID: <20230320081700.GH9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-3-lee@kernel.org> <20230319142432.GM10144@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230319142432.GM10144@pendragon.ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Mar 2023, Laurent Pinchart wrote: > Hi Lee, > > Thank you for the patch. > > On Fri, Mar 17, 2023 at 08:16:43AM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp' > > > > Cc: Hyun Kwon > > Cc: Laurent Pinchart > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Michal Simek > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > index 3b87eebddc979..63358f4898625 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > @@ -128,9 +128,9 @@ struct zynqmp_disp_layer { > > * struct zynqmp_disp - Display controller > > * @dev: Device structure > > * @dpsub: Display subsystem > > - * @blend.base: Register I/O base address for the blender > > - * @avbuf.base: Register I/O base address for the audio/video buffer manager > > - * @audio.base: Registers I/O base address for the audio mixer > > + * @blend: .base: Register I/O base address for the blender > > + * @avbuf: .base: Register I/O base address for the audio/video buffer manager > > + * @audio: .base: Registers I/O base address for the audio mixer > > This is a hack, it won't work properly if the nested structures get > extended with more fields. The original doc is a hack, for it is not recognised kerneldoc format. :) > Is there a correct kerneldoc syntax for this code construct ? Not that I'm aware of. Unless it's been added since my last round of this stuff. > > * @layers: Layers (planes) > > */ > > struct zynqmp_disp { > > -- > Regards, > > Laurent Pinchart -- Lee Jones [李琼斯]