From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80A9FC6FD1D for ; Mon, 20 Mar 2023 08:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hFE7vegsuenD5KLekv0LMsJcVehYHDT+ZcVcG2ABN80=; b=UTBDtr6H65zisMI7Ei0nqkJ1n6 gklFLezaDp4rlW146Ileohp8w203ZuG5rfCvs//zU2jwmOCgQg1W6Oawtet6FcpV9oUVCZW4gZtcR 6q8ryJyaDRl16H04aQ9/Jq3rrJSw25AYdhptQEFzjFBxe6i2/CCNwJyZNIknjAit6tlF4nbfD+6oj IWfGzuUcs/GypIU8PJU5i4RmnCyLroEUWiXUIhpHr2DPFES1zNP2wj93QukNPTtcpNg3va+T3T/A4 FLhQSFI9IDBOsODYfX5hFQjfRn7vrRp4X/SnUwNiyImvOMSDy5CyfbyRoxYsdLMF/UlGO00rWvhLc fP/Fm93w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peAmi-008MwI-2L; Mon, 20 Mar 2023 08:22:28 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peAmf-008MvR-2P; Mon, 20 Mar 2023 08:22:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43482B80D7D; Mon, 20 Mar 2023 08:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B6EC433D2; Mon, 20 Mar 2023 08:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300543; bh=Doe1j/uXAracamn2Mysv5svXt7LOcVO7jSrIu0ukLWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WmMbgKxhrvLdrQUMb3RD/I0nM4GvhQVW1byr/VWg0euMi9rxIqLW3Qycuvn6IZ3UV JY52pcJkVJATODOjATOqsFAT20TpQOrsWDw9B/nnRUJkSRTJ0Ce96DZjF3rwTJ9cRY tcfYSBRQVR6GMsW5oym8He1ypbx7l0MKYPtvutvATIcmjyRdxZIeOXdVS2sfmP4y9h 9eX5P22Ti3vmMUEDfHvpHFoPznkdmNZfIrUr7ue1clJfZjNcFsdNCQVxuq7W5PNbA9 UYjoY/Jzb8k3my7QeCfJG4nZa2LH5IlO32zxH3RsaRKpJ47YXULfXV2LtrjRStQUk4 rWJhVEGfnk8kw== Date: Mon, 20 Mar 2023 08:22:17 +0000 From: Lee Jones To: AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/37] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header Message-ID: <20230320082217.GK9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-8-lee@kernel.org> <5dbee8ef-a5eb-b73d-5336-8b5c879a0d2a@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5dbee8ef-a5eb-b73d-5336-8b5c879a0d2a@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_012225_925526_D336A689 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 17 Mar 2023, AngeloGioacchino Del Regno wrote: > Il 17/03/23 09:16, Lee Jones ha scritto: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'clk' not described in 'mtk_disp_aal' > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'regs' not described in 'mtk_disp_aal' > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_aal' > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'data' not described in 'mtk_disp_aal' > > > > Cc: Chun-Kuang Hu > > Cc: Philipp Zabel > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Matthias Brugger > > Cc: AngeloGioacchino Del Regno > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-mediatek@lists.infradead.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Lee Jones > > I'd add the missing documentation instead. > > Please give some time, either me or someone else will do that ASAP. Even better. Thank you. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00792C7618D for ; Mon, 20 Mar 2023 08:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=29/w/L3UDNAa0I/0N4s+3R9Yuxs4YwW5opUlxXIbro4=; b=LQXcXyAt1p7LXS J32W30ZJCykw2mDUyd398p1egekkCnHtnXJ8GKZIIULV7tB7fRlyiHBHrRpenNHqxIPVwDwUJ/T5v 7IDdeVxjuDd82N2dhUGcr7pX4jLCqdhZZMQmGuTnQ65e/3i85l+rBi17QYYfi9nyMaBM3IVIcwuPD LBlU+iTPZ0/JtSHvgHQpQhN88NUrj6mXtX2A6/7974A7OiaZbp5DkV40fFeMZnjvF81mZ/+NMDVPu 2sp8EQF8euJGcGcB6m9FRelCX10HoFA1Jlbb3nm3rxEYr6ctOhpggC3mHuSSZHvDLLjBXrIdoVkBz 41DrMF12EFvoTfcfBgYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peAmh-008Mw1-2l; Mon, 20 Mar 2023 08:22:27 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peAmf-008MvR-2P; Mon, 20 Mar 2023 08:22:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43482B80D7D; Mon, 20 Mar 2023 08:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B6EC433D2; Mon, 20 Mar 2023 08:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300543; bh=Doe1j/uXAracamn2Mysv5svXt7LOcVO7jSrIu0ukLWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WmMbgKxhrvLdrQUMb3RD/I0nM4GvhQVW1byr/VWg0euMi9rxIqLW3Qycuvn6IZ3UV JY52pcJkVJATODOjATOqsFAT20TpQOrsWDw9B/nnRUJkSRTJ0Ce96DZjF3rwTJ9cRY tcfYSBRQVR6GMsW5oym8He1ypbx7l0MKYPtvutvATIcmjyRdxZIeOXdVS2sfmP4y9h 9eX5P22Ti3vmMUEDfHvpHFoPznkdmNZfIrUr7ue1clJfZjNcFsdNCQVxuq7W5PNbA9 UYjoY/Jzb8k3my7QeCfJG4nZa2LH5IlO32zxH3RsaRKpJ47YXULfXV2LtrjRStQUk4 rWJhVEGfnk8kw== Date: Mon, 20 Mar 2023 08:22:17 +0000 From: Lee Jones To: AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/37] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header Message-ID: <20230320082217.GK9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-8-lee@kernel.org> <5dbee8ef-a5eb-b73d-5336-8b5c879a0d2a@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5dbee8ef-a5eb-b73d-5336-8b5c879a0d2a@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_012225_925526_D336A689 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNyBNYXIgMjAyMywgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6Cgo+ IElsIDE3LzAzLzIzIDA5OjE2LCBMZWUgSm9uZXMgaGEgc2NyaXR0bzoKPiA+IEZpeGVzIHRoZSBm b2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+ID4KPiA+ICAgZHJpdmVycy9n cHUvZHJtL21lZGlhdGVrL210a19kaXNwX2FhbC5jOjM5OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJh bWV0ZXIgb3IgbWVtYmVyICdjbGsnIG5vdCBkZXNjcmliZWQgaW4gJ210a19kaXNwX2FhbCcKPiA+ ICAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX2FhbC5jOjM5OiB3YXJuaW5nOiBG dW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdyZWdzJyBub3QgZGVzY3JpYmVkIGluICdtdGtf ZGlzcF9hYWwnCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9hYWwuYzoz OTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnY21kcV9yZWcnIG5vdCBk ZXNjcmliZWQgaW4gJ210a19kaXNwX2FhbCcKPiA+ICAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kaXNwX2FhbC5jOjM5OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVy ICdkYXRhJyBub3QgZGVzY3JpYmVkIGluICdtdGtfZGlzcF9hYWwnCj4gPgo+ID4gQ2M6IENodW4t S3VhbmcgSHUgPGNodW5rdWFuZy5odUBrZXJuZWwub3JnPgo+ID4gQ2M6IFBoaWxpcHAgWmFiZWwg PHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+Cj4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGdt YWlsLmNvbT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gPiBDYzog TWF0dGhpYXMgQnJ1Z2dlciA8bWF0dGhpYXMuYmdnQGdtYWlsLmNvbT4KPiA+IENjOiBBbmdlbG9H aW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEu Y29tPgo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IENjOiBsaW51 eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiBDYzogbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZUBrZXJu ZWwub3JnPgo+Cj4gSSdkIGFkZCB0aGUgbWlzc2luZyBkb2N1bWVudGF0aW9uIGluc3RlYWQuCj4K PiBQbGVhc2UgZ2l2ZSBzb21lIHRpbWUsIGVpdGhlciBtZSBvciBzb21lb25lIGVsc2Ugd2lsbCBk byB0aGF0IEFTQVAuCgpFdmVuIGJldHRlci4gIFRoYW5rIHlvdS4KCi0tCkxlZSBKb25lcyBb5p2O 55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC9A3C7618A for ; Mon, 20 Mar 2023 08:22:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA7A810E25C; Mon, 20 Mar 2023 08:22:27 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81CD610E25C for ; Mon, 20 Mar 2023 08:22:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43482B80D7D; Mon, 20 Mar 2023 08:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B6EC433D2; Mon, 20 Mar 2023 08:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300543; bh=Doe1j/uXAracamn2Mysv5svXt7LOcVO7jSrIu0ukLWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WmMbgKxhrvLdrQUMb3RD/I0nM4GvhQVW1byr/VWg0euMi9rxIqLW3Qycuvn6IZ3UV JY52pcJkVJATODOjATOqsFAT20TpQOrsWDw9B/nnRUJkSRTJ0Ce96DZjF3rwTJ9cRY tcfYSBRQVR6GMsW5oym8He1ypbx7l0MKYPtvutvATIcmjyRdxZIeOXdVS2sfmP4y9h 9eX5P22Ti3vmMUEDfHvpHFoPznkdmNZfIrUr7ue1clJfZjNcFsdNCQVxuq7W5PNbA9 UYjoY/Jzb8k3my7QeCfJG4nZa2LH5IlO32zxH3RsaRKpJ47YXULfXV2LtrjRStQUk4 rWJhVEGfnk8kw== Date: Mon, 20 Mar 2023 08:22:17 +0000 From: Lee Jones To: AngeloGioacchino Del Regno Subject: Re: [PATCH 07/37] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header Message-ID: <20230320082217.GK9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-8-lee@kernel.org> <5dbee8ef-a5eb-b73d-5336-8b5c879a0d2a@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5dbee8ef-a5eb-b73d-5336-8b5c879a0d2a@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 17 Mar 2023, AngeloGioacchino Del Regno wrote: > Il 17/03/23 09:16, Lee Jones ha scritto: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'clk' not described in 'mtk_disp_aal' > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'regs' not described in 'mtk_disp_aal' > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_aal' > > drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'data' not described in 'mtk_disp_aal' > > > > Cc: Chun-Kuang Hu > > Cc: Philipp Zabel > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Matthias Brugger > > Cc: AngeloGioacchino Del Regno > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-mediatek@lists.infradead.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Lee Jones > > I'd add the missing documentation instead. > > Please give some time, either me or someone else will do that ASAP. Even better. Thank you. -- Lee Jones [李琼斯]