From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16A0C6FD1D for ; Mon, 20 Mar 2023 10:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbjCTKgK (ORCPT ); Mon, 20 Mar 2023 06:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjCTKfo (ORCPT ); Mon, 20 Mar 2023 06:35:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F59D7A90; Mon, 20 Mar 2023 03:35:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3CAB61333; Mon, 20 Mar 2023 10:35:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 348B5C433EF; Mon, 20 Mar 2023 10:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679308504; bh=M/wWyAoTmx9mB/cTEjucMK8opbUBCDiaoVYvdKCtM00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ug4MGKB5x6BjiRYYC4VzrvoxvY/oDRwFjN2VLdzI5TBwlSfpiMayNt3lfjtPibAHu St7oiHUW9MjFsGWKPzLGvkvvUZqr8LOyeFgbzc19GlegmF6RIPsYIgGp3bTH5Q8xbI n7QyKIU3IjeRQwkowbrl/zEVnMX59V2xCugTCcAfq5tKdRQBJjp7lWTJET6pIfxMzH De+CtrWrTv4duxBvCTvGLvc2V1yU0OKYCkVIuUYnQkuAxg1YiezlnRyCdqXOo3KJWx C9ffVaU5Fppad0dttD16qvp+PBUE7PpEdPBO9Xp6YD6Bux3Yej/BZmKW9RY8T6CaBL AWpIEJI+3iQUQ== Date: Mon, 20 Mar 2023 16:04:52 +0530 From: Manivannan Sadhasivam To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , Thorsten Scherer , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Pengutronix Kernel Team , Maxime Coquelin , Alexandre Torgue , Robert Richter , Nobuhiro Iwamatsu , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Marc Zyngier Subject: Re: [PATCH 1/9] gpio: rda: Convert to immutable irq_chip Message-ID: <20230320103452.GD4564@thinkpad> References: <20230316-immutable-chips-2-v1-0-053d6ede831b@linaro.org> <20230316-immutable-chips-2-v1-1-053d6ede831b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230316-immutable-chips-2-v1-1-053d6ede831b@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 20, 2023 at 10:55:08AM +0100, Linus Walleij wrote: > Convert the driver to immutable irq-chip with a bit of > intuition. > > Cc: Marc Zyngier > Signed-off-by: Linus Walleij Acked-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/gpio/gpio-rda.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c > index 62ba18b3a602..dd568907d389 100644 > --- a/drivers/gpio/gpio-rda.c > +++ b/drivers/gpio/gpio-rda.c > @@ -38,7 +38,6 @@ struct rda_gpio { > struct gpio_chip chip; > void __iomem *base; > spinlock_t lock; > - struct irq_chip irq_chip; > int irq; > }; > > @@ -74,6 +73,7 @@ static void rda_gpio_irq_mask(struct irq_data *data) > value |= BIT(offset) << RDA_GPIO_IRQ_FALL_SHIFT; > > writel_relaxed(value, base + RDA_GPIO_INT_CTRL_CLR); > + gpiochip_disable_irq(chip, offset); > } > > static void rda_gpio_irq_ack(struct irq_data *data) > @@ -154,6 +154,7 @@ static void rda_gpio_irq_unmask(struct irq_data *data) > u32 offset = irqd_to_hwirq(data); > u32 trigger = irqd_get_trigger_type(data); > > + gpiochip_enable_irq(chip, offset); > rda_gpio_set_irq(chip, offset, trigger); > } > > @@ -195,6 +196,16 @@ static void rda_gpio_irq_handler(struct irq_desc *desc) > chained_irq_exit(ic, desc); > } > > +static const struct irq_chip rda_gpio_irq_chip = { > + .name = "rda-gpio", > + .irq_ack = rda_gpio_irq_ack, > + .irq_mask = rda_gpio_irq_mask, > + .irq_unmask = rda_gpio_irq_unmask, > + .irq_set_type = rda_gpio_irq_set_type, > + .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_IMMUTABLE, > + GPIOCHIP_IRQ_RESOURCE_HELPERS, > +}; > + > static int rda_gpio_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -241,15 +252,8 @@ static int rda_gpio_probe(struct platform_device *pdev) > rda_gpio->chip.base = -1; > > if (rda_gpio->irq >= 0) { > - rda_gpio->irq_chip.name = "rda-gpio", > - rda_gpio->irq_chip.irq_ack = rda_gpio_irq_ack, > - rda_gpio->irq_chip.irq_mask = rda_gpio_irq_mask, > - rda_gpio->irq_chip.irq_unmask = rda_gpio_irq_unmask, > - rda_gpio->irq_chip.irq_set_type = rda_gpio_irq_set_type, > - rda_gpio->irq_chip.flags = IRQCHIP_SKIP_SET_WAKE, > - > girq = &rda_gpio->chip.irq; > - girq->chip = &rda_gpio->irq_chip; > + gpio_irq_chip_set_chip(girq, &rda_gpio_irq_chip); > girq->handler = handle_bad_irq; > girq->default_type = IRQ_TYPE_NONE; > girq->parent_handler = rda_gpio_irq_handler; > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 596CDC6FD1D for ; Mon, 20 Mar 2023 10:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NyzdfdO7cdSRQDysnle7b3oCpNthatIwVsFy3Qc/DeQ=; b=3k/BqSevW46E+A FQ6ThBK35Mu7eZKafQNHNyp9z/q95RywkY96ogm/0ESDrD94gynMcUhFo4hYUJnk0Zsy/CMzqF70L yEN37qcl2t9yncKLzJiQ9ha1hgnFJLcE/mn9FvI0bHlnyK/rnWgByYs5B3wYxAd4yye1CC5lZT7Nz /xCRvqKmiOTcibWDH2GKihI/UgU5p/Cslmtl6rgtV1qUbXM5EQHDGtSQ08hjrkrYq1/uQ18XPGl6q XZgFVFvct+pRw2p+JwOEvRMOPR22JACPwYe2dStKpsl0gUMgjLsGL/lwWQs4aer9e4Ia80UyFZbFB mgQ22I5Bi23GeaRedoqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peCr7-008dt0-2c; Mon, 20 Mar 2023 10:35:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peCr4-008drG-30; Mon, 20 Mar 2023 10:35:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 98E4EB80DF4; Mon, 20 Mar 2023 10:35:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 348B5C433EF; Mon, 20 Mar 2023 10:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679308504; bh=M/wWyAoTmx9mB/cTEjucMK8opbUBCDiaoVYvdKCtM00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ug4MGKB5x6BjiRYYC4VzrvoxvY/oDRwFjN2VLdzI5TBwlSfpiMayNt3lfjtPibAHu St7oiHUW9MjFsGWKPzLGvkvvUZqr8LOyeFgbzc19GlegmF6RIPsYIgGp3bTH5Q8xbI n7QyKIU3IjeRQwkowbrl/zEVnMX59V2xCugTCcAfq5tKdRQBJjp7lWTJET6pIfxMzH De+CtrWrTv4duxBvCTvGLvc2V1yU0OKYCkVIuUYnQkuAxg1YiezlnRyCdqXOo3KJWx C9ffVaU5Fppad0dttD16qvp+PBUE7PpEdPBO9Xp6YD6Bux3Yej/BZmKW9RY8T6CaBL AWpIEJI+3iQUQ== Date: Mon, 20 Mar 2023 16:04:52 +0530 From: Manivannan Sadhasivam To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , Thorsten Scherer , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Pengutronix Kernel Team , Maxime Coquelin , Alexandre Torgue , Robert Richter , Nobuhiro Iwamatsu , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Marc Zyngier Subject: Re: [PATCH 1/9] gpio: rda: Convert to immutable irq_chip Message-ID: <20230320103452.GD4564@thinkpad> References: <20230316-immutable-chips-2-v1-0-053d6ede831b@linaro.org> <20230316-immutable-chips-2-v1-1-053d6ede831b@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230316-immutable-chips-2-v1-1-053d6ede831b@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_033507_252842_D7FBFDA9 X-CRM114-Status: GOOD ( 20.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjAsIDIwMjMgYXQgMTA6NTU6MDhBTSArMDEwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBDb252ZXJ0IHRoZSBkcml2ZXIgdG8gaW1tdXRhYmxlIGlycS1jaGlwIHdpdGggYSBi aXQgb2YKPiBpbnR1aXRpb24uCj4gCj4gQ2M6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+ Cj4gU2lnbmVkLW9mZi1ieTogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3Jn PgoKQWNrZWQtYnk6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaUBrZXJuZWwub3JnPgoKVGhh bmtzLApNYW5pCgo+IC0tLQo+ICBkcml2ZXJzL2dwaW8vZ3Bpby1yZGEuYyB8IDIyICsrKysrKysr KysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDkgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3Bpby9ncGlvLXJkYS5jIGIvZHJp dmVycy9ncGlvL2dwaW8tcmRhLmMKPiBpbmRleCA2MmJhMThiM2E2MDIuLmRkNTY4OTA3ZDM4OSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwaW8vZ3Bpby1yZGEuYwo+ICsrKyBiL2RyaXZlcnMvZ3Bp by9ncGlvLXJkYS5jCj4gQEAgLTM4LDcgKzM4LDYgQEAgc3RydWN0IHJkYV9ncGlvIHsKPiAgCXN0 cnVjdCBncGlvX2NoaXAgY2hpcDsKPiAgCXZvaWQgX19pb21lbSAqYmFzZTsKPiAgCXNwaW5sb2Nr X3QgbG9jazsKPiAtCXN0cnVjdCBpcnFfY2hpcCBpcnFfY2hpcDsKPiAgCWludCBpcnE7Cj4gIH07 Cj4gIAo+IEBAIC03NCw2ICs3Myw3IEBAIHN0YXRpYyB2b2lkIHJkYV9ncGlvX2lycV9tYXNrKHN0 cnVjdCBpcnFfZGF0YSAqZGF0YSkKPiAgCXZhbHVlIHw9IEJJVChvZmZzZXQpIDw8IFJEQV9HUElP X0lSUV9GQUxMX1NISUZUOwo+ICAKPiAgCXdyaXRlbF9yZWxheGVkKHZhbHVlLCBiYXNlICsgUkRB X0dQSU9fSU5UX0NUUkxfQ0xSKTsKPiArCWdwaW9jaGlwX2Rpc2FibGVfaXJxKGNoaXAsIG9mZnNl dCk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIHJkYV9ncGlvX2lycV9hY2soc3RydWN0IGlycV9k YXRhICpkYXRhKQo+IEBAIC0xNTQsNiArMTU0LDcgQEAgc3RhdGljIHZvaWQgcmRhX2dwaW9faXJx X3VubWFzayhzdHJ1Y3QgaXJxX2RhdGEgKmRhdGEpCj4gIAl1MzIgb2Zmc2V0ID0gaXJxZF90b19o d2lycShkYXRhKTsKPiAgCXUzMiB0cmlnZ2VyID0gaXJxZF9nZXRfdHJpZ2dlcl90eXBlKGRhdGEp Owo+ICAKPiArCWdwaW9jaGlwX2VuYWJsZV9pcnEoY2hpcCwgb2Zmc2V0KTsKPiAgCXJkYV9ncGlv X3NldF9pcnEoY2hpcCwgb2Zmc2V0LCB0cmlnZ2VyKTsKPiAgfQo+ICAKPiBAQCAtMTk1LDYgKzE5 NiwxNiBAQCBzdGF0aWMgdm9pZCByZGFfZ3Bpb19pcnFfaGFuZGxlcihzdHJ1Y3QgaXJxX2Rlc2Mg KmRlc2MpCj4gIAljaGFpbmVkX2lycV9leGl0KGljLCBkZXNjKTsKPiAgfQo+ICAKPiArc3RhdGlj IGNvbnN0IHN0cnVjdCBpcnFfY2hpcCByZGFfZ3Bpb19pcnFfY2hpcCA9IHsKPiArCS5uYW1lID0g InJkYS1ncGlvIiwKPiArCS5pcnFfYWNrID0gcmRhX2dwaW9faXJxX2FjaywKPiArCS5pcnFfbWFz ayA9IHJkYV9ncGlvX2lycV9tYXNrLAo+ICsJLmlycV91bm1hc2sgPSByZGFfZ3Bpb19pcnFfdW5t YXNrLAo+ICsJLmlycV9zZXRfdHlwZSA9IHJkYV9ncGlvX2lycV9zZXRfdHlwZSwKPiArCS5mbGFn cyA9IElSUUNISVBfU0tJUF9TRVRfV0FLRSB8IElSUUNISVBfSU1NVVRBQkxFLAo+ICsJR1BJT0NI SVBfSVJRX1JFU09VUkNFX0hFTFBFUlMsCj4gK307Cj4gKwo+ICBzdGF0aWMgaW50IHJkYV9ncGlv X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIHsKPiAgCXN0cnVjdCBkZXZp Y2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gQEAgLTI0MSwxNSArMjUyLDggQEAgc3RhdGljIGludCBy ZGFfZ3Bpb19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJcmRhX2dwaW8t PmNoaXAuYmFzZSA9IC0xOwo+ICAKPiAgCWlmIChyZGFfZ3Bpby0+aXJxID49IDApIHsKPiAtCQly ZGFfZ3Bpby0+aXJxX2NoaXAubmFtZSA9ICJyZGEtZ3BpbyIsCj4gLQkJcmRhX2dwaW8tPmlycV9j aGlwLmlycV9hY2sgPSByZGFfZ3Bpb19pcnFfYWNrLAo+IC0JCXJkYV9ncGlvLT5pcnFfY2hpcC5p cnFfbWFzayA9IHJkYV9ncGlvX2lycV9tYXNrLAo+IC0JCXJkYV9ncGlvLT5pcnFfY2hpcC5pcnFf dW5tYXNrID0gcmRhX2dwaW9faXJxX3VubWFzaywKPiAtCQlyZGFfZ3Bpby0+aXJxX2NoaXAuaXJx X3NldF90eXBlID0gcmRhX2dwaW9faXJxX3NldF90eXBlLAo+IC0JCXJkYV9ncGlvLT5pcnFfY2hp cC5mbGFncyA9IElSUUNISVBfU0tJUF9TRVRfV0FLRSwKPiAtCj4gIAkJZ2lycSA9ICZyZGFfZ3Bp by0+Y2hpcC5pcnE7Cj4gLQkJZ2lycS0+Y2hpcCA9ICZyZGFfZ3Bpby0+aXJxX2NoaXA7Cj4gKwkJ Z3Bpb19pcnFfY2hpcF9zZXRfY2hpcChnaXJxLCAmcmRhX2dwaW9faXJxX2NoaXApOwo+ICAJCWdp cnEtPmhhbmRsZXIgPSBoYW5kbGVfYmFkX2lycTsKPiAgCQlnaXJxLT5kZWZhdWx0X3R5cGUgPSBJ UlFfVFlQRV9OT05FOwo+ICAJCWdpcnEtPnBhcmVudF9oYW5kbGVyID0gcmRhX2dwaW9faXJxX2hh bmRsZXI7Cj4gCj4gLS0gCj4gMi4zNC4xCj4gCgotLSAK4K6u4K6j4K6/4K614K6j4K+N4K6j4K6p 4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=