Re: [PATCH] mtd: core: print error code if registering NVMEM fails

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] mtd: core: print error code if registering NVMEM fails
Date: Mon, 20 Mar 2023 12:06:17 +0100	[thread overview]
Message-ID: <20230320120617.6b9e2a4d@xps-13> (raw)
In-Reply-To: <20230317074736.28944-1-zajec5@gmail.com>

Hi Rafał,

zajec5@gmail.com wrote on Fri, 17 Mar 2023 08:47:36 +0100:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> It's a common practice that helps debugging problems.

Totally agree. I actually sent a patch to avoid the error message
upon EPROBE_DEFER which has the side effect of printing the error
(thanks to the use of dev_err_probe()):

https://lore.kernel.org/linux-mtd/20230307192506.439532-1-miquel.raynal@bootlin.com/

> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  drivers/mtd/mtdcore.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 83a22566a8ce..8303ce62c751 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -539,7 +539,8 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
>  		if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP) {
>  			mtd->nvmem = NULL;
>  		} else {
> -			dev_err(&mtd->dev, "Failed to register NVMEM device\n");
> +			dev_err(&mtd->dev, "Failed to register NVMEM device: %ld\n",
> +				PTR_ERR(mtd->nvmem));
>  			return PTR_ERR(mtd->nvmem);
>  		}
>  	}

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/