From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: [PATCH v2 2/2] ci: test compilation with debug in GHA
Date: Mon, 20 Mar 2023 13:18:33 +0100 [thread overview]
Message-ID: <20230320121833.1385859-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20230320121833.1385859-1-david.marchand@redhat.com>
We often miss compilation issues with -O0 -g.
Switch to debug in GHA for the gcc job.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changes since v1:
- rather than introduce a new job, updated the ABI check job
to build with debug,
---
.ci/linux-build.sh | 8 +++++++-
.github/workflows/build.yml | 3 ++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index ab0994388a..150b38bd7a 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -65,6 +65,12 @@ if [ "$RISCV64" = "true" ]; then
cross_file=config/riscv/riscv64_linux_gcc
fi
+buildtype=debugoptimized
+
+if [ "$BUILD_DEBUG" = "true" ]; then
+ buildtype=debug
+fi
+
if [ "$BUILD_DOCS" = "true" ]; then
OPTS="$OPTS -Denable_docs=true"
fi
@@ -85,7 +91,7 @@ fi
OPTS="$OPTS -Dplatform=generic"
OPTS="$OPTS -Ddefault_library=$DEF_LIB"
-OPTS="$OPTS -Dbuildtype=debugoptimized"
+OPTS="$OPTS -Dbuildtype=$buildtype"
OPTS="$OPTS -Dcheck_includes=true"
if [ "$MINI" = "true" ]; then
OPTS="$OPTS -Denable_drivers=net/null"
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 154be70cc1..bbcb535afb 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -18,6 +18,7 @@ jobs:
ABI_CHECKS: ${{ contains(matrix.config.checks, 'abi') }}
ASAN: ${{ contains(matrix.config.checks, 'asan') }}
BUILD_32BIT: ${{ matrix.config.cross == 'i386' }}
+ BUILD_DEBUG: ${{ contains(matrix.config.checks, 'debug') }}
BUILD_DOCS: ${{ contains(matrix.config.checks, 'doc') }}
CC: ccache ${{ matrix.config.compiler }}
DEF_LIB: ${{ matrix.config.library }}
@@ -39,7 +40,7 @@ jobs:
mini: mini
- os: ubuntu-20.04
compiler: gcc
- checks: abi+doc+tests
+ checks: abi+debug+doc+tests
- os: ubuntu-20.04
compiler: clang
checks: asan+doc+tests
--
2.39.2
next prev parent reply other threads:[~2023-03-20 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:26 [PATCH 1/2] app/mldev: fix build with debug David Marchand
2023-03-20 10:26 ` [PATCH 2/2] ci: test compilation " David Marchand
2023-03-20 10:40 ` [PATCH 1/2] app/mldev: fix build " David Marchand
2023-03-20 11:29 ` [EXT] " Srikanth Yalavarthi
2023-03-20 12:18 ` [PATCH v2 " David Marchand
2023-03-20 12:18 ` David Marchand [this message]
2023-03-20 13:30 ` [PATCH v2 2/2] ci: test compilation with debug in GHA Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320121833.1385859-2-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.