All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	iommu@lists.linux.dev, Jason Gunthorpe <jgg@nvidia.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>, X86 Kernel <x86@kernel.org>,
	bp@alien8.de, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	corbet@lwn.net, vkoul@kernel.org, dmaengine@vger.kernel.org,
	linux-doc@vger.kernel.org, Will Deacon <will@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Raj Ashok <ashok.raj@intel.com>,
	"Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v7 6/7] iommu/ioasid: Rename INVALID_IOASID
Date: Mon, 20 Mar 2023 13:38:52 -0700	[thread overview]
Message-ID: <20230320133852.7535292d@jacob-builder> (raw)
In-Reply-To: <b1a380ad-50b4-4a00-2480-ac4d1542c71f@intel.com>

Hi Dave,

On Mon, 20 Mar 2023 11:58:14 -0700, Dave Hansen <dave.hansen@intel.com>
wrote:

> On 3/20/23 11:59, Jacob Pan wrote:
> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -40,7 +40,10 @@
> >  #include <linux/io.h>
> >  #include <linux/hardirq.h>
> >  #include <linux/atomic.h>
> > -#include <linux/ioasid.h>
> > +
> > +#ifdef CONFIG_IOMMU_SVA
> > +#include <linux/iommu.h>
> > +#endif  
> 
> What's the deal with the #ifdef'd #include?
> 
> What's the harm of just making it unconditional?
No harm for this version. I will remove.

Thanks,

Jacob

  reply	other threads:[~2023-03-20 20:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 18:59 [PATCH v7 0/7] Remove VT-d virtual command interface and IOASID Jacob Pan
2023-03-20 18:59 ` [PATCH v7 1/7] iommu/vt-d: Remove virtual command interface Jacob Pan
2023-03-20 18:59 ` [PATCH v7 2/7] iommu/sva: Move PASID helpers to sva code Jacob Pan
2023-03-20 19:11   ` Jason Gunthorpe
2023-03-20 20:51     ` Jacob Pan
2023-03-20 18:59 ` [PATCH v7 3/7] iommu/sva: Remove PASID to mm lookup function Jacob Pan
2023-03-20 18:59 ` [PATCH v7 4/7] iommu/sva: Stop using ioasid_set for SVA Jacob Pan
2023-03-21  6:14   ` Baolu Lu
2023-03-20 18:59 ` [PATCH v7 5/7] iommu/sva: Use GFP_KERNEL for pasid allocation Jacob Pan
2023-03-20 18:59 ` [PATCH v7 6/7] iommu/ioasid: Rename INVALID_IOASID Jacob Pan
2023-03-20 18:58   ` Dave Hansen
2023-03-20 20:38     ` Jacob Pan [this message]
2023-03-20 18:59 ` [PATCH v7 7/7] iommu: Remove ioasid infrastructure Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320133852.7535292d@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux.dev \
    --cc=jean-philippe@linaro.com \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.