From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 847B2C6FD1D for ; Mon, 20 Mar 2023 15:59:35 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B45E71E7; Mon, 20 Mar 2023 16:58:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B45E71E7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679327972; bh=voqPPQsCdCuFgE81/uBRMkNRxxyuYSo5DQoAxdVimsE=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=rONQlcjrCYXDCN8ifNNYXEcRlzNWa9YHr6Rf25viC6GLSMOzd25tXpsxtee+MQyGx Scz/ZYhAh3j87ys8EvdpD4+JZm1SiJScMFFE9k30CyTaK/lsVsCR8XRK9qr/wENRXD QvGhE7SSNywckBP+YQoOnsWfvPGMjibZsUYpRXVQ= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 36625F8027B; Mon, 20 Mar 2023 16:58:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 560A1F8027B; Mon, 20 Mar 2023 16:58:17 +0100 (CET) Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BC659F80105 for ; Mon, 20 Mar 2023 16:58:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BC659F80105 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-177ca271cb8so13512142fac.2 for ; Mon, 20 Mar 2023 08:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679327893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B8X5XJu7ZSmlXWJv7df3tWmayRZwNJIjgct+jX9CNF4=; b=nYZk18rY+JM6jvWVx5Tdimad7CHXQD82476bj3ab28EQqcd++kBHFoFNK236qz6Z5x bQUBkF79prht8XOkT13gMnl9397Eco7CI/0jGrCF49uz2/jm28FfoFhuyExPhVZ6RwVB 5K7e9vpGFgbm1T8hjOiVGsJ+ts8cM1kEC597n5fxV+1ZDmY3P1Z9cTPje4nP0J16tzp6 XlZepeSfZkJRLMu298r90vGgz45cR3QrobsXrq4sXM0lQ1N/8pVieJ974zAArNLvafyL cDZuyloUEVOBFHYs73iR90BLnuiBtX3/76VnntRCX3US2EHg7Xg5nEMQnDZmjJ0O9DJO jk5A== X-Gm-Message-State: AO0yUKUshy15/Awfgse+OZp7ZytDXMagmzrNl04auPzm7H8dvpyjzJDJ UztaH+dPfrMU8kwpy+M51Q== X-Google-Smtp-Source: AK7set+FJqchAKh3aLkpaCyRS9ncCPb0CGLyZPm8rjBj3cImE2bhXeW/GwwFgbDKATBHmsueXL7IhQ== X-Received: by 2002:a05:6870:7085:b0:17a:d1e6:5a09 with SMTP id v5-20020a056870708500b0017ad1e65a09mr5356989oae.59.1679327893498; Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id vk10-20020a0568710e4a00b00172426ebe58sm3388588oab.27.2023.03.20.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: (nullmailer pid 1758791 invoked by uid 1000); Mon, 20 Mar 2023 15:58:12 -0000 Date: Mon, 20 Mar 2023 10:58:12 -0500 From: Rob Herring To: Cristian Ciocaltea Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320155812.GA1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> Message-ID-Hash: HNKJ5XDL7M2CDAKFMIHSFZEUK24IYSR6 X-Message-ID-Hash: HNKJ5XDL7M2CDAKFMIHSFZEUK24IYSR6 X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Mar 17, 2023 at 12:21:41PM +0200, Cristian Ciocaltea via Alsa-devel wrote: > Date: Fri, 17 Mar 2023 12:21:41 +0200 > From: Cristian Ciocaltea > To: Krzysztof Kozlowski , Sudeep Holla > , Cristian Marussi , Rob > Herring , Krzysztof Kozlowski > , Greg Kroah-Hartman > , Liam Girdwood , Mark > Brown , Nicolas Frattaroli > , Heiko Stuebner , Jaroslav > Kysela , Takashi Iwai , Paul Walmsley > , Palmer Dabbelt , Albert Ou > , Daniel Drake , Katsuhiro > Suzuki > CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, > linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, > alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, > linux-riscv@lists.infradead.org, kernel@collabora.com > Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax > dma-names order constraint > Message-ID: <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 > Thunderbird/102.7.2 There is something strange going on with your mails as there are 2 copies in the archives with the 2nd one getting the header twice. It's coming from the alsa-devel list. > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > dma-names properties") documented dma-names property to handle Allwiner > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > the reverse of what a different board expects: > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > other DT files: > > > > Why not fixing the DTS? The properties should have fixed order. > > I was initially concerned about the risk of a potential ABI breakage, but I > think that's not really a problem since dma-names is not directly accessed > in the driver and DT Kernel API doesn't rely on a particular order. > > If there are no objections, I would switch the order in the binding to > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > Best regards, > > Krzysztof > > Thanks, > Cristian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42194C7619A for ; Mon, 20 Mar 2023 15:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3L9k+Re7t7Zq3HZ/DDpFYvLap4MdFL24SSt8+onD+Uk=; b=XusxW8wK7UkM8s Roe1DjBu10tEtMN6oWB6dR7ppOib1c0P04tTT7DpgUvpbQh3yLC2+Gi1SKFl5gg9obvRcXfWN3QFU 36UlID3m8lhtMWEPfM0O2RjxbuH2CaKOXfeeqCfCzoMsCrJcqEwoX74YP160DNKK6Xli2zciCt08r J8so2aUp2zeqy8cE7Hivv1HbeTHHMuW5xAd3ICd+xyfH1NmAjclURJW9E424nhX3xlxQQCh6jeZoi HRfB7cdKV6q2/iwUP2bXn+4dPr6Vc/bw52RYGoQvt5n5oGgAMVGq9nX/IQQIRSzuRqYtLK46bybIE TjrqG6sEjZWHYl1l4+7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peHtr-009fLN-2f; Mon, 20 Mar 2023 15:58:19 +0000 Received: from mail-oa1-f51.google.com ([209.85.160.51]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peHtn-009fK4-28; Mon, 20 Mar 2023 15:58:16 +0000 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-17aeb49429eso13163466fac.6; Mon, 20 Mar 2023 08:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679327893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B8X5XJu7ZSmlXWJv7df3tWmayRZwNJIjgct+jX9CNF4=; b=OIqtWm5HFQu2B20HbiIU6U/8cnRju1FCVYl0aEdiwkA+w1Jrns0rOjcOpXyxzGzPBF C2s11YhSG/dGoWfIh9ykRdWLYvnPciLgcx3ZhNpRQLC6BSUHLuRSB5ftEOkrjvQEyrdb JKm4vgF8PGBtKaVlFiMhjEdxAFbcmALIaNxG3itNtaQTQJfNz9pm9IIyN4Wdy5BF8q+k jhTLfTHQu/0j/hYEWaJqOqq6L8THln/B5Vs1ivlOAUHGFSEPoHikE4C+zIC6h1ja/EhD BjJeVpp0+AGsPVCNZMnh7AXqudOztPc/pgmvtReBMYVuRw4EDSSZ1cEqV8jxtyYvrfM4 Gc9A== X-Gm-Message-State: AO0yUKUHXINcEQW1gVwqdWvoP1vyjd2/aaXQywpIIrJep2HsOgybOdip RDZJPz/T/LemQ87gLWPhNA== X-Google-Smtp-Source: AK7set+FJqchAKh3aLkpaCyRS9ncCPb0CGLyZPm8rjBj3cImE2bhXeW/GwwFgbDKATBHmsueXL7IhQ== X-Received: by 2002:a05:6870:7085:b0:17a:d1e6:5a09 with SMTP id v5-20020a056870708500b0017ad1e65a09mr5356989oae.59.1679327893498; Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id vk10-20020a0568710e4a00b00172426ebe58sm3388588oab.27.2023.03.20.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: (nullmailer pid 1758791 invoked by uid 1000); Mon, 20 Mar 2023 15:58:12 -0000 Date: Mon, 20 Mar 2023 10:58:12 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320155812.GA1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_085815_700089_2B4BE123 X-CRM114-Status: GOOD ( 22.46 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 12:21:41PM +0200, Cristian Ciocaltea via Alsa-devel wrote: > Date: Fri, 17 Mar 2023 12:21:41 +0200 > From: Cristian Ciocaltea > To: Krzysztof Kozlowski , Sudeep Holla > , Cristian Marussi , Rob > Herring , Krzysztof Kozlowski > , Greg Kroah-Hartman > , Liam Girdwood , Mark > Brown , Nicolas Frattaroli > , Heiko Stuebner , Jaroslav > Kysela , Takashi Iwai , Paul Walmsley > , Palmer Dabbelt , Albert Ou > , Daniel Drake , Katsuhiro > Suzuki > CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, > linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, > alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, > linux-riscv@lists.infradead.org, kernel@collabora.com > Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax > dma-names order constraint > Message-ID: <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 > Thunderbird/102.7.2 There is something strange going on with your mails as there are 2 copies in the archives with the 2nd one getting the header twice. It's coming from the alsa-devel list. > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > dma-names properties") documented dma-names property to handle Allwiner > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > the reverse of what a different board expects: > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > other DT files: > > > > Why not fixing the DTS? The properties should have fixed order. > > I was initially concerned about the risk of a potential ABI breakage, but I > think that's not really a problem since dma-names is not directly accessed > in the driver and DT Kernel API doesn't rely on a particular order. > > If there are no objections, I would switch the order in the binding to > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > Best regards, > > Krzysztof > > Thanks, > Cristian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 114ABC7618A for ; Mon, 20 Mar 2023 15:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PuuGtVXVN1YHWxOrIPAHaVz3PdNDkdfSHiSmnPUmfDA=; b=1pxZ8WXgrN6OrP PfvNLkAgCJ010z6FaiBbnKJ5TKErywoPsYadnkzBeu5FL4f7CdkmIhP2P+Ha7pOKw56tM88ZY+xIo IeUzpuT0O5rK2BAnkYqX8b6hALt8lGRVorybdt/wisClvXQiIK19EJyJ7tQJqVI2rIZwh0TJoTrJg 5Zr9ZxqNXUHwJRa9zpVU2K7vXgs6pkZNFrugvlZkJYdtT3b4TAEPb9E7AeM1vB/mYSqqxP09ED62T hVhERFHCRoTk5atOAmDNRgApMRwpFA+27oelwvuhFl7IFjquwdHT2QdPSjC61Kjc2BmyT7v/tpN8V MSQwxHppz0GEMqjhxtCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peHts-009fLT-0e; Mon, 20 Mar 2023 15:58:20 +0000 Received: from mail-oa1-f51.google.com ([209.85.160.51]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peHtn-009fK4-28; Mon, 20 Mar 2023 15:58:16 +0000 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-17aeb49429eso13163466fac.6; Mon, 20 Mar 2023 08:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679327893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B8X5XJu7ZSmlXWJv7df3tWmayRZwNJIjgct+jX9CNF4=; b=OIqtWm5HFQu2B20HbiIU6U/8cnRju1FCVYl0aEdiwkA+w1Jrns0rOjcOpXyxzGzPBF C2s11YhSG/dGoWfIh9ykRdWLYvnPciLgcx3ZhNpRQLC6BSUHLuRSB5ftEOkrjvQEyrdb JKm4vgF8PGBtKaVlFiMhjEdxAFbcmALIaNxG3itNtaQTQJfNz9pm9IIyN4Wdy5BF8q+k jhTLfTHQu/0j/hYEWaJqOqq6L8THln/B5Vs1ivlOAUHGFSEPoHikE4C+zIC6h1ja/EhD BjJeVpp0+AGsPVCNZMnh7AXqudOztPc/pgmvtReBMYVuRw4EDSSZ1cEqV8jxtyYvrfM4 Gc9A== X-Gm-Message-State: AO0yUKUHXINcEQW1gVwqdWvoP1vyjd2/aaXQywpIIrJep2HsOgybOdip RDZJPz/T/LemQ87gLWPhNA== X-Google-Smtp-Source: AK7set+FJqchAKh3aLkpaCyRS9ncCPb0CGLyZPm8rjBj3cImE2bhXeW/GwwFgbDKATBHmsueXL7IhQ== X-Received: by 2002:a05:6870:7085:b0:17a:d1e6:5a09 with SMTP id v5-20020a056870708500b0017ad1e65a09mr5356989oae.59.1679327893498; Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id vk10-20020a0568710e4a00b00172426ebe58sm3388588oab.27.2023.03.20.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: (nullmailer pid 1758791 invoked by uid 1000); Mon, 20 Mar 2023 15:58:12 -0000 Date: Mon, 20 Mar 2023 10:58:12 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320155812.GA1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_085815_700089_2B4BE123 X-CRM114-Status: GOOD ( 22.46 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 12:21:41PM +0200, Cristian Ciocaltea via Alsa-devel wrote: > Date: Fri, 17 Mar 2023 12:21:41 +0200 > From: Cristian Ciocaltea > To: Krzysztof Kozlowski , Sudeep Holla > , Cristian Marussi , Rob > Herring , Krzysztof Kozlowski > , Greg Kroah-Hartman > , Liam Girdwood , Mark > Brown , Nicolas Frattaroli > , Heiko Stuebner , Jaroslav > Kysela , Takashi Iwai , Paul Walmsley > , Palmer Dabbelt , Albert Ou > , Daniel Drake , Katsuhiro > Suzuki > CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, > linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, > alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, > linux-riscv@lists.infradead.org, kernel@collabora.com > Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax > dma-names order constraint > Message-ID: <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 > Thunderbird/102.7.2 There is something strange going on with your mails as there are 2 copies in the archives with the 2nd one getting the header twice. It's coming from the alsa-devel list. > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > dma-names properties") documented dma-names property to handle Allwiner > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > the reverse of what a different board expects: > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > other DT files: > > > > Why not fixing the DTS? The properties should have fixed order. > > I was initially concerned about the risk of a potential ABI breakage, but I > think that's not really a problem since dma-names is not directly accessed > in the driver and DT Kernel API doesn't rely on a particular order. > > If there are no objections, I would switch the order in the binding to > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > Best regards, > > Krzysztof > > Thanks, > Cristian _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9838FC7618A for ; Mon, 20 Mar 2023 16:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbjCTQJD (ORCPT ); Mon, 20 Mar 2023 12:09:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbjCTQIi (ORCPT ); Mon, 20 Mar 2023 12:08:38 -0400 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 081AE2A6D2; Mon, 20 Mar 2023 08:58:15 -0700 (PDT) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-17671fb717cso13478990fac.8; Mon, 20 Mar 2023 08:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679327893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B8X5XJu7ZSmlXWJv7df3tWmayRZwNJIjgct+jX9CNF4=; b=XmZbEeMO0+JAm7P63ROWJ94IEAKKy0pcKRs3K0iaGFboKKx2VRo/D76MJjO8W4Nhe2 x8pWdb6OR1fPrzO3IvlkAO7ezJpek+VK3A0fJFLTeNBSqxuLNqzvH2hJ1IlkftyzT0dg DP+e3VO/HDTR2XmQESHJwqmLttgpsNgrzqVmx1BYc05a90ONh5r8zpJjHZRrbPmIdVaV l/S/nPxvmNz7jhNawQkB8dYsEHJLEoF2SXj6xU/o13EggGYkJJ5CJhddihc6JfikZ/BF SKYGA/2QUF2jK2rR8R3aQGwuT+TCBlEK5sxNH3SUIrfmOexqiM67hLl+f8W2gQtsP1li fXLA== X-Gm-Message-State: AO0yUKWmOObJkexlmWYmJO21nRLaRRJqW1kDfnjYUixboMC3PVDvvJ3y R98GRyaCeLJrBASuWalqWA== X-Google-Smtp-Source: AK7set+FJqchAKh3aLkpaCyRS9ncCPb0CGLyZPm8rjBj3cImE2bhXeW/GwwFgbDKATBHmsueXL7IhQ== X-Received: by 2002:a05:6870:7085:b0:17a:d1e6:5a09 with SMTP id v5-20020a056870708500b0017ad1e65a09mr5356989oae.59.1679327893498; Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id vk10-20020a0568710e4a00b00172426ebe58sm3388588oab.27.2023.03.20.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: (nullmailer pid 1758791 invoked by uid 1000); Mon, 20 Mar 2023 15:58:12 -0000 Date: Mon, 20 Mar 2023 10:58:12 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320155812.GA1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Mar 17, 2023 at 12:21:41PM +0200, Cristian Ciocaltea via Alsa-devel wrote: > Date: Fri, 17 Mar 2023 12:21:41 +0200 > From: Cristian Ciocaltea > To: Krzysztof Kozlowski , Sudeep Holla > , Cristian Marussi , Rob > Herring , Krzysztof Kozlowski > , Greg Kroah-Hartman > , Liam Girdwood , Mark > Brown , Nicolas Frattaroli > , Heiko Stuebner , Jaroslav > Kysela , Takashi Iwai , Paul Walmsley > , Palmer Dabbelt , Albert Ou > , Daniel Drake , Katsuhiro > Suzuki > CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, > linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, > alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, > linux-riscv@lists.infradead.org, kernel@collabora.com > Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax > dma-names order constraint > Message-ID: <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 > Thunderbird/102.7.2 There is something strange going on with your mails as there are 2 copies in the archives with the 2nd one getting the header twice. It's coming from the alsa-devel list. > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > dma-names properties") documented dma-names property to handle Allwiner > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > the reverse of what a different board expects: > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > other DT files: > > > > Why not fixing the DTS? The properties should have fixed order. > > I was initially concerned about the risk of a potential ABI breakage, but I > think that's not really a problem since dma-names is not directly accessed > in the driver and DT Kernel API doesn't rely on a particular order. > > If there are no objections, I would switch the order in the binding to > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > Best regards, > > Krzysztof > > Thanks, > Cristian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1205C6FD1D for ; Mon, 20 Mar 2023 15:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4rX4UtHleO8k0wyayrIB8iPPiqdfRq/dI9ka2xO5Sac=; b=oKTwHUy+/Owwyj V8gNdwFnN2q0SrnhXNeZeFsPgq6qpTnHNlyzIzA6X2BbmqMMnBDk3NtvVyeQdFdn9KEH0u/5Ge25Z l7r64eN02ixG+KRyTTmFFfXO7TifFljeqHCO+Di21igNcbEgT7SlQQGXShnNmPNODWOau/UYmCbje 9fNXF/1DQ/Oh6REE4HzZMTMRBfO5f4pnFoWeOpAQB5ZR9DWVv2kXugX2i9ne1PQMW6e0pvc+8w9uS TY+Maq6kEmAqwDu03p8GiLz7ZMJkTabk88SWZWwZIX1keUKMBinzkCE5bEwG5/3OJppVxtCkHkLQ2 wQB4Du/6gQajPTEb7pOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peHtq-009fL2-30; Mon, 20 Mar 2023 15:58:18 +0000 Received: from mail-oa1-f51.google.com ([209.85.160.51]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peHtn-009fK4-28; Mon, 20 Mar 2023 15:58:16 +0000 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-17aeb49429eso13163466fac.6; Mon, 20 Mar 2023 08:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679327893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B8X5XJu7ZSmlXWJv7df3tWmayRZwNJIjgct+jX9CNF4=; b=OIqtWm5HFQu2B20HbiIU6U/8cnRju1FCVYl0aEdiwkA+w1Jrns0rOjcOpXyxzGzPBF C2s11YhSG/dGoWfIh9ykRdWLYvnPciLgcx3ZhNpRQLC6BSUHLuRSB5ftEOkrjvQEyrdb JKm4vgF8PGBtKaVlFiMhjEdxAFbcmALIaNxG3itNtaQTQJfNz9pm9IIyN4Wdy5BF8q+k jhTLfTHQu/0j/hYEWaJqOqq6L8THln/B5Vs1ivlOAUHGFSEPoHikE4C+zIC6h1ja/EhD BjJeVpp0+AGsPVCNZMnh7AXqudOztPc/pgmvtReBMYVuRw4EDSSZ1cEqV8jxtyYvrfM4 Gc9A== X-Gm-Message-State: AO0yUKUHXINcEQW1gVwqdWvoP1vyjd2/aaXQywpIIrJep2HsOgybOdip RDZJPz/T/LemQ87gLWPhNA== X-Google-Smtp-Source: AK7set+FJqchAKh3aLkpaCyRS9ncCPb0CGLyZPm8rjBj3cImE2bhXeW/GwwFgbDKATBHmsueXL7IhQ== X-Received: by 2002:a05:6870:7085:b0:17a:d1e6:5a09 with SMTP id v5-20020a056870708500b0017ad1e65a09mr5356989oae.59.1679327893498; Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id vk10-20020a0568710e4a00b00172426ebe58sm3388588oab.27.2023.03.20.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 08:58:13 -0700 (PDT) Received: (nullmailer pid 1758791 invoked by uid 1000); Mon, 20 Mar 2023 15:58:12 -0000 Date: Mon, 20 Mar 2023 10:58:12 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320155812.GA1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167904851367.26.16449705310108549543@mailman-core.alsa-project.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_085815_700089_2B4BE123 X-CRM114-Status: GOOD ( 22.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 12:21:41PM +0200, Cristian Ciocaltea via Alsa-devel wrote: > Date: Fri, 17 Mar 2023 12:21:41 +0200 > From: Cristian Ciocaltea > To: Krzysztof Kozlowski , Sudeep Holla > , Cristian Marussi , Rob > Herring , Krzysztof Kozlowski > , Greg Kroah-Hartman > , Liam Girdwood , Mark > Brown , Nicolas Frattaroli > , Heiko Stuebner , Jaroslav > Kysela , Takashi Iwai , Paul Walmsley > , Palmer Dabbelt , Albert Ou > , Daniel Drake , Katsuhiro > Suzuki > CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, > linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, > alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, > linux-riscv@lists.infradead.org, kernel@collabora.com > Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax > dma-names order constraint > Message-ID: <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 > Thunderbird/102.7.2 There is something strange going on with your mails as there are 2 copies in the archives with the 2nd one getting the header twice. It's coming from the alsa-devel list. > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > dma-names properties") documented dma-names property to handle Allwiner > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > the reverse of what a different board expects: > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > other DT files: > > > > Why not fixing the DTS? The properties should have fixed order. > > I was initially concerned about the risk of a potential ABI breakage, but I > think that's not really a problem since dma-names is not directly accessed > in the driver and DT Kernel API doesn't rely on a particular order. > > If there are no objections, I would switch the order in the binding to > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > Best regards, > > Krzysztof > > Thanks, > Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel