From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6889EC7618A for ; Mon, 20 Mar 2023 16:03:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D3B61E7; Mon, 20 Mar 2023 17:02:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D3B61E7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679328185; bh=BbInalM6k8qkTBwTIXYkubqu2WQYR+0SLbrXuMX5wBw=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=MUpN/nsXu3eKSjXWIe0G1TNlNIQ4BMAWKTzOPiutFclE+lhwUgFYBG4fFAlDendWP PMZ8dwQvTMc95lqWPAhSi6LVKL1tpXwPdG7TdXzQRgPB64pwrlK+eDdQQOA3wTXggr ZnFpYc/PfWmat4XmS01wv98U2YqzUO1jhLWEP8cA= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id CFCA6F80093; Mon, 20 Mar 2023 17:01:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 75A6BF8027B; Mon, 20 Mar 2023 17:01:50 +0100 (CET) Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 55F24F80093 for ; Mon, 20 Mar 2023 17:01:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 55F24F80093 Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-17997ccf711so13560135fac.0 for ; Mon, 20 Mar 2023 09:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679328101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ycdbh/3im0d0MXCRS+MVRgOfUwsMwW5wd9W+JCKfV/o=; b=3ZGrF29mgHSjYJuVrGGPAuoFhDiWlP//wjOIH20ClbWdoHAwj4WJ5sDwNlYsvgHi1B nb3L/zcpSF6R3cnx8f2Nn/K2gv8Pi7zPVIJSsqkdBW3qyXUS1gU3On09QV2Bmkl3xGbW nC5RCeLIGHtDULu7hfU75CgdcUqoz0+12DTBzRurdazDiG+wKQB6EEXtzh8JU6MEDpWe qjlnUQa4hVcpiIc1StCCy3rxVjheIQU4V6uC2zbZwnVyWAfe9EVSmpg5b0JJ1omdHuvh nG89ySlv+yRsdDZrFadmLFhCqhv94BjD7wIrMfliJvBGZPYtdBV1WgiqPgv0+g6v9V1H a1Mw== X-Gm-Message-State: AO0yUKUwAQ55aJtgjo64OR6D1VACjC0nWdDar5xv1lfwzqAYSZtkXMoI zeNxm6ERgkyxZzrNsTjdcg== X-Google-Smtp-Source: AK7set+BBHYnuq6OwVL9kjgfa2qix8lcrHAvO1bkzPcA8ohY9QPJdfChG4+hLAEfhyzub/UAI84YdA== X-Received: by 2002:a05:6870:330a:b0:177:b026:3cda with SMTP id x10-20020a056870330a00b00177b0263cdamr5812793oae.37.1679328099533; Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id tb7-20020a05687186c700b0017630fe87e5sm3404469oab.33.2023.03.20.09.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: (nullmailer pid 1764454 invoked by uid 1000); Mon, 20 Mar 2023 16:01:37 -0000 Date: Mon, 20 Mar 2023 11:01:37 -0500 From: Rob Herring To: Cristian Ciocaltea Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320160137.GB1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> <80796828-7b38-184a-2e8e-3cfe9158b67f@linaro.org> <13cb8dbd-994c-4b38-b715-44a3bf3d278d@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Message-ID-Hash: 2GQUJWG7T64PQTMC565WH2YPFEU225X6 X-Message-ID-Hash: 2GQUJWG7T64PQTMC565WH2YPFEU225X6 X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Conor Dooley , Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Mar 17, 2023 at 07:43:53PM +0200, Cristian Ciocaltea wrote: > On 3/17/23 18:26, Conor Dooley wrote: > > On Fri, Mar 17, 2023 at 04:54:47PM +0100, Krzysztof Kozlowski wrote: > > > On 17/03/2023 11:21, Cristian Ciocaltea wrote: > > > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > > > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > > > > dma-names properties") documented dma-names property to handle Allwiner > > > > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > > > > the reverse of what a different board expects: > > > > > > > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > > > > other DT files: > > > > > > > > > > Why not fixing the DTS? The properties should have fixed order. > > > > > > > > I was initially concerned about the risk of a potential ABI breakage, > > > > but I think that's not really a problem since dma-names is not directly > > > > accessed in the driver and DT Kernel API doesn't rely on a particular order. > > > > > > > > If there are no objections, I would switch the order in the binding to > > > > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > > > > Since we added the order recently, I rather assume it is the correct or > > > preferred one. > > > > IIRC I checked around the other serial bindings & there was not a > > consistent order that all serial bindings used, so I picked the order that > > was used across the various allwinner boards that do use dma-names. > > Thanks for clarifying this, Conor! Would it be fine to switch to tx->rx > order as it requires less changes to fix the inconsistencies? > > > Before changing dts files, it's probably a good idea to make sure that > > the dma-names are not used somewhere outside of Linux. > > Right, that means we cannot exclude the ABI breakage concern. Not sure how > easy would be to actually verify this. Hence I wonder if there is really no > chance to allow the flexible order in the binding.. If it changes and someone complains, then yes we'll allow flexible order. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29C31C7618A for ; Mon, 20 Mar 2023 16:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DZUEe/KmjJZPl+/SAmDJNhmxutlGw81cYxTxuT+a+fo=; b=q0hupRu28ajZJS j3AS5stEiskcTByHzEAOrNXEs+OQPmFhl8UzxTLbzkfbion53SWJIZGGA/KCzraBKSK6GwVIclAPs gEkNBtd4NpaW7uZ7uyYvH0uBXDVnMVia4tF8wxundGUjIsFiFln3mxMH7vkI+++7iBNJ60yHNUg7I 8GmxbawWfcil/nr79aeAOjw1ICFq+BF5oWpd7Dd6TcYUhmhqTNWaZgmhW4sV9OHxWTpZz56P1uTpQ IAMqh8OLqpbz/fyT0pT5raEckyicdQtzS+lOFtVOBv0pl8C1rxAax2IkqJ8S5IHk8em6j7W4BJSE4 WGR2kSozUGgTszM6CvXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peHxD-009gC8-1E; Mon, 20 Mar 2023 16:01:47 +0000 Received: from mail-oa1-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peHx9-009gA3-1R; Mon, 20 Mar 2023 16:01:44 +0000 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-177b78067ffso13480526fac.7; Mon, 20 Mar 2023 09:01:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679328101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ycdbh/3im0d0MXCRS+MVRgOfUwsMwW5wd9W+JCKfV/o=; b=sZAroLCBmRrQS/wXmDwZouKvqhtX5fhyOZFIGewgwra1X6RhcFoTLzCcWJHMZQvzDZ 97FMjVV6boPDCO87ErpGqp36d6NDX20jbGUCR7fSAzCIPVMBBmCdQLmF1QPp9Koplb4e DNu2eudYu6aX2HdxFy8tWpXhyiJG0bd7FjOKfGQhGikkVnvLy3Zv+c7JWNm4co/I/VWG T5gE52NxYRYZSPvoMDiDMz5J3SiCutpL3Ts2aHyABK1PosyWV2a0wGsEp77Xw2ZYDirQ bEGN8pTUJWttfN+v/bG8/+8wuE00ua9uDy5976iNqJdy8NuKekiw1ccX84yRTSmJxulD kdBw== X-Gm-Message-State: AO0yUKVKSdjAvxtTsaSaFtHp0BMpEJ9rwZr8PqBfYKiL4Jn4j7niKNS1 7NsMYxPObieQo63EodrWwan3qad2Ig== X-Google-Smtp-Source: AK7set+BBHYnuq6OwVL9kjgfa2qix8lcrHAvO1bkzPcA8ohY9QPJdfChG4+hLAEfhyzub/UAI84YdA== X-Received: by 2002:a05:6870:330a:b0:177:b026:3cda with SMTP id x10-20020a056870330a00b00177b0263cdamr5812793oae.37.1679328099533; Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id tb7-20020a05687186c700b0017630fe87e5sm3404469oab.33.2023.03.20.09.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: (nullmailer pid 1764454 invoked by uid 1000); Mon, 20 Mar 2023 16:01:37 -0000 Date: Mon, 20 Mar 2023 11:01:37 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Conor Dooley , Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320160137.GB1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> <80796828-7b38-184a-2e8e-3cfe9158b67f@linaro.org> <13cb8dbd-994c-4b38-b715-44a3bf3d278d@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_090143_481361_42899E5E X-CRM114-Status: GOOD ( 28.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 07:43:53PM +0200, Cristian Ciocaltea wrote: > On 3/17/23 18:26, Conor Dooley wrote: > > On Fri, Mar 17, 2023 at 04:54:47PM +0100, Krzysztof Kozlowski wrote: > > > On 17/03/2023 11:21, Cristian Ciocaltea wrote: > > > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > > > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > > > > dma-names properties") documented dma-names property to handle Allwiner > > > > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > > > > the reverse of what a different board expects: > > > > > > > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > > > > other DT files: > > > > > > > > > > Why not fixing the DTS? The properties should have fixed order. > > > > > > > > I was initially concerned about the risk of a potential ABI breakage, > > > > but I think that's not really a problem since dma-names is not directly > > > > accessed in the driver and DT Kernel API doesn't rely on a particular order. > > > > > > > > If there are no objections, I would switch the order in the binding to > > > > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > > > > Since we added the order recently, I rather assume it is the correct or > > > preferred one. > > > > IIRC I checked around the other serial bindings & there was not a > > consistent order that all serial bindings used, so I picked the order that > > was used across the various allwinner boards that do use dma-names. > > Thanks for clarifying this, Conor! Would it be fine to switch to tx->rx > order as it requires less changes to fix the inconsistencies? > > > Before changing dts files, it's probably a good idea to make sure that > > the dma-names are not used somewhere outside of Linux. > > Right, that means we cannot exclude the ABI breakage concern. Not sure how > easy would be to actually verify this. Hence I wonder if there is really no > chance to allow the flexible order in the binding.. If it changes and someone complains, then yes we'll allow flexible order. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19BDAC6FD1D for ; Mon, 20 Mar 2023 16:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FzuruGWIL3I80iHFa5DijkzOZDI+5udcHkcLoXSM4KI=; b=kKodRgBC72Y+Uz 7xJbOlGXz3bhB2SrFquC8kVDUgg32F7+eGF10ep5yo0OkWd3nrxFqcREFvkhpWn7mx/ZXj+1AtyWn 1YMA/oaS/Lbo+d6nTZKfJoHENiHNawq2tWXs7F0SjJWBkX14ihHnbsJinZVXlGbk/QwR+TQu9kAAs pWBnKZmIhZt6C4WYTkdzX3htn/MnOPYQjE/+EILDVYHJRTN+d4aM4rpCX0db+QMWk4zr6iUNxtOWn refm6CS5hQH7doqjHxZ6wbh0dZU9uCJYfmUdpKTs9OmYKc7cqkB0AFj7rhuh2d1dfrdhqnBbsEwbk 8Mf0ATOxTx0l7MBKS11w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peHxD-009gCL-2g; Mon, 20 Mar 2023 16:01:47 +0000 Received: from mail-oa1-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peHx9-009gA3-1R; Mon, 20 Mar 2023 16:01:44 +0000 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-177b78067ffso13480526fac.7; Mon, 20 Mar 2023 09:01:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679328101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ycdbh/3im0d0MXCRS+MVRgOfUwsMwW5wd9W+JCKfV/o=; b=sZAroLCBmRrQS/wXmDwZouKvqhtX5fhyOZFIGewgwra1X6RhcFoTLzCcWJHMZQvzDZ 97FMjVV6boPDCO87ErpGqp36d6NDX20jbGUCR7fSAzCIPVMBBmCdQLmF1QPp9Koplb4e DNu2eudYu6aX2HdxFy8tWpXhyiJG0bd7FjOKfGQhGikkVnvLy3Zv+c7JWNm4co/I/VWG T5gE52NxYRYZSPvoMDiDMz5J3SiCutpL3Ts2aHyABK1PosyWV2a0wGsEp77Xw2ZYDirQ bEGN8pTUJWttfN+v/bG8/+8wuE00ua9uDy5976iNqJdy8NuKekiw1ccX84yRTSmJxulD kdBw== X-Gm-Message-State: AO0yUKVKSdjAvxtTsaSaFtHp0BMpEJ9rwZr8PqBfYKiL4Jn4j7niKNS1 7NsMYxPObieQo63EodrWwan3qad2Ig== X-Google-Smtp-Source: AK7set+BBHYnuq6OwVL9kjgfa2qix8lcrHAvO1bkzPcA8ohY9QPJdfChG4+hLAEfhyzub/UAI84YdA== X-Received: by 2002:a05:6870:330a:b0:177:b026:3cda with SMTP id x10-20020a056870330a00b00177b0263cdamr5812793oae.37.1679328099533; Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id tb7-20020a05687186c700b0017630fe87e5sm3404469oab.33.2023.03.20.09.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: (nullmailer pid 1764454 invoked by uid 1000); Mon, 20 Mar 2023 16:01:37 -0000 Date: Mon, 20 Mar 2023 11:01:37 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Conor Dooley , Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320160137.GB1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> <80796828-7b38-184a-2e8e-3cfe9158b67f@linaro.org> <13cb8dbd-994c-4b38-b715-44a3bf3d278d@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_090143_481361_42899E5E X-CRM114-Status: GOOD ( 28.73 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 07:43:53PM +0200, Cristian Ciocaltea wrote: > On 3/17/23 18:26, Conor Dooley wrote: > > On Fri, Mar 17, 2023 at 04:54:47PM +0100, Krzysztof Kozlowski wrote: > > > On 17/03/2023 11:21, Cristian Ciocaltea wrote: > > > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > > > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > > > > dma-names properties") documented dma-names property to handle Allwiner > > > > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > > > > the reverse of what a different board expects: > > > > > > > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > > > > other DT files: > > > > > > > > > > Why not fixing the DTS? The properties should have fixed order. > > > > > > > > I was initially concerned about the risk of a potential ABI breakage, > > > > but I think that's not really a problem since dma-names is not directly > > > > accessed in the driver and DT Kernel API doesn't rely on a particular order. > > > > > > > > If there are no objections, I would switch the order in the binding to > > > > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > > > > Since we added the order recently, I rather assume it is the correct or > > > preferred one. > > > > IIRC I checked around the other serial bindings & there was not a > > consistent order that all serial bindings used, so I picked the order that > > was used across the various allwinner boards that do use dma-names. > > Thanks for clarifying this, Conor! Would it be fine to switch to tx->rx > order as it requires less changes to fix the inconsistencies? > > > Before changing dts files, it's probably a good idea to make sure that > > the dma-names are not used somewhere outside of Linux. > > Right, that means we cannot exclude the ABI breakage concern. Not sure how > easy would be to actually verify this. Hence I wonder if there is really no > chance to allow the flexible order in the binding.. If it changes and someone complains, then yes we'll allow flexible order. Rob _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F89C7618A for ; Mon, 20 Mar 2023 16:17:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjCTQRt (ORCPT ); Mon, 20 Mar 2023 12:17:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbjCTQR1 (ORCPT ); Mon, 20 Mar 2023 12:17:27 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 086D930191; Mon, 20 Mar 2023 09:07:15 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-17ac5ee3f9cso13438324fac.12; Mon, 20 Mar 2023 09:07:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679328101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ycdbh/3im0d0MXCRS+MVRgOfUwsMwW5wd9W+JCKfV/o=; b=E+Pr8u9gmHBQZTNZQpUc9GvmZnrdszR9iS+GmECWvFOGiFG58/sXvKMBj66J9oYgrF Ax3wqSdk2q7Gv/Ewv0qKdreErNrtDXfMenESWsR5yB1b+hmUtAtq7ypozTdq0kMv5mHb SoTrRSsxM7BigWl6S73GK8jB/+JZATNbTt0hyjitN9HaLeaV/UjKXIsru+WJMcYfI6Qt bfMEn87SzBcSPYrQXaTDGP4oZf+vJDHOE8zOnYHAlKgzFElKGkvJpsXWNc6SKg6g5Ptd hYmAl/3pF6eXUa4UKxtjHhAJyVX+oSRvnTbUjWfkX8LZ0Kc2wVFhmvvnoJyoeqoCAn+I tLxA== X-Gm-Message-State: AO0yUKVo/HF1Hy8w2GoV2jXcKIPAMujWIDZp7gTt9aC7TphY0Hcoqqxx L2qQfsN2L8uc33Qa1987vw== X-Google-Smtp-Source: AK7set+BBHYnuq6OwVL9kjgfa2qix8lcrHAvO1bkzPcA8ohY9QPJdfChG4+hLAEfhyzub/UAI84YdA== X-Received: by 2002:a05:6870:330a:b0:177:b026:3cda with SMTP id x10-20020a056870330a00b00177b0263cdamr5812793oae.37.1679328099533; Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id tb7-20020a05687186c700b0017630fe87e5sm3404469oab.33.2023.03.20.09.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: (nullmailer pid 1764454 invoked by uid 1000); Mon, 20 Mar 2023 16:01:37 -0000 Date: Mon, 20 Mar 2023 11:01:37 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Conor Dooley , Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320160137.GB1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> <80796828-7b38-184a-2e8e-3cfe9158b67f@linaro.org> <13cb8dbd-994c-4b38-b715-44a3bf3d278d@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Mar 17, 2023 at 07:43:53PM +0200, Cristian Ciocaltea wrote: > On 3/17/23 18:26, Conor Dooley wrote: > > On Fri, Mar 17, 2023 at 04:54:47PM +0100, Krzysztof Kozlowski wrote: > > > On 17/03/2023 11:21, Cristian Ciocaltea wrote: > > > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > > > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > > > > dma-names properties") documented dma-names property to handle Allwiner > > > > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > > > > the reverse of what a different board expects: > > > > > > > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > > > > other DT files: > > > > > > > > > > Why not fixing the DTS? The properties should have fixed order. > > > > > > > > I was initially concerned about the risk of a potential ABI breakage, > > > > but I think that's not really a problem since dma-names is not directly > > > > accessed in the driver and DT Kernel API doesn't rely on a particular order. > > > > > > > > If there are no objections, I would switch the order in the binding to > > > > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > > > > Since we added the order recently, I rather assume it is the correct or > > > preferred one. > > > > IIRC I checked around the other serial bindings & there was not a > > consistent order that all serial bindings used, so I picked the order that > > was used across the various allwinner boards that do use dma-names. > > Thanks for clarifying this, Conor! Would it be fine to switch to tx->rx > order as it requires less changes to fix the inconsistencies? > > > Before changing dts files, it's probably a good idea to make sure that > > the dma-names are not used somewhere outside of Linux. > > Right, that means we cannot exclude the ABI breakage concern. Not sure how > easy would be to actually verify this. Hence I wonder if there is really no > chance to allow the flexible order in the binding.. If it changes and someone complains, then yes we'll allow flexible order. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 273E2C7618A for ; Mon, 20 Mar 2023 16:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g2H7FnzFHpYCMLoOnmZJFqI84zTGllHJphXHk8pSytM=; b=EkMtglJzaPQRbL RE0KoAt1azA2sIoLnREJDnV+eX7RLZodCtLCGBm4mf6fV0u44vpw60TnVkhowVnp+4KkAQ44cZPC6 NNfG6VVx+N8wD1BghsUQZKCG6ZHnToKcVXslMrTYiHGGIuCC/f3gaRkVnijek17GG/JQoZ5AimFA8 GJG5ibA5tlZKxGTQgQ046xdayf9/zFzHDbK7VasuWf25vXZ30IEcKzjmRxgyazZADJoRrm3UwMLFq EW9P8gN/qHQqjZuW01+Ru1l/rseJkJrjdSIVnxi+Fm1eorOYUiiAN2sSchtAttYQNzWqn3r3CSEua 4HSGnzIvjApBndx3YLbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peHxC-009gBr-1E; Mon, 20 Mar 2023 16:01:46 +0000 Received: from mail-oa1-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peHx9-009gA3-1R; Mon, 20 Mar 2023 16:01:44 +0000 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-177b78067ffso13480526fac.7; Mon, 20 Mar 2023 09:01:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679328101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ycdbh/3im0d0MXCRS+MVRgOfUwsMwW5wd9W+JCKfV/o=; b=sZAroLCBmRrQS/wXmDwZouKvqhtX5fhyOZFIGewgwra1X6RhcFoTLzCcWJHMZQvzDZ 97FMjVV6boPDCO87ErpGqp36d6NDX20jbGUCR7fSAzCIPVMBBmCdQLmF1QPp9Koplb4e DNu2eudYu6aX2HdxFy8tWpXhyiJG0bd7FjOKfGQhGikkVnvLy3Zv+c7JWNm4co/I/VWG T5gE52NxYRYZSPvoMDiDMz5J3SiCutpL3Ts2aHyABK1PosyWV2a0wGsEp77Xw2ZYDirQ bEGN8pTUJWttfN+v/bG8/+8wuE00ua9uDy5976iNqJdy8NuKekiw1ccX84yRTSmJxulD kdBw== X-Gm-Message-State: AO0yUKVKSdjAvxtTsaSaFtHp0BMpEJ9rwZr8PqBfYKiL4Jn4j7niKNS1 7NsMYxPObieQo63EodrWwan3qad2Ig== X-Google-Smtp-Source: AK7set+BBHYnuq6OwVL9kjgfa2qix8lcrHAvO1bkzPcA8ohY9QPJdfChG4+hLAEfhyzub/UAI84YdA== X-Received: by 2002:a05:6870:330a:b0:177:b026:3cda with SMTP id x10-20020a056870330a00b00177b0263cdamr5812793oae.37.1679328099533; Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id tb7-20020a05687186c700b0017630fe87e5sm3404469oab.33.2023.03.20.09.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 09:01:39 -0700 (PDT) Received: (nullmailer pid 1764454 invoked by uid 1000); Mon, 20 Mar 2023 16:01:37 -0000 Date: Mon, 20 Mar 2023 11:01:37 -0500 From: Rob Herring To: Cristian Ciocaltea Cc: Conor Dooley , Krzysztof Kozlowski , Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Nicolas Frattaroli , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Drake , Katsuhiro Suzuki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Message-ID: <20230320160137.GB1755078-robh@kernel.org> References: <20230315114806.3819515-1-cristian.ciocaltea@collabora.com> <20230315114806.3819515-3-cristian.ciocaltea@collabora.com> <3679f2d0-55f0-1710-abc2-b268b6fc6969@linaro.org> <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com> <80796828-7b38-184a-2e8e-3cfe9158b67f@linaro.org> <13cb8dbd-994c-4b38-b715-44a3bf3d278d@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_090143_481361_42899E5E X-CRM114-Status: GOOD ( 28.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 07:43:53PM +0200, Cristian Ciocaltea wrote: > On 3/17/23 18:26, Conor Dooley wrote: > > On Fri, Mar 17, 2023 at 04:54:47PM +0100, Krzysztof Kozlowski wrote: > > > On 17/03/2023 11:21, Cristian Ciocaltea wrote: > > > > On 3/17/23 10:31, Krzysztof Kozlowski wrote: > > > > > On 15/03/2023 12:47, Cristian Ciocaltea wrote: > > > > > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > > > > > > dma-names properties") documented dma-names property to handle Allwiner > > > > > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is > > > > > > the reverse of what a different board expects: > > > > > > > > > > > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected > > > > > > > > > > > > A quick and incomplete check shows the inconsistency is present in many > > > > > > other DT files: > > > > > > > > > > Why not fixing the DTS? The properties should have fixed order. > > > > > > > > I was initially concerned about the risk of a potential ABI breakage, > > > > but I think that's not really a problem since dma-names is not directly > > > > accessed in the driver and DT Kernel API doesn't rely on a particular order. > > > > > > > > If there are no objections, I would switch the order in the binding to > > > > tx->rx, since that's what most of the DTS use, and fix the remaining ones. > > > > > > Since we added the order recently, I rather assume it is the correct or > > > preferred one. > > > > IIRC I checked around the other serial bindings & there was not a > > consistent order that all serial bindings used, so I picked the order that > > was used across the various allwinner boards that do use dma-names. > > Thanks for clarifying this, Conor! Would it be fine to switch to tx->rx > order as it requires less changes to fix the inconsistencies? > > > Before changing dts files, it's probably a good idea to make sure that > > the dma-names are not used somewhere outside of Linux. > > Right, that means we cannot exclude the ABI breakage concern. Not sure how > easy would be to actually verify this. Hence I wonder if there is really no > chance to allow the flexible order in the binding.. If it changes and someone complains, then yes we'll allow flexible order. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel