From: Joe Korty <joe.korty@concurrent-rt.com>
To: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 5.10.162-rt78] Restore initialization of wake_q_sleeper.next in fork.c
Date: Mon, 20 Mar 2023 16:04:07 -0400 [thread overview]
Message-ID: <20230320200407.GA39185@zipoli.concurrent-rt.com> (raw)
In-Reply-To: <ZBi7TbNgBAZL6tdw@uudg.org>
On Mon, Mar 20, 2023 at 05:00:13PM -0300, Luis Claudio R. Goncalves wrote:
> On Mon, Mar 20, 2023 at 03:37:31PM -0400, Joe Korty wrote:
> > In the transition from 5.10.158-rt77 to 5.10.162-rt78,
> > the initialization of task_struct::wake_q_sleeper.next
> > was dropped. Restore it.
> >
> > This appears to be only a problem in 5.10. 5.15 does not
> > have wake_q_sleeper; 4.19 does have it but its initialization
> > there is still present.
> >
> > The 5.10.162-rt78 patch that damaged fork.c is:
> >
> > 0170-locking-rtmutex-add-sleeping-lock-implementation.patch
> >
> > I do not have a simple test that brings out this problem.
> > My test consists of a shell script and eight binaries,
> > all of which were written in Ada. strace shows that it
> > does a few thousand forks in rapid succession. One of the
> > forks stalls out, after which no fork after that returns.
> > Eventually the 122 second stallout occurs and a large
> > number of threads are shown to be waiting for tasklist
> > lock, either in do_exit or in copy_process. The kernel
> > .config has rt and many debug features enabled, lockdep
> > included.
>
> Joe, thank you for investigating that problem and for writing a patch.
>
> Earlier today Steffen Dirkwinkel sent a similar patch:
>
> https://lore.kernel.org/all/20230320080347.32434-1-linux@steffen.cc/
>
> Would you mind giving your ACK to his patch? I have that patch queued for
> my next build already.
Acked-by: Joe Korty <joe.korty@concurrent-rt.com>
prev parent reply other threads:[~2023-03-20 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 19:37 [PATCH 5.10.162-rt78] Restore initialization of wake_q_sleeper.next in fork.c Joe Korty
2023-03-20 20:00 ` Luis Claudio R. Goncalves
2023-03-20 20:04 ` Joe Korty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320200407.GA39185@zipoli.concurrent-rt.com \
--to=joe.korty@concurrent-rt.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.