All of lore.kernel.org
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
	<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH v2 6/7] virtio-net: Avoid duplicate receive queue example
Date: Tue, 21 Mar 2023 06:10:35 +0200	[thread overview]
Message-ID: <20230321041036.201439-7-parav@nvidia.com> (raw)
In-Reply-To: <20230321041036.201439-1-parav@nvidia.com>

Receive queue number/index example is duplicate which is already defined
in the Setting RSS parameters section.

Hence, avoid such duplicate example and prepare it for the subsequent
patch to describe using receive queue handle.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 device-types/net/description.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index d7c8b1b..435c1fc 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -1467,8 +1467,8 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 The device MUST determine the destination queue for a network packet as follows:
 \begin{itemize}
 \item Calculate the hash of the packet as defined in \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets}.
-\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure (value of 0 corresponds to receiveq1).
-\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq (value of 0 corresponds to receiveq1).
+\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure.
+\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq.
 \item If the destination receive queue is being reset (See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device MUST drop the packet.
 \end{itemize}
 
-- 
2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
	<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v2 6/7] virtio-net: Avoid duplicate receive queue example
Date: Tue, 21 Mar 2023 06:10:35 +0200	[thread overview]
Message-ID: <20230321041036.201439-7-parav@nvidia.com> (raw)
In-Reply-To: <20230321041036.201439-1-parav@nvidia.com>

Receive queue number/index example is duplicate which is already defined
in the Setting RSS parameters section.

Hence, avoid such duplicate example and prepare it for the subsequent
patch to describe using receive queue handle.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 device-types/net/description.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index d7c8b1b..435c1fc 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -1467,8 +1467,8 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 The device MUST determine the destination queue for a network packet as follows:
 \begin{itemize}
 \item Calculate the hash of the packet as defined in \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets}.
-\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure (value of 0 corresponds to receiveq1).
-\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq (value of 0 corresponds to receiveq1).
+\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure.
+\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq.
 \item If the destination receive queue is being reset (See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device MUST drop the packet.
 \end{itemize}
 
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-03-21  4:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21  4:10 [virtio-comment] [PATCH v2 0/7] Rename queue index to queue number Parav Pandit
2023-03-21  4:10 ` [virtio-dev] " Parav Pandit
2023-03-21  4:10 ` [virtio-comment] [PATCH v2 1/7] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-21  4:10   ` [virtio-dev] " Parav Pandit
2023-03-21  9:01   ` [virtio-comment] " Michael S. Tsirkin
2023-03-21  9:01     ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 20:43     ` Parav Pandit
2023-03-21 20:43       ` [virtio-dev] " Parav Pandit
2023-03-21  4:10 ` [virtio-comment] [PATCH v2 2/7] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-21  4:10   ` [virtio-dev] " Parav Pandit
2023-03-21  4:10 ` [virtio-comment] [PATCH v2 3/7] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-21  4:10   ` [virtio-dev] " Parav Pandit
2023-03-21  4:10 ` [virtio-comment] [PATCH v2 4/7] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-21  4:10   ` [virtio-dev] " Parav Pandit
2023-03-21  4:10 ` [virtio-comment] [PATCH v2 5/7] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-21  4:10   ` [virtio-dev] " Parav Pandit
2023-03-21  8:46   ` [virtio-comment] " Michael S. Tsirkin
2023-03-21  8:46     ` [virtio-dev] " Michael S. Tsirkin
2023-03-21  4:10 ` Parav Pandit [this message]
2023-03-21  4:10   ` [virtio-dev] [PATCH v2 6/7] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-21  4:10 ` [virtio-comment] [PATCH v2 7/7] virtio-net: Describe RSS using receive queue handle Parav Pandit
2023-03-21  4:10   ` [virtio-dev] " Parav Pandit
2023-03-21  8:55   ` [virtio-comment] " Michael S. Tsirkin
2023-03-21  8:55     ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 20:54     ` [virtio-comment] " Parav Pandit
2023-03-21 20:54       ` [virtio-dev] " Parav Pandit
2023-03-21 21:15       ` [virtio-comment] " Parav Pandit
2023-03-21 21:15         ` [virtio-dev] " Parav Pandit
2023-03-21  9:05 ` [virtio-comment] Re: [PATCH v2 0/7] Rename queue index to queue number Michael S. Tsirkin
2023-03-21  9:05   ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 20:57   ` [virtio-comment] " Parav Pandit
2023-03-21 20:57     ` [virtio-dev] " Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321041036.201439-7-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.