From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7342DC76195 for ; Tue, 21 Mar 2023 21:11:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230185AbjCUVLw (ORCPT ); Tue, 21 Mar 2023 17:11:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbjCUVLo (ORCPT ); Tue, 21 Mar 2023 17:11:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F0157D35 for ; Tue, 21 Mar 2023 14:11:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 729B6B81A3E for ; Tue, 21 Mar 2023 21:11:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B154C433A0; Tue, 21 Mar 2023 21:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679433100; bh=p/p33At2klrA/IcrqTwWIbz3rg4gn0S5yPOQjgFIlJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uxc5zicvjNKHFmz7K0bdEYLdEK642ejTvGTDbR0ugqEmzCvYxVaGHx6fJQdxiQkBQ HyQQwrMpiMWfW6JDtTk9xAEMU27gDbkniZjwHeyH4nh31IgJ8evXeXS/3Rjrq/zhOv YmVirSfRvqIsf45n2ZSsS6PXXcqOBb15EVFByXEh/pUvV5hmUfTdvjmejlT3/J2cpH aqvvd/f/EIV0bMOWBt7uvn4u/LR79b1UZ2G3tRb6hnRovk5hOKodshgyCsLGBcX91h 0BC+ocXbBwjw3tTa/O67DaOq00RNisvoFQjk/pXUUY4p3QealKWi4+fFUx1QfterJE 0Ak0nuqeTTXiQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Roy Novich , Aya Levin Subject: [net 4/7] net/mlx5e: Initialize link speed to zero Date: Tue, 21 Mar 2023 14:11:32 -0700 Message-Id: <20230321211135.47711-5-saeed@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321211135.47711-1-saeed@kernel.org> References: <20230321211135.47711-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roy Novich mlx5e_port_max_linkspeed does not guarantee value assignment for speed. Avoid cases where link_speed might be used uninitialized. In case mlx5e_port_max_linkspeed fails, a default link speed of 50000 will be used for the calculations. Fixes: 3f6d08d196b2 ("net/mlx5e: Add RSS support for hairpin") Signed-off-by: Roy Novich Reviewed-by: Tariq Toukan Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 6bfed633343a..87a2850b32d0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -1103,8 +1103,8 @@ static void mlx5e_hairpin_params_init(struct mlx5e_hairpin_params *hairpin_params, struct mlx5_core_dev *mdev) { + u32 link_speed = 0; u64 link_speed64; - u32 link_speed; hairpin_params->mdev = mdev; /* set hairpin pair per each 50Gbs share of the link */ -- 2.39.2