From: Stephen Hemminger <stephen@networkplumber.org>
To: Bing Zhao <bingz@nvidia.com>
Cc: <viacheslavo@nvidia.com>, <matan@nvidia.com>, <dev@dpdk.org>,
<rasland@nvidia.com>, <stable@dpdk.org>
Subject: Re: [PATCH v2] common/mlx5: fix the sysfs port name translation
Date: Wed, 22 Mar 2023 07:58:42 -0700 [thread overview]
Message-ID: <20230322075842.4547c8d1@hermes.local> (raw)
In-Reply-To: <20230322113412.685653-1-bingz@nvidia.com>
On Wed, 22 Mar 2023 13:34:12 +0200
Bing Zhao <bingz@nvidia.com> wrote:
> +
> + port_name = (char *)malloc(IF_NAMESIZE);
> + if (port_name == NULL) {
> + fclose(file);
> + rte_errno = ENOMEM;
> + return -rte_errno;
> + }
> + line_size = getline(&port_name, &port_name_size, file);
This code is doing unnecessary extra work here.
From getline() man page:
If *lineptr is set to NULL before the call, then getline() will
allocate a buffer for storing the line. This buffer should be
freed by the user program even if getline() failed.
next prev parent reply other threads:[~2023-03-22 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:57 [PATCH] common/mlx5: fix the sysfs port name translation Bing Zhao
2022-11-10 16:21 ` Stephen Hemminger
2022-11-11 5:41 ` Bing Zhao
2022-11-11 17:38 ` Stephen Hemminger
2023-03-22 11:34 ` [PATCH v2] " Bing Zhao
2023-03-22 14:58 ` Stephen Hemminger [this message]
2023-03-23 8:20 ` Bing Zhao
2023-03-22 14:59 ` Stephen Hemminger
2023-03-23 8:23 ` Bing Zhao
2023-03-23 10:54 ` [PATCH v3] net/mlx5: " Bing Zhao
2023-03-27 15:00 ` Matan Azrad
2023-03-28 8:39 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322075842.4547c8d1@hermes.local \
--to=stephen@networkplumber.org \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.