From: Jakub Kicinski <kuba@kernel.org>
To: "Íñigo Huguet" <ihuguet@redhat.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
habetsm.xilinx@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
Tianhao Zhao <tizhao@redhat.com>,
Jonathan Cooper <jonathan.s.cooper@amd.com>
Subject: Re: [PATCH net] sfc: ef10: don't overwrite offload features at NIC reset
Date: Wed, 22 Mar 2023 11:23:49 -0700 [thread overview]
Message-ID: <20230322112349.0e834126@kernel.org> (raw)
In-Reply-To: <CACT4oucW_A1PyQYszxxvnuG8uhkdzdeUjJpoyTwn-+vQBPJgsQ@mail.gmail.com>
On Wed, 22 Mar 2023 07:47:42 +0100 Íñigo Huguet wrote:
> > Could you clarify what checks were removed? All I can see is the
> > 'NETIF_F_TSO6 requires NETIF_F_IPV6_CSUM' check, and Siena already
> > supported NETIF_F_IPV6_CSUM (it's only Falcon that didn't).
> > Or are you also referring to some items moving from efx.c to the
> > definition of EF10_OFFLOAD_FEATURES? That's fine and matches more
> > closely to what we do for ef100, but again the commit message could
> > explain this better.
> > In any case this should really be two separate patches, with the
> > cleanup part going to net-next.
> > That said, the above is all nit-picky, and the fix looks good, so:
> > Acked-by: Edward Cree <ecree.xilinx@gmail.com>
>
> Hi. Kindly asking about the state of this patch, it is acked since 2
> weeks ago and it appears in patchwork as "changes requested". Is there
> something else I need to do? Thanks!
The commit message needs to be beefed up to answer all questions Ed had.
prev parent reply other threads:[~2023-03-22 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 11:32 [PATCH net] sfc: ef10: don't overwrite offload features at NIC reset Íñigo Huguet
2023-03-08 15:52 ` Edward Cree
2023-03-08 16:25 ` Íñigo Huguet
2023-03-22 6:47 ` Íñigo Huguet
2023-03-22 18:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322112349.0e834126@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=jonathan.s.cooper@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.