From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC9D8C6FD1F for ; Wed, 22 Mar 2023 20:06:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B3D1AF15; Wed, 22 Mar 2023 21:05:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B3D1AF15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679515597; bh=I86NJCPu1+KiO59bQFYOpha356Tl4KQfy3wuYdiGe9c=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=k88wUObkCkmSwplOzoIkAYlNj1dw9onMsoLW1hR0g0hV2DMzvAA0b4q3Qh8xkC5x9 6ywTLahNGkRXtaMDjB8g7yidbf17334s74BGf/7Z/iRC9DxPXgPX7duLJKk3eA0brC 60+VDSRt7ABBilf+g4fKtbpeFYo+qbg9kxv+bll8= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8D64AF80548; Wed, 22 Mar 2023 21:02:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C861BF80544; Wed, 22 Mar 2023 21:02:21 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DB174F80529 for ; Wed, 22 Mar 2023 21:02:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DB174F80529 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XkBRsrer Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 824B8B81DEE; Wed, 22 Mar 2023 20:02:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B5CBC433EF; Wed, 22 Mar 2023 20:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679515338; bh=I86NJCPu1+KiO59bQFYOpha356Tl4KQfy3wuYdiGe9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XkBRsrer3oaKUfO5yC1ysymSqCzvnOBJzkibPVCEkKniccUcb8515Y/A4rvWK4piq r2G0pz32W6SCbjqK5wLEtPq88JyeXwcuss1ioKKEJo6g04nrfqUWsfzZ+8zNFQJZhz +dtBeVI7420m/JuDgcFv2NCVgQDLgF2ZDd/XAh2UHOlpdCpQaYHvQL7YCwfS6mqjtl 5i1HP4TwOlDSPviUnW85zM5be/gh8MwMBXA+aAIU9ZF2zzcl9bhh6pyhkDfJUjYsF3 obqJPCGdcrswq7lrhiouRNTCxXaIfpd2uTXABOUlEyx5IHV7q27rl2bDXCQnj1UQF4 FBPyvXHjwcxEg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 03/12] ALSA: asihpi: check pao in control_message() Date: Wed, 22 Mar 2023 16:01:57 -0400 Message-Id: <20230322200207.1997367-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322200207.1997367-1-sashal@kernel.org> References: <20230322200207.1997367-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Message-ID-Hash: ZWIVJA4IO64TVVJRYR7Q4HX64N342SPJ X-Message-ID-Hash: ZWIVJA4IO64TVVJRYR7Q4HX64N342SPJ X-MailFrom: sashal@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kuninori Morimoto , Takashi Iwai , Sasha Levin , tiwai@suse.com, dengshaomin@cdjrlc.com, alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kuninori Morimoto [ Upstream commit 9026c0bf233db53b86f74f4c620715e94eb32a09 ] control_message() might be called with pao = NULL. Here indicates control_message() as sample. (B) static void control_message(struct hpi_adapter_obj *pao, ...) { ^^^ struct hpi_hw_obj *phw = pao->priv; ... ^^^ } (A) void _HPI_6205(struct hpi_adapter_obj *pao, ...) { ^^^ ... case HPI_OBJ_CONTROL: (B) control_message(pao, phm, phr); break; ^^^ ... } void HPI_6205(...) { ... (A) _HPI_6205(NULL, phm, phr); ... ^^^^ } Therefore, We will get too many warning via cppcheck, like below sound/pci/asihpi/hpi6205.c:238:27: warning: Possible null pointer dereference: pao [nullPointer] struct hpi_hw_obj *phw = pao->priv; ^ sound/pci/asihpi/hpi6205.c:433:13: note: Calling function '_HPI_6205', 1st argument 'NULL' value is 0 _HPI_6205(NULL, phm, phr); ^ sound/pci/asihpi/hpi6205.c:401:20: note: Calling function 'control_message', 1st argument 'pao' value is 0 control_message(pao, phm, phr); ^ Set phr->error like many functions doing, and don't call _HPI_6205() with NULL. Signed-off-by: Kuninori Morimoto Link: https://lore.kernel.org/r/87ttypeaqz.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/asihpi/hpi6205.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/asihpi/hpi6205.c b/sound/pci/asihpi/hpi6205.c index 3d6914c64c4a8..4cdaeefeb6885 100644 --- a/sound/pci/asihpi/hpi6205.c +++ b/sound/pci/asihpi/hpi6205.c @@ -430,7 +430,7 @@ void HPI_6205(struct hpi_message *phm, struct hpi_response *phr) pao = hpi_find_adapter(phm->adapter_index); } else { /* subsys messages don't address an adapter */ - _HPI_6205(NULL, phm, phr); + phr->error = HPI_ERROR_INVALID_OBJ_INDEX; return; } -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D95C76196 for ; Wed, 22 Mar 2023 20:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232059AbjCVULD (ORCPT ); Wed, 22 Mar 2023 16:11:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbjCVUKO (ORCPT ); Wed, 22 Mar 2023 16:10:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D84556C6A3; Wed, 22 Mar 2023 13:03:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A17A2B81DEB; Wed, 22 Mar 2023 20:02:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B5CBC433EF; Wed, 22 Mar 2023 20:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679515338; bh=I86NJCPu1+KiO59bQFYOpha356Tl4KQfy3wuYdiGe9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XkBRsrer3oaKUfO5yC1ysymSqCzvnOBJzkibPVCEkKniccUcb8515Y/A4rvWK4piq r2G0pz32W6SCbjqK5wLEtPq88JyeXwcuss1ioKKEJo6g04nrfqUWsfzZ+8zNFQJZhz +dtBeVI7420m/JuDgcFv2NCVgQDLgF2ZDd/XAh2UHOlpdCpQaYHvQL7YCwfS6mqjtl 5i1HP4TwOlDSPviUnW85zM5be/gh8MwMBXA+aAIU9ZF2zzcl9bhh6pyhkDfJUjYsF3 obqJPCGdcrswq7lrhiouRNTCxXaIfpd2uTXABOUlEyx5IHV7q27rl2bDXCQnj1UQF4 FBPyvXHjwcxEg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kuninori Morimoto , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, dengshaomin@cdjrlc.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.10 03/12] ALSA: asihpi: check pao in control_message() Date: Wed, 22 Mar 2023 16:01:57 -0400 Message-Id: <20230322200207.1997367-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322200207.1997367-1-sashal@kernel.org> References: <20230322200207.1997367-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kuninori Morimoto [ Upstream commit 9026c0bf233db53b86f74f4c620715e94eb32a09 ] control_message() might be called with pao = NULL. Here indicates control_message() as sample. (B) static void control_message(struct hpi_adapter_obj *pao, ...) { ^^^ struct hpi_hw_obj *phw = pao->priv; ... ^^^ } (A) void _HPI_6205(struct hpi_adapter_obj *pao, ...) { ^^^ ... case HPI_OBJ_CONTROL: (B) control_message(pao, phm, phr); break; ^^^ ... } void HPI_6205(...) { ... (A) _HPI_6205(NULL, phm, phr); ... ^^^^ } Therefore, We will get too many warning via cppcheck, like below sound/pci/asihpi/hpi6205.c:238:27: warning: Possible null pointer dereference: pao [nullPointer] struct hpi_hw_obj *phw = pao->priv; ^ sound/pci/asihpi/hpi6205.c:433:13: note: Calling function '_HPI_6205', 1st argument 'NULL' value is 0 _HPI_6205(NULL, phm, phr); ^ sound/pci/asihpi/hpi6205.c:401:20: note: Calling function 'control_message', 1st argument 'pao' value is 0 control_message(pao, phm, phr); ^ Set phr->error like many functions doing, and don't call _HPI_6205() with NULL. Signed-off-by: Kuninori Morimoto Link: https://lore.kernel.org/r/87ttypeaqz.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/asihpi/hpi6205.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/asihpi/hpi6205.c b/sound/pci/asihpi/hpi6205.c index 3d6914c64c4a8..4cdaeefeb6885 100644 --- a/sound/pci/asihpi/hpi6205.c +++ b/sound/pci/asihpi/hpi6205.c @@ -430,7 +430,7 @@ void HPI_6205(struct hpi_message *phm, struct hpi_response *phr) pao = hpi_find_adapter(phm->adapter_index); } else { /* subsys messages don't address an adapter */ - _HPI_6205(NULL, phm, phr); + phr->error = HPI_ERROR_INVALID_OBJ_INDEX; return; } -- 2.39.2