From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
<virtualization@lists.linux-foundation.org>,
<bpf@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/8] virtio_net: mergeable xdp: introduce mergeable_xdp_prepare
Date: Wed, 22 Mar 2023 21:52:57 -0700 [thread overview]
Message-ID: <20230322215257.298b54cb@kernel.org> (raw)
In-Reply-To: <215e791d-1802-2419-ff59-49476bcdcd02@huawei.com>
On Thu, 23 Mar 2023 12:45:41 +0800 Yunsheng Lin wrote:
> >> Also, it seems better to split the xdp_linearize_page() to two functions
> >> as pskb_expand_head() and __skb_linearize() do, one to expand the headroom,
> >> the other one to do the linearizing.
> >
> > No skb here.
>
> I means following the semantics of pskb_expand_head() and __skb_linearize(),
> not to combine the headroom expanding and linearizing into one function as
> xdp_linearize_page() does now if we want a better refoctor result.
It's a driver-local function, if I was reading the code and saw
xdp_prepare_mergeable() I'd have thought it's a function from XDP core.
If anything the functions are missing local driver prefix. But it's
not a huge deal (given Michael's ping yesterday asking us if we can
expedite merging..)
next prev parent reply other threads:[~2023-03-23 4:53 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 3:03 [PATCH net-next 0/8] virtio_net: refactor xdp codes Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 1/8] virtio_net: mergeable xdp: put old page immediately Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 8:22 ` Yunsheng Lin
2023-03-23 1:36 ` Xuan Zhuo
2023-03-23 1:36 ` Xuan Zhuo
2023-03-23 3:38 ` Yunsheng Lin
2023-03-23 3:45 ` Xuan Zhuo
2023-03-23 3:45 ` Xuan Zhuo
2023-03-23 5:38 ` Jason Wang
2023-03-23 5:38 ` Jason Wang
2023-03-23 5:58 ` Xuan Zhuo
2023-03-23 5:58 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 2/8] virtio_net: mergeable xdp: introduce mergeable_xdp_prepare Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 11:52 ` Yunsheng Lin
2023-03-23 1:45 ` Xuan Zhuo
2023-03-23 1:45 ` Xuan Zhuo
2023-03-23 4:45 ` Yunsheng Lin
2023-03-23 4:52 ` Jakub Kicinski [this message]
2023-03-23 5:40 ` Jason Wang
2023-03-23 5:40 ` Jason Wang
2023-03-23 7:24 ` Yunsheng Lin
2023-03-23 11:04 ` Xuan Zhuo
2023-03-23 11:04 ` Xuan Zhuo
2023-03-23 10:59 ` Xuan Zhuo
2023-03-23 10:59 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 3/8] virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 4/8] virtio_net: separate the logic of freeing xdp shinfo Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 5/8] virtio_net: separate the logic of freeing the rest mergeable buf Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 6/8] virtio_net: auto release xdp shinfo Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 3:03 ` [PATCH net-next 7/8] virtio_net: introduce receive_mergeable_xdp() Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-22 23:43 ` kernel test robot
2023-03-22 23:43 ` kernel test robot
2023-03-22 3:03 ` [PATCH net-next 8/8] virtio_net: introduce receive_small_xdp() Xuan Zhuo
2023-03-22 3:03 ` Xuan Zhuo
2023-03-23 2:06 ` kernel test robot
2023-03-23 2:06 ` kernel test robot
2023-03-22 3:34 ` [PATCH net-next 0/8] virtio_net: refactor xdp codes Michael S. Tsirkin
2023-03-22 3:34 ` Michael S. Tsirkin
2023-03-22 3:40 ` Xuan Zhuo
2023-03-22 3:40 ` Xuan Zhuo
2023-03-22 3:53 ` Michael S. Tsirkin
2023-03-22 3:53 ` Michael S. Tsirkin
2023-03-22 3:56 ` Xuan Zhuo
2023-03-22 3:56 ` Xuan Zhuo
2023-03-22 3:59 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-03-28 12:04 Xuan Zhuo
2023-03-28 12:04 ` [PATCH net-next 2/8] virtio_net: mergeable xdp: introduce mergeable_xdp_prepare Xuan Zhuo
2023-03-28 12:04 ` Xuan Zhuo
2023-03-31 9:14 ` Jason Wang
2023-03-31 9:14 ` Jason Wang
2023-04-03 4:11 ` Xuan Zhuo
2023-04-03 4:11 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322215257.298b54cb@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linyunsheng@huawei.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.